Comments (3)
VsFTPd
I found the problem testing with vsftpd server, getting this error when trying to put files :
DEBUG [...] "DATA connection terminated without SSL shutdown. Buggy client! Integrity of upload cannot be asserted."
FTP response: [...] "426 Failure reading network stream."
But retrieving files or getting NLST doesn't cause this error. Maybe the server does the SSL shutdown itself.
The options strict_ssl_read_eof
and strict_ssl_write_shutdown
don't seem to change anything for me (man here)
from suppaftp.
The fix was in the parent repo.
It looks like it's enough, but I might have missed something.
I guess it makes sense to have a function doing the shutdown/drop as it's needed in different places (finalize_put/retr_stream, stream_lines).
I changed finalize_*_stream signatures, but it's not ideal as it would break some users code:
pub fn finalize_put_stream(&mut self, mut stream: BufWriter<DataStream>) -> Result<()>
Do you want to do it yourself or should I start a draft PR ?
from suppaftp.
I think we'll need to change the signature here for sure, so you can start drafting the PR 👍🏻
I totally agree with making a re-usable function.
from suppaftp.
Related Issues (20)
- [BUG] - Ftp with TLS (native-tls) Not working HOT 4
- [QUESTION] - 522 SSL connection failed
- [Feature Request] - Build the docs with doc_cfg
- [BUG] - POSIX setgid/setuid/sticky bits not supported
- [Feature Request] - Better composability HOT 3
- [BUG] - FEAT in asyncFtpStream hangs
- [Feature Request] - Timeouts for active data connection acceptance HOT 1
- [QUESTION] - Is there a plan to support sftp HOT 1
- [BUG] - abort can be called without passing ownership to data_stream HOT 1
- [BUG] - list parser: SyntaxError on name that starts with 2 numbers HOT 1
- [Feature Request] - Implementation of SITE command HOT 2
- [QUESTION] - Potential timeout? Advice on correct usage.
- [BUG] - Active mode commands timeout HOT 4
- [QUESTION] - Does suppaftp support an explicit proxy?
- Which ports to open on the firewall? HOT 4
- [Feature Request] - Make function `connect_with_stream` public
- [Feature Request] - Support MLST and MLSD HOT 3
- [BUG] - put_file does not work with Async SSL Native TLS HOT 3
- [BUG] - The file.log upload to ftp server. then lost \n line breaks HOT 1
- [QUESTION] - Can't connect, no TLS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from suppaftp.