veganista / phpbb3-topic-tagging Goto Github PK

In phpbb_topic_tagging.php, replace page_header($user->lang['PTT_TAGS_RESULT_TITLE']); with something like page_header(($user->lang['PTT_TAGS_RESULT_TITLE']).': '.$search_tag);

Users have requested that permission support is added so that only certain groups/users can post tags

Hi, the mod is really nice, but I think I found a small issue that is the tagging system doesn't accept a special character "%". Others worked fine. I was trying to add some tags like "70% off". It allowed me to add, but after I added it, it returns error:

"Not Acceptable
An appropriate representation of the requested resource /phpbb_topic_tagging.php could not be found on this server.
Additionally, a 404 Not Found
error was encountered while trying to use an ErrorDocument to handle the request."

And I tried to delete the tag from the ACP, it couldn't find it there either.
So could you pelase help me to fix this issue? I really appreciate it!

On line 66, replace $phpbb_root with $phpbb_root_path

As said in title:

http://www.phpbb.com/community/viewtopic.php?p=13049163#p13049163
http://www.phpbb.com/community/viewtopic.php?p=13056042#p13056042

This one really needs fixing.

Under AutoMOD, I ran the install, which worked completely. However, it altered the prosilver style, which I don't use. I use a style derived from prosilver. So I went to the Details page for Topic-Tagging, and under Available Changes, I selected Apply these changes (prosilver) to this template (mystyle).

The changes to the style worked, but the changes to the database failed:

SQL Queries
Success:
CREATE TABLE IF NOT EXISTS phpbb_tags ( topic_id int(11) NOT NULL, tag varchar(255) COLLATE utf8_bin NOT NULL, PRIMARY KEY (topic_id,tag) ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_bin;

Error:Duplicate entry 'ptt_on' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_on', '1', '0');

Error:Duplicate entry 'ptt_tags' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_tags', '60', '0');

Error:Duplicate entry 'ptt_min_font' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_min_font', '9', '0');

Error:Duplicate entry 'ptt_max_font' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_max_font', '28', '0');

Error:Duplicate entry 'ptt_colour1' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_colour1', '#779FBF', '0');

Error:Duplicate entry 'ptt_colour2' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_colour2', '#779FBF', '0');

Error:Duplicate entry 'ptt_tag_sort' for key 'PRIMARY'
INSERT INTO phpbb_config (config_name,config_value,is_dynamic) VALUES ('ptt_tag_sort', 'random', '0');

What should I do? Is it safe to Force Install? It seems that the only failures were in creating rows that already exist?

phpBB: 3.08
Used Mod Version: 19th November 2010 – 1.0.2.b
PHP Version: 5.3.3

I receive the following „deprecated“ message if i add a new Tag to a topic.

"Deprecated: Function split() is deprecated in /users/xxxxxx/www/f/includes/functions_phpbb_topic_tagging.php on line 20

Warning: Cannot modify header information - headers already sent by (output started at /users/xxxxxx/www/f/includes/functions_phpbb_topic_tagging.php:20) in /users/xxxxxx/www/f/includes/functions.php on line 4562
..."

I'm not a php specialist but i changed
$tag_array = split(',', $tags);
to
$tag_array = explode(',', $tags);
and the message is gone

Thx
Gom

Hello. I found a security issue today with your phpBB3 Topic Tagging mod. If you tag a topic in a restricted forum (i.e. only visible to registered users), the tag will be seen by anonymous users. Clicking on the tag will reveal the topic which they should never have access to.

Steps to repro:
1: Create a new topic in a forum which is only visible to registered users.
2: Tag the topic with the word "Secret"
3: Log out
4: Notice that "secret" is now seen in the tag cloud, even for anonymous users.
5: As an anonymous user, click the "secret" tag in the tag cloud

Results:
Anonymous user can now see the topic that was tagged. They can see the forum name, the poster, etc.

Expected Results:
Anonymous user should not see tags for topics they cannot access. Anonymous users should not be allowed to bypass security and see topics they don't have access to just by viewing the tag cloud.

Right now the install.xml only supports mysql. phpbb3 can also be run on PostgreSQL (we are :) so it would be nice if that was supported as well. If you're actually using the COLLATE feature it may have to require 9.1 support:

http://www.postgresql.org/docs/9.1/static/collation.html

Make tag searches case insensitive

When debug is ON there is an error:
[phpBB Debug] PHP Notice: in file /includes/functions_display.php on line 905: Undefined index: poll_start

http://www.phpbb.com/community/viewtopic.php?p=13050566#p13050566

Confirmed by myself:
Page: phpbb_topic_tagging.php?mode=search&tag=bootanimation
File: /includes/functions_display.php
Line: 896

My board is heavily modded, so line numbers will not match, but the relevant part is:

if ($topic_row['poll_start'] && $topic_row['topic_status'] != ITEM_MOVED)
{
    $topic_type = $user->lang['VIEW_TOPIC_POLL'];
}

Tagging input and suggestion look odd in chrome.

It seems like styles aren't getting applied

-in includes/functions_phpbb_topic_tagging.php, all occurences of search&tag need to be replaced with search&tag

• same problem with phpbb_topic_tagging.php - line 172 at least ('&t=' should be replaced with '&t=')

http://www.phpbb.com/community/viewtopic.php?p=13056042#p13056042

Update the mod to include Jquery and re-write the JS