vendethiel / gladiusex

GladiusEX

An arena unit frames addon for Legion

Author

Original author: slaren Maintainer: vendethiel.

---

Repository: https://github.com/slaren/GladiusEx

gladiusex's Issues

Shadowy Duel breaks DR tracker. Possible fix?

Hello again! As title says; When someone gets into a Shadowy Duel it breaks the DR tracker on that target.

I saw this addon: https://www.curseforge.com/wow/addons/gladius-undoggo-plugin

Does this work for GladiusEx? And is there any way to just implement this code into GladiusEx if it works maybe?

remove LibSpecRoster

We're using (our forked) LibGroupInSpecT nowadays, plus LibSpecRoster hasn't been maintained since 2013.

Game Version is 1.0.0

Not sure if intentional or typo, but game version says 1.0.0 instead of 10.0.0.

Missing libraries [1.1.1]

It looks like there is a bit of a mismatch between the paths defined in your code and the paths you have packaged in your libs folder.

Couldn't open GladiusEx\libs\LibSpecRoster-1.0\lib.xml
Couldn't open GladiusEx\libs\LibCooldownTracker-1.0-10\libs\LibGroupInSpecT-1.1-90\lib.xml
Couldn't open GladiusEx\libs\LibCooldownTracker-1.0-10\libs\LibFunctional-1.0-2\lib.xml

Cross-posted from https://www.wowace.com/projects/gladiusex/issues/48 since it seems GitHub issues might be your preferred issue tracker.

Verified with just GladiusEx, Buggrabber & Bugsack.

[BC Classic] Lua errors on release 2.1

Using it in BC Classic, BugSack won't even show them all because there appears to be 421x (null) but copy pasting what it looks like to me

LibFunctional

@slaren Could you maybe put LibFunctional on your github? I don't see a reason for the project to be deprecated (I can maintain it), it's quite useful.

Better default auras

https://www.wowace.com/projects/gladiusex/issues/46

Division by 0 error when using GEX with an Evoker on beta.

GladiusEX currently doesn't work on the beta when there's an Evoker involved (Though it does work with no errors when there's no Evokers), here's the full error log that Bugsack gives me when typing in /gex test 3 on my Evoker. Ofc not an issue until two weeks from now, but a headsup nontheless :P

Interface/AddOns/GladiusEx/GladiusEx.lua:1350: Division by zero
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:1350: in function `UpdateUnit'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:504: in function `UpdatePartyFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:572: in function `UpdateFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:593: in function `CheckArenaSize'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:624: in function `ShowFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:456: in function `SetTesting'
[string "@Interface/AddOns/GladiusEx/options.lua"]:111: in function `?'
[string "@Interface/FrameXML/ChatFrame.lua"]:5219: in function `ChatEdit_ParseText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4883: in function `ChatEdit_SendText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4919: in function `ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:127_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:127_OnEnterPressed"]:1>

Locals:
self = <table> {
 AnchorFromGrowDirection = <function> defined @Interface/AddOns/GladiusEx/options.lua:927
 RefreshUnit = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:916
 EnableModules = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:356
 IsArenaUnit = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:893
 UpdateAllGUIDs = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:776
 modules = <table> {
 }
 party_background = GladiusExButtonBackgroundparty {
 }
 GetBarWidth = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1193
 SaveAnchorPosition = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1044
 IsTesting = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:462
 defaultModulePrototype = <table> {
 }
 GetUnitIndex = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1116
 SafeGetSpellName = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1613
 SetDefaultModulePrototype = <function> defined @Interface/AddOns/BigDebuffs/Libs/AceAddon-3.0/AceAddon-3.0.lua:405
 default_bar_texture = "Blizzard Raid Bar"
 IsEnabled = <function> defined @Interface/AddOns/BigDebuffs/Libs/AceAddon-3.0/AceAddon-3.0.lua:447
 RegisterMessage = <function> defined @Interface/AddOns/BigDebuffs/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:90
 UnregisterMessage = <function> defined @Interface/AddOns/BigDebuffs/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:153
 GetBarsHeight = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1198
 SoftHideUnit = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:955
 IsArenaShown = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:659
 db = <table> {
 }
 ARENA_OPPONENT_UPDATE = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:712
 CreateUnit = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:985
 SetEnabledState = <function> defined @Interface/AddOns/BigDebuffs/Libs/AceAddon-3.0/AceAddon-3.0.lua:420
 GetAttachPoints = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:212
 IsModuleEnabled = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:324
 OnEnable = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:362
 CopyGroupModuleSettings = <function> defined @Interface/AddOns/GladiusEx/options.lua:872
 OnInitialize = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:248
 UnregisterAllEvents = <function> defined @Interface/AddOns/BigDebuffs/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:174
 GetUnitIdByGUID = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:772
 dbi_party = <table> {
 }
 arena_anchor = GladiusExButtonAnchorarena {
 }
 UNIT_NAME_UPDATE = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:761
 AdjustFrameOffset = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1229
 OnProfileChanged = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:435
 GetName = <function> defined @Interface/AddOns/BigDebuffs/Libs/AceAddon-3.0/AceAddon-3.0.lua:275
 CheckOpponentSpecialization = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:704
 name = "GladiusEx"
 HideFrames = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:633
 Disable = <function> defined @Interface/AddOns/BigDebuffs/Libs/AceAddon-3.0/AceAddon-3.0.lua:310
 CheckFirstRun = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:408
 Print = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:143
 GetUnitAnchorType = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:1133
 Debug = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:139
 IsPartyUnit = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:897
 MakeGroupOptions = <function> defined @Interface/AddOns/GladiusEx/options.lua:225
 ClearUpdateQueue = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:751
 defaults_party = <table> {
 }
 CheckEnableDisableModule = <function> defined @Interface/AddOns/GladiusEx/GladiusEx.lua:328
 UnregisterEvent = <function> defined @Interface/AddOns

Webhook API

Hi @slaren ,

It seems like ownership change broke the webhook system, I guess your API key is not considered valid for the project anymore.
Would you mind changing the webook here, or adding me admin to the repos so I can change it?

Thanks!

Investigate performance

From curseforge:

I noticed that GladiusEx has 10-15% CPU consumption while outside of Arena. Is it possible to fix this by optimization? Feels like it should not consume so much when no frames are shown.

again gladius ex not showing in 5s rated but working in skirms

gladius ex not showing in 5s rated but working in skirms

Add an option for alerts not to alert about the caster

Class Icon Crop Border setting.

The Class Icon "Crop Border" setting doesnt crop borders as much as it just puts a black border around them and makes icon less visible.

It's more prevalent on party frames but that might just be because I have them a little bit bigger than arena frames.

Shown here:

Fix "show buffs I can dispell"

https://www.wowace.com/projects/gladiusex/issues/38

Are you sure that debuff aruas are working as intended with "show only dispellable" ?

I was noticing yesterday in 3s that it seemed to show a lot of debuffs which I couldn't dispel as a druid. Does it take into consideration your class, or does it show all poison, disease etc who different classes can dispel?

edit: was broken in d4ebb21, missing param

implement aura/... ignore like in Gladius

#10 (comment)

avoid polluting our DB with values we don't need

https://github.com/Resike/Gladius/blob/66997f53575f9bb6c168fbb98d96a6389d18e303/Gladius/Modules/Classicon.lua#L1025-L1029

Nameable cooldown groups+copy spells from other group

stonebark

i noticed that for resto druid, the options menu makes no mention of the talent Stonebark (197061) which reduces the duration of ironbark by 15s from 60s to 45s. this is kind of a big deal since it is considered a mandatory talent for pvp.

• Stonebark

Update for 10.0 to fix LUA errors

Currently get the below 5 LUA errors on login:

Message: GladiusEx: invalid spellid 213602
Time: Wed Oct 26 14:56:52 2022
Count: 1
Stack: GladiusEx: invalid spellid 213602
[string "@Interface/AddOns/GladiusEx/Data-Mainline.lua"]:40: in function `GetDefaultImportantAuras'
[string "@Interface/AddOns/GladiusEx/modules/classicon.lua"]:23: in main chunk

Locals: <none>

Message: GladiusEx: invalid spellid 319952
Time: Wed Oct 26 14:56:52 2022
Count: 1
Stack: GladiusEx: invalid spellid 319952
[string "@Interface/AddOns/GladiusEx/modules/classicon.lua"]:747: in function `SetupAuraOptions'
[string "@Interface/AddOns/GladiusEx/modules/classicon.lua"]:694: in function `GetOptions'
[string "@Interface/AddOns/GladiusEx/options.lua"]:165: in function `SetupModuleOptions'
[string "@Interface/AddOns/GladiusEx/options.lua"]:428: in function `MakeGroupOptions'
[string "@Interface/AddOns/GladiusEx/options.lua"]:725: in function `SetupOptions'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:375: in function <Interface/AddOns/GladiusEx/GladiusEx.lua:354>
[string "=[C]"]: ?
[string "@Interface/AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <...AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <...AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

Locals: <none>

Message: GladiusEx: invalid spellid 319952
Time: Wed Oct 26 14:56:52 2022
Count: 1
Stack: GladiusEx: invalid spellid 319952
[string "@Interface/AddOns/GladiusEx/modules/classicon.lua"]:747: in function `SetupAuraOptions'
[string "@Interface/AddOns/GladiusEx/modules/classicon.lua"]:694: in function `GetOptions'
[string "@Interface/AddOns/GladiusEx/options.lua"]:165: in function `SetupModuleOptions'
[string "@Interface/AddOns/GladiusEx/options.lua"]:428: in function `MakeGroupOptions'
[string "@Interface/AddOns/GladiusEx/options.lua"]:759: in function `SetupOptions'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:375: in function <Interface/AddOns/GladiusEx/GladiusEx.lua:354>
[string "=[C]"]: ?
[string "@Interface/AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <...AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <...AddOns/Bartender4/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

Locals: <none>

Message: Interface/FrameXML/ActionButton.lua:1261: attempt to call method 'SetNormalAtlas' (a nil value)
Time: Wed Oct 26 14:56:53 2022
Count: 3
Stack: Interface/FrameXML/ActionButton.lua:1261: attempt to call method 'SetNormalAtlas' (a nil value)
[string "@Interface/FrameXML/ActionButton.lua"]:1261: in function `UpdateButtonArt'
[string "@Interface/FrameXML/ActionButton.lua"]:1197: in function <Interface/FrameXML/ActionButton.lua:1196>
[string "=[C]"]: in function `CreateFrame'
[string "@Interface/AddOns/GladiusEx/modules/drtracker.lua"]:265: in function `CreateFrame'
[string "@Interface/AddOns/GladiusEx/modules/drtracker.lua"]:82: in function `GetModuleAttachFrame'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:230: in function `GetAttachFrame'
[string "@Interface/AddOns/GladiusEx/modules/clicks.lua"]:28: in function `GetSecureFrames'
[string "@Interface/AddOns/GladiusEx/modules/clicks.lua"]:39: in function `Update'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:1356: in function `fn'
[string "@Interface/AddOns/GladiusEx/libs/LibFunctional-1.0/functional.lua"]:209: in function `each'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:1355: in function `UpdateUnit'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:496: in function `UpdatePartyFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:564: in function `UpdateFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:585: in function `CheckArenaSize'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:616: in function `ShowFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:448: in function `SetTesting'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:414: in function `CheckFirstRun'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:665: in function `?'
[string "@Interface/AddOns/Bartender4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:119: in function <...er4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface/AddOns/Bartender4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:29: in function <...er4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@Interface/AddOns/Bartender4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface/AddOns/Bartender4/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/Bartender4/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: self = GladiusExDRTrackerFrameparty2 {
 FlyoutBorderShadow = GladiusExDRTrackerFrameparty2FlyoutBorderShadow {
 }
 HotKey = GladiusExDRTrackerFrameparty2HotKey {
 }
 FlyoutArrowContainer = Frame {
 }
 NewActionTexture = Texture {
 }
 RightDivider = Frame {
 }
 Border = GladiusExDRTrackerFrameparty2Border {
 }
 Flash = GladiusExDRTrackerFrameparty2Flash {
 }
 BottomDivider = Frame {
 }
 UpdateButtonArt = <function> defined @Interface/FrameXML/ActionButton.lua:1218
 IconMask = MaskTexture {
 }
 BaseActionButtonMixin_OnLoad = <function> defined @Interface/FrameXML/ActionButton.lua:1196
 icon = GladiusExDRTrackerFrameparty2Icon {
 }
 SlotArt = Texture {
 }
 AutoCastable = Texture {
 }
 SpellHighlightAnim = AnimationGroup {
 }
 SetShowGrid = <function> defined @Interface/FrameXML/ActionButton.lua:1205
 SpellHighlightTexture = Texture {
 }
 GetShowGrid = <function> defined @Interface/FrameXML/ActionButton.lua:1200
 AutoCastShine = GladiusExDRTrackerFrameparty2Shine {
 }
 Name = GladiusExDRTrackerFrameparty2Name {
 }
 LevelLinkLockIcon = Texture {
 }
 SlotBackground = Texture {
 }
 0 = <userdata>
 cooldown = GladiusExDRTrackerFrameparty2Cooldown {
 }
 Count = GladiusExDRTrackerFrameparty2Count {
 }
}
hideDivider = nil
SetDividerShown = <function> defined @Interface/FrameXML/ActionButton.lua:1223
(*temporary) = nil
(*temporary) = GladiusExDRTrackerFrameparty2 {
 FlyoutBorderShadow = GladiusExDRTrackerFrameparty2FlyoutBorderShadow {
 }
 HotKey = GladiusExDRTrackerFrameparty2HotKey {
 }
 FlyoutArrowContainer = Frame {
 }
 NewActionTexture = Texture {
 }
 RightDivider =

Message: Interface/FrameXML/ActionButton.lua:1261: attempt to call method 'SetNormalAtlas' (a nil value)
Time: Wed Oct 26 14:56:53 2022
Count: 3
Stack: Interface/FrameXML/ActionButton.lua:1261: attempt to call method 'SetNormalAtlas' (a nil value)
[string "@Interface/FrameXML/ActionButton.lua"]:1261: in function `UpdateButtonArt'
[string "@Interface/FrameXML/ActionButton.lua"]:1197: in function <Interface/FrameXML/ActionButton.lua:1196>
[string "=[C]"]: in function `CreateFrame'
[string "@Interface/AddOns/GladiusEx/modules/drtracker.lua"]:265: in function `CreateFrame'
[string "@Interface/AddOns/GladiusEx/modules/drtracker.lua"]:82: in function `GetModuleAttachFrame'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:230: in function `GetAttachFrame'
[string "@Interface/AddOns/GladiusEx/modules/clicks.lua"]:28: in function `GetSecureFrames'
[string "@Interface/AddOns/GladiusEx/modules/clicks.lua"]:39: in function `Update'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:1356: in function `fn'
[string "@Interface/AddOns/GladiusEx/libs/LibFunctional-1.0/functional.lua"]:209: in function `each'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:1355: in function `UpdateUnit'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:536: in function `UpdateArenaFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:565: in function `UpdateFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:585: in function `CheckArenaSize'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:616: in function `ShowFrames'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:448: in function `SetTesting'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:414: in function `CheckFirstRun'
[string "@Interface/AddOns/GladiusEx/GladiusEx.lua"]:665: in function `?'
[string "@Interface/AddOns/Bartender4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:119: in function <...er4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface/AddOns/Bartender4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:29: in function <...er4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@Interface/AddOns/Bartender4/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface/AddOns/Bartender4/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/Bartender4/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: self = GladiusExDRTrackerFramearena3 {
 FlyoutBorderShadow = GladiusExDRTrackerFramearena3FlyoutBorderShadow {
 }
 HotKey = GladiusExDRTrackerFramearena3HotKey {
 }
 FlyoutArrowContainer = Frame {
 }
 NewActionTexture = Texture {
 }
 RightDivider = Frame {
 }
 Border = GladiusExDRTrackerFramearena3Border {
 }
 Flash = GladiusExDRTrackerFramearena3Flash {
 }
 BottomDivider = Frame {
 }
 UpdateButtonArt = <function> defined @Interface/FrameXML/ActionButton.lua:1218
 IconMask = MaskTexture {
 }
 BaseActionButtonMixin_OnLoad = <function> defined @Interface/FrameXML/ActionButton.lua:1196
 icon = GladiusExDRTrackerFramearena3Icon {
 }
 SlotArt = Texture {
 }
 AutoCastable = Texture {
 }
 SpellHighlightAnim = AnimationGroup {
 }
 SetShowGrid = <function> defined @Interface/FrameXML/ActionButton.lua:1205
 SpellHighlightTexture = Texture {
 }
 GetShowGrid = <function> defined @Interface/FrameXML/ActionButton.lua:1200
 AutoCastShine = GladiusExDRTrackerFramearena3Shine {
 }
 Name = GladiusExDRTrackerFramearena3Name {
 }
 LevelLinkLockIcon = Texture {
 }
 SlotBackground = Texture {
 }
 0 = <userdata>
 cooldown = GladiusExDRTrackerFramearena3Cooldown {
 }
 Count = GladiusExDRTrackerFramearena3Count {
 }
}
hideDivider = nil
SetDividerShown = <function> defined @Interface/FrameXML/ActionButton.lua:1223
(*temporary) = nil
(*temporary) = GladiusExDRTrackerFramearena3 {
 FlyoutBorderShadow = GladiusExDRTrackerFramearena3FlyoutBorderShadow {
 }
 HotKey = GladiusExDRTrackerFramearena3HotKey {
 }
 FlyoutArrowContainer = Frame {
 }
 NewActionTexture = Texture {
 }
 RightDivider =

Default evoker cds

Warrior Defensive CD: Ignore Pain

hey,
if you find the time, could you add the warrior CD Ignore Pain?
https://www.wowhead.com/spell=190456/ignore-pain
afaik it changed from a prot only spell to one that every warrior can use.
thanks

Cooldown spiral for the important auras is smaller than an aura icon itself

As the title says, a cooldown spiral for the important auras(class icon) is smaller than an aura icon itsefl. It's happening only in important auras(class icon), both in the enemy and the party frames. DRs and cooldowns work fine.

https://imgur.com/6KdwN3z
https://imgur.com/fRPmQ00

version: 2.4.2

Any way to make party frames show always not on arena only?

Any way to make party frames show always not on arena only?

Blizz raid frames-style debuff filtering

    local hasCustom, alwaysShowMine, showForMySpec = SpellGetVisibilityInfo(data.spellId, "RAID_INCOMBAT")

    return not hasCustom or hasCustom and showForMySpec

A few missing auras to add to the aura list.

Chimaeral Sting (PvP Talent) adds 3 effects to the enemy target that each lasts 3 seconds:

1. Scorpid Venom (356723), 90% Slow, low prio
2. Spider Venom (356727), Silence, mid prio
3. Viper Venom (356730), 20% reduced damage and healing, very low prio

Consecutive Concussion (PvP Talent) can add a Stun (357021), high prio

Some new trinket auras as well:

1. Gladiator's Eternal Aegis (363522), Absorbs 50% of Magic damage taken. Low/mid prio?
2. Gladiator's Devouring Malediction (363532), Drain up to 11208 absorption from all nearby enemies over 3 sec, then unleash it in a 20 yd cone in front of you as healing absorption. Low/mid prio?

Thank you. Love the addon.

Fix default values deep merge

There's a very very bad bug I just noticed.

Ace3/AceDB does a deep merge on the default values.
So if I added "Riptide" to my auras module, Ace3 will merge GetDefaultAuras() with it.

And thus all the default auras + my auras will show.
Even though the values aren't actually in SavedVariables.
Deleting them is no use, after the next refresh, it will deep merge the default auras again.

This basically means there's no way to set default auras, because people who don't want them in (they want whitelist instead of blacklist, ...) are just stuck with them being re-added every single time.

---

A big thing is -- they're not getting persisted! So if you remove all the default from classicons, the list will be empty... Because they are only the default auras and are not saved...

Is there a way to make separate frame positions for 2s/3s/5s?

Is there a way to make separate frame positions for 2s/3s/5s?

Game is crashing after update

Hey man,

this is by far my favorite wow addon!
Sadly, my game has been crashing when entering the arena for a bit now. I don't know much about LUA but there is a function that recursively calls itself:

GladiusEx/modules/auras.lua

Line 183 in 30e70a4

return CanDispel(unit, buffs, dispelType, spellID)

And since my script is running too long I am assuming that the function never goes inthe any of the other if conditions.
Replacing that line with
return false
removes all my issues. I am not using the "show only dispellable auras" options so I do not know what the impact on that functionality is.

I'll attach the LUA Error:

Message: Interface\AddOns\GladiusEx\modules\auras.lua:177: script ran too long
Time: Wed Aug 25 19:22:12 2021
Count: 15
Stack: Interface\AddOns\GladiusEx\modules\auras.lua:177: script ran too long
[string "=(tail call)"]: ?
[string "@Interface\AddOns\GladiusEx\modules\auras.lua"]:177: in function <Interface\AddOns\GladiusEx\modules\auras.lua:176>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
...
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@Interface\AddOns\GladiusEx\modules\auras.lua"]:286: in function `scan'
[string "@Interface\AddOns\GladiusEx\modules\auras.lua"]:505: in function `?'
[string "@Interface\AddOns\Masque\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface\AddOns\Masque\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\Masque\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface\AddOns\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...s\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals: <none>

cant seem to set the profile by internal command

Sorry i have no clue where to ask this question

this is how i code a profile change in my setup program

ill show 1 that works and the same that is GladiusEx and the result
this is all wrapped up in a function and the 9 others of varying types wor, but i cant get GEx to work
first is Dominos it works
if IsAddOnLoaded("Dominos") then Dominos:CopyProfile("UItat"); end
now GladiusEx not working have tried SetProfile & CopyProfile to no change.
if IsAddOnLoaded("GladiusEx") then GladiusEx:SetProfile("UItat"); end

Implement aura groups

It's been asked for multiple times, so I'll put that here.

This feature would basically be the same as cooldown groups: you'd be able to have several separated cooldown groups.

Seems a bit like overkill, but if it's easy enough (ha ha ha) it might be useful still.
Would probably need the same kind of thing as the cooldown groups: naming, copying from/to arena(is that there already?), etc...

Custom spell tracking/Covenant abilities

Hey, first of all I love this addon so much and I'm very thankful that you're maintaining it!

So with the addition of covenant abilities it's almost crucial to be able to track abilities like Convoke the Spirits, I wonder if it would be possible to add them to the cooldowns module or even better might be a new feature that would allow us to add/import custom spells. Do you think it's possible or maybe you're already working on something similiar?

Once again thank you so much for maintaining the addon! <3

Looking to contribute to TBC

Hi ven,

I would love to collaborate with you on the TBC version of GladiusEx. If there is any extra work you need help with, I am here. If you are interested we can discuss further on Discord (Topkek#ooo1) -- The o's are 0s but GitHub is weird... I figure it is easier for us to use an IM mode of communication rather than issues/pull requests. This would also help me understand what work is still open.

Thanks!

Any way to make player character to be removed from party frames?

Any way to make player character to be removed from party frames?

Fix spell cast detection

Scenario:

I am casting a Greater Heal
I cast binding Greater Heal before the GCD is over
The client receives a UI_ERROR_MESSAGE (54)
then the client receives a UNIT_SPELLCAST_FAILED

both the alerts and the castbar modules think that the spell currently casted failed, and stop showing the current alert/cast.

TBC: bring back UNIT_HEAL_PREDICTION

luacheck

from Resike:

luacheck - --formatter=plain --std none --only [111,112,113] --no-unused --no-redefined --no-unused-args --no-unused-secondaries --no-self --no-max-line-length --no-max-code-line-length --no-max-string-line-length --no-max-comment-line-length --codes --ranges --filename @


111    Setting an undefined global variable.
112    Mutating an undefined global variable.
113    Accessing an undefined global variable.

https://luacheck.readthedocs.io/en/stable/warnings.html

Moving anchor should be allowed to go off-screen

BfA update

Update didn't take that long, not too much changed.

Checklist of things left to do:

• Lib: Update DrData (I have a fork). It should not conflict with another addon's DrData, since it's not updated anymore.
• Lib: Update LibCooldownTracker (on slaren's github).
• Lib: Fork LibGroupInSpecT. I probably want to make a "LibNewGroupInSpecT", in case some other addon use it. It uses deprecated addon message API, plus the request I made almost a year ago to get PvP talents detection never got an answer (I implemented it locally in the meantime).

Checklist of things to investigate, not blockers:

• I didn't change anything to use the new async spell API yet it looks like everything works. Need to make sure though.
• Investigate why sometimes (in dungeons) the charges counter goes berserk (It happened when I had the wrong number of max charges in SpellData).
• Update cooldowns. Dunno where to find such a page? mmo-champion?
• Do we still need LibDispellable?
• Do we still need LibRangeCheck?

Ace3 etc should automatically update by virtue of the package manager. AceGUI-3.0-SharedMediaWidgets wasn't updated the BfA, but it seems like it still works fine...

Not sure what to do about the new no-lib-strip-related errors: WoW used to ignore files it couldn't load, now it errors. Might create symlinks...

swipe color

ManneN1@07edb81#diff-1b0420718a88a15ca1c8de44f1a79e7fR683

Fix deprecated calls to GetClassInfoByID

https://www.wowace.com/projects/gladiusex/issues/54

option to display party frames outside of arena

As per title would be nice to have the option to show party frames all the time not just when entering an arena

Mistweaver Soothing Mist Always Finishes

https://www.wowace.com/projects/gladiusex/issues/51

Frost DK "Dead of Winter" stun not tracked in DR

The stun effect from Frost DK's PVP talent "Dead of Winter" is not tracked in DR.

Allow hiding arena frames

Will of the forsaken breaks trinket cd timer

When enemy undead pressing will of the forsaken - trinket cd timer becomes 30 seconds regardless of the current cd.

GIF: https://gifyu.com/image/SNAY1

Update for 9.2?

Hey is this still being maintained for 9.2? Theres a few new PvP trinkets that would be nice to have added to the list :)

Do talent detection

https://mods.curse.com/addons/wow/libgroupinspect

We might need to manually enter data points (spell id => position in the tree, I mean).

Not sure how to detect PVP talents.

Fix alerts

https://github.com/OperationXen/GladiusEx/commit/61ff79baddec5785d478d124361a1d1f8b646597#diff-55a340a884a8ff56bb2ffd2564a6639aR263

replace `wipe` calls

@slaren asking you here.

I'm trying to optimize a bit the addon, and I stumbled upon this in modules/cooldowns.lua

local spell_list = {}
local unit_sorted_spells = {}
local function GetCooldownList(unit, group)
	local db = Cooldowns:GetGroupDB(unit, group)

	local specID, class, race = GetUnitInfo(unit)

	-- generate list of valid cooldowns for this unit
	wipe(spell_list)

What's the point of wiping the spell list instead of just using a local table?
Does it save some allocations maybe, because the table's backing array (in C parlance) is not reset?

Legion update

Hey,

I just wanted to know if you took a look at legion, and if you might know what it takes to update the addon to the new expac.

I'm fine with updating myself if you don't want to look into it, although in this case I'd appreciate some pointers :).

Thanks!

Request: Recognize enemy covenants by used skills or buffs?

Title.