vendrhub / vendr-payment-provider-opayo Goto Github PK

We have wired up our Opayo provider with Vendr v2 (on Umbraco 9) and currently can't process any payments.

Upon taking the card details Opayo tries to redirect back to the Vendr site.

We receive the following error:

This is because the callback URL that Vendr returns throws a 500 error.

I have investigated and found the error is a null reference, in CallbackRequestModel.FromRequestAsync the request parameter is null... Further digging brought me to looking at PaymentProviderContext in the Vendr Core, which has 2 internal constructors: one that takes a request, and one that passes null through for the request instead. The base payment provider uses the constructor without request and therefore the payment provider goes💥 when it calls ProcessCallbackAsync.

Previously in Vendr V1 the request was passed in to ProcessCallback as a parameter.

I've been working through a site which uses this provider in conjunction with the Vendr Checkout plugin and came across an issue when sending payment info for the US. Opayo requires the region to be provided and in this provider we're finding this by alias reference - where the region is stored against the PaymentInfo object.

I think that it should fetch the region in the same way that it fetches the country, through the PaymentInfo object (rather than attempting to fetch it via an alias). Does this sound like a sensible way forward? I'm happy to create a PR for the work.

Specifically in this code and for reference, here is where it's being stored in the Checkout plugin.

Hey,

We're at the starting block with this plugin and we're trying to integrate alongside the Vendr Checkout and when we're trying to access the /checkout/review-order/ page we're getting a constantly loading page.

I've narrowed this down to OpayoServerPaymentProvider.cs and it looks like the await call is failing and causing a deadlock.

Turns out that the underlying issue is the fact my notification URL was invalid, but the package didn't tell me that or put anything out in the logs.

For reference:
Umbraco 8.18.2
Vendr.Core 2.0.0
Vendr.Checkout 2.1.0