verschuerentom / village_defense_2.0 Goto Github PK

Add a command like /vd admin leave This would, in bungee mode, allow the admin to leave the game but not be kicked back to the lobby. The admin after leaving would be able to break/place blocks.

Solution to this is to add a custom pathfindergoal to break doors.

Add translatable villager names from list from config or language file.

Kit item can be used everywhere when the lore and item name are correct.

Zombies follow spectators in 1.12. Solution is to make them Gamemode.SPECTATOR but be aware that 1.8 does not have SPECTATOR gamemode.

Edit checkPlayerCommands method (check for /villagedefense || /vd string first)

Add change price command or make setprice command changes price of item when item already has lore with price.

CodeFactor found an issue: Duplicate Code

It's currently on:
src\me\tomthedeveloper\events\Events.java:590-630
src\me\tomthedeveloper\Main.java:1115-1155
Commit 2f8d3a3

i'm only testing

Things to do for next pull request:

• Decapitalise package names
• Create files: signModification.yml, STATS.yml, SpecialItems.yml and Kits.yml from plugin jar (instead of that weird create file method from gameapi)
• Create UpdateChecker class
• Make plugin prefix (from ChatManager) configurable in language.yml (to do in LanguageMigrator class)
• Add plugin prefixes for rest of messages that need them
• *Make MessageHandler_v1x_xx_Rx classes reflection based (and merge them into 1 class)
• Remove onKick listener from onQuit class (@TomtheCreator quit event is called after kick https://www.spigotmc.org/threads/is-playerquitevent-called-after-playerkickevent.267729/)
• Rename onSpectate listeners in onSpectate class
• Change lines 217-221 in Events class (useless)
• Make translatable Spawn Wolf item (Events class)
• Remove getLabel() checking from ChestCommands class (use getName() instead)
• Remove is1x_xx_Rx from VillageDefense class (GameAPI class have this methods) + change methods from GameAPI class to return getVersion()... instead of if (getVersion()...) return true; return false;

When I start the server, the plugin fails to enable throwing the following error:

[21:32:40] [Server thread/INFO]: [VillageDefense] Enabling VillageDefense v2.1.3
[21:32:40] [Server thread/ERROR]: Error occurred while enabling VillageDefense v2.1.3 (Is it up to date?)
java.lang.ExceptionInInitializerError
	at me.tomthedeveloper.kitapi.KitMenuHandler.<init>(KitMenuHandler.java:44) ~[?:?]
	at me.tomthedeveloper.GameAPI.onSetup(GameAPI.java:146) ~[?:?]
	at me.tomthedeveloper.Main.onEnable(Main.java:190) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:321) ~[spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at org.bukkit.craftbukkit.v1_8_R3.CraftServer.loadPlugin(CraftServer.java:357) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at org.bukkit.craftbukkit.v1_8_R3.CraftServer.enablePlugins(CraftServer.java:317) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at net.minecraft.server.v1_8_R3.MinecraftServer.s(MinecraftServer.java:414) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at net.minecraft.server.v1_8_R3.MinecraftServer.k(MinecraftServer.java:378) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at net.minecraft.server.v1_8_R3.MinecraftServer.a(MinecraftServer.java:333) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at net.minecraft.server.v1_8_R3.DedicatedServer.init(DedicatedServer.java:263) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:525) [spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_151]
Caused by: java.lang.NullPointerException
	at org.bukkit.ChatColor.translateAlternateColorCodes(ChatColor.java:324) ~[spigot-1.8.8.jar:git-Spigot-e4d4710-e1ebe52]
	at me.tomthedeveloper.handlers.ChatManager.colorMessage(ChatManager.java:69) ~[?:?]
	at me.tomthedeveloper.handlers.ChatManager.<clinit>(ChatManager.java:26) ~[?:?]
	... 14 more

I've edited all my language files and changed all § to & when I saw the last lines (translateAlternateColorCodes). If you need my config files, I can attach them here.

Spigot Version: 1.8.8

Plugin Version: 2.1.3

Since (if I'm not wrong) the pathfinding update, the zombies and villagers in the arena are extremely slow.
Also, I can't understand why the update says

Zombies pathfinding was very bad since 1.8 or 1.9 to find villagers inside houses.

In my server ALL the zombies were going to one of the only two doors in the map to try to kill the villagers...

I say "Not sure if this issue continue happening" in the title because I haven't been able to use the plugin since the "LanguageMitigation failed" update because the error reported in issue #27 (update between last and "LanguageMitigation failed" not tested).

No error log available

Spigot version: 1.8.8

Plugin version: Two different versions tested