GithubHelp home page GithubHelp logo

Comments (4)

vascowhite avatar vascowhite commented on May 28, 2024

I just realised that you intend Pillow to be used. I installed into a virtualenv using Pipenv and got an error that PIL wasn't installed, so I raised this issue.
Do you think it would be better to put a requirement for pillow in setup.py? You already have piexif there, so I don't understand why Pillow isn't.

from optimize-images.

victordomingos avatar victordomingos commented on May 28, 2024

I guess the current setup.py may be improved. I have two separate requirements files, one for desktop and another for iOS/Pythonista. In Pythonista, you already have Pillow, and the bundled version cannot be upgraded, so it’s not included as a requirement for iOS.

I will see if I can improve setup.py to make it a bit more clear and implement a more straightforward installation process.

from optimize-images.

vascowhite avatar vascowhite commented on May 28, 2024

I guess I wasn't thinking of the iOS part, it makes sense why you've done it that way now.
I think I was confused by the error message refering to PIL rather than Pillow. If I had installed globally rather than into a virtualenv I wouldn't have seen any error as I have Pillow installed.

from optimize-images.

victordomingos avatar victordomingos commented on May 28, 2024

I have just added some details to the setup.py file. If all works as it should, doing a pip install should select and install the correct Pillow version if it’s not running on iOS.

from optimize-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.