Crashes when meets it's own temp file about optimize-images

[victordomingos]

Hmm. I believe I have also seen that kind of error, but at the time I couldn’t determine what was causing it, probably because it was a rare occurrence in my case. I need to take another look at it, but you’re probably right concerning the possibility of this being a race condition.

Currently the temporary files are being created in the same folder that has the original file, with a prefix in the name. Maybe it needs to be set to ignore any image files whose name starts with that prefix. Or maybe the temporary file can be replaced with something in memory without disk I/O, which should be much faster and would probably solve this issue.

[varnav]

Looks like it's more likely to occur on fast hardware - I have 12 core CPU and NVMe SSD. I noticed that if system is under load - this is less likely to occur. Of course it would be the best not to create temp file at all. Maybe this will help: https://docs.python.org/3/library/tempfile.html#tempfile.SpooledTemporaryFile

[victordomingos]

Thank you very much for your feedback. I submitted a quick fix, just checking the presence of the temporary files prefix (~temp~) in the filename. It should be enough to avoid the reported issue. I will keep in mind your SpooledTemporaryFile suggestion, though.

Please let me know in case you still get any issue with this version.

[victordomingos]

Just a quick notice to let you know that, on the latest commit (not yet available in PyPI), I have implemented in-memory buffers using BytesIO, instead of in-disk temporary files. Still under testing, as the refactoring could have introduced some regression bugs.

I am still curious about any potential advantages of SpooledTemporaryFile over BytesIO, though.