viniciussanchez / bcrypt

BCrypt is a password hashing function

Hi there 👋

bcrypt's Issues

Range Check Error in GenerateHash(); Integer Overflow Exception

TBCrypt.GenerateHash() function raise 'Range Check Error'.

In source TBCryptImpl.MakeSalt: TBytes
while I <= Length(LRandomTemp) do
begin
...
end
It should be change like this
I < Length(LRamdomTemp)

And, also i added {$Q-} top of BCrypt.Core.pas
because,
TBCryptImpl.Encipher(var lr: array of DWORD; const AOffset: Longint);
function raise exception Integer Overflow exception
N := DWORD(N + FSBox[$100 or ((LBlock shr 16) and $FF)]);
stop this line.

Thank you

Bcrypt "error": "Range check error"

depurando o projeto cheguei na procedure TBCryptImpl.MakeSalt. No bloco :-

while I <= Length(LRandomTemp) do
begin
LByteArray[i] := Ord(LRandomTemp[i + 1]); <--- esta gerando erro aqui, pois o length do LRandom está menor
Inc(i);
end;

Para resolver eu alterei a linha while para ---> "while I < Length(LRandomTemp) do"