vippsas / vipps-login-wordpress Goto Github PK

Having more ways to authenticate users other than the e-mail address would be a great addition to this plugin. In some cases the WordPress users might be registered with a business email and not the private email address from Vipps but still have the same phone number in both systems.

If you would consider adding a filter on line 1000 in VippsLogin.class.php, for example something like this:

$user = apply_filters( 'login_with_vipps_authenticate_user', get_user_by( 'email', $email ), $userinfo );

… then we could lookup users by $userinfo['phone_number'] or any other meta value.

ref:

Current error message describes much less probable situations:

"Your session is invalid. Only one Vipps-session can be active per browser at a time. Also, ensure that you are not blocking cookies – you will need those to log in."

https://wordpress.org/support/topic/vipps-login-checkout-page-better-login-button/

Preferring a less wordy default text seems reasonable and shouldn't be too much code.

I've implemented a customisation to find a user account by their vipps phone number, but it was reported to me that one user's account got linked to the wrong vipps account, it showed someone elses phone number in their profile

this is the code https://gist.github.com/pdewouters/c500d010b2753a8b37a7a62a0b95ea9d

Do you see anything in there that could cause this?

Unless it's due to multisite / redis cache mixing up the DB options? this happens with another plugin that was network active

Add filters, settings and a CSS style that can be used to turn off the large "Log in with Vipps" banner for users preferring button (or anything).

Hei Iver, her er forslag til tekst for oppfølging (samme banner og logo): Til deg som har lastet ned Vipps logg inn plugin: Det er raskt og enkelt å komme i gang! Hent API nøkler i Vipps portalen og legg de inn i plugin for å aktivere Vipps Logg Inn. Se her!”

Vis, dismissable, for kunder som har lastet ned men ikke aktivert.

It is off by default, no longer needed since Vipps already checks email addresses; does not apply on "customer" type accounts and uses an apparently unstable WP API that has recently changed to be less extensible.

Main benefit will be a lot less code and one fewer "modes" to test.

README.md: https://github.com/vippsas should be changed to https://vippsas.github.io/vipps-developer-docs/

Low-hanging fruit

before feb 28 2021

Hi, a customer of mine has a repeating problem with some of the orders done in their WooCommerce webshop. Some of the orders start out with Vipps as payment method and then it gets an error in the Order notes, stating that Klarna order could not be captured.

I don't know why it suddenly becomes a Klarna order, but is this a regular problem with Vipps or is it a problem with WooCommerce or Klarna?

It goes something like this:

1. Vipps payment initiated
2. Awaiting Vipps payment confirmation
3. Vipps callback received
4. Payment authorized at Vipps
5. Stock levels reduced for the product
6. Order status changed from Pending payment to On Hold
7. Order status changed from On Hold to Processing (manually done by staff)
8. Klarna order could not be captured due to an error.
9. Order status changed from Completed to On Hold.

Is it a routine problem done by the staff or is it a bug with the plugin?

I hope to be able to solve this, sincerely Mathias.

This is in dev, and it might be a plugin that causes it, but it needs checking out

Two issues seem to be in play: 1. on one install, we get an invalid_request from Vipps when going to the vipps landing page, 2. on a separate install, everything works except returning from Vipps.

because that would be nice

Hi, it would be great if the setings could be set on the network level, because I'm using the plugin on a 300+ site network, meaning I have to either set them manually or write some code to clone the settings from the main site

Looks like I would need to add all the site URLs in the vipps portal as well,... so doesn't seem a good option

https://github.com/vippsas/vipps-login-api/blob/master/vipps-login-api.md#automatic-return-from-vipps-app

Evt. make this switchable for the FAMILYNAME Givenname popular for some Japanese/Hungarian people.

Requested here: https://wordpress.org/support/topic/login-with-vipps-creates-duplicate-users-when-user-changes-e-mail-address/

Especially relevant if Vipps is used as the primary login mechanism. Should be optional since some people (me) like having different accounts.

Easiest way would be to use a (filterable) function instead of get_user_by $email; with the default function using Vipps ID and Vipps Phone (with some canonicalization), and then the email. If the user found like this and the email doesn't match, the email should be changed.

However, if a different user exists with that email, that's going to be an issue; and any security issues with this (re-use of phone numbers?) need to be addressed.

Mostly as an example; but would enable sites to enable anonymous but authenticated comments, which would be neat.

Hi

when executing login_with_vipps("woocommerce") manually, it seems it always redirect to the checkout... I've scoured everywhere and I cant seem to find why this happens.

To be clear, I'm executing that function after a ajax request to add something to the cart.... it redirects to vipps, and then on the successful redirect back, it then redirects directly to the cart...

I've looked through the source here and I seem to be missing where this setting is...

I'm not using any plugins to set auto redirect to cart or anything, its pretty vanilla. Any thoughts on where this might be getting that redirection link from?