viren070 / emulator-manager

Manage all your emulators from one place. Download and keep the emulator updated. Download ROMS, any required files and manage your user data.

Hi there 👋

emulator-manager's Issues

Virus Total scan detects malicious

https://www.virustotal.com/gui/file/dc0399ec36881e4743567495df20b2ca829beb43901038dba6294a7fe9a68db8

Fails to add titleDB to cache if running app from another drive.

Steps to reproduce

1. Launch Emulator Manager from another drive (not in portable mode)
2. Trigger a titleDB download
3. Error saying failed to add file to cache

Expected behavior

The titles.US.en.json file that is downloaded to the other drive is not added to cache and instead an OSError is raised.

Actual behavior

The titiles.US.en.json file should be moved to the cache directory.

Errors

Emukator Manager version

0.13.2

Operating System

Windows 11

Other details

No response

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
• I have written a short but informative title.
• I have updated the app to version 0.13.2.

ROM Download fails if no ROM directory is set in the settings

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1. Wipe user data.
2. Do not set the ROM directory in settings
3. Attempt to download a ROM for Dolphin or Xenia
4. Download button is stuck on Downloading... and is disabled (can switch pages to enable button again)
5. FileNotFoundError raised by os.makedirs

Expected behavior
ROM downloads in current directory or warn user that no directory has been set.

Error

Exception in thread Thread-29 (download_rom_handler):
Traceback (most recent call last):
  File "threading.py", line 1073, in _bootstrap_inner
  File "threading.py", line 1010, in run
  File "gui\frames\xenia\xenia_rom_frame.py", line 58, in download_rom_handler
  File "gui\frames\xenia\xenia_rom_frame.py", line 80, in download_rom
  File "<frozen os>", line 225, in makedirs
FileNotFoundError: [WinError 3] The system cannot find the path specified: ''
Exception in thread Thread-31 (download_rom_handler):
Traceback (most recent call last):
  File "threading.py", line 1073, in _bootstrap_inner
  File "threading.py", line 1010, in run
  File "gui\frames\dolphin\dolphin_rom_frame.py", line 60, in download_rom_handler
  File "gui\frames\dolphin\dolphin_rom_frame.py", line 82, in download_rom
  File "<frozen os>", line 225, in makedirs
FileNotFoundError: [WinError 3] The system cannot find the path specified: ''

Errors while downloading titleDB or adding it to cache are incorrectly handled

Describe the bug
Can't download the title db for yuzu and ryujinx and gave an error

To Reproduce
Steps to reproduce the behavior:

1. launch the app
2. try to click on "manage rom" under the yuzu or ryujinx tab
3. start the download
4. and nothing happen

Expected behavior
download and install the title db file

Screenshots

error:

Exception in Tkinter callback
Traceback (most recent call last):
  File "tkinter\__init__.py", line 1962, in __call__
  File "customtkinter\windows\widgets\core_widget_classes\ctk_base_class.py", line 188, in _update_dimensions_event
    self._draw(no_color_updates=True)  # faster drawing without color changes
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "customtkinter\windows\widgets\ctk_button.py", line 194, in _draw
    self._canvas.delete("background_parts")
  File "tkinter\__init__.py", line 2894, in delete
_tkinter.TclError: invalid command name ".!yuzuframe.!ctkframe4.!yuzuromframe.!ctkframe.!switchromsframe.!progresswindow.!progressframe.!ctkbutton.!ctkcanvas"
Exception in thread Thread-129 (download_titles_db):
Traceback (most recent call last):
  File "threading.py", line 1073, in _bootstrap_inner
  File "threading.py", line 1010, in run
  File "gui\frames\switch_roms_frame.py", line 404, in download_titles_db
TypeError: 'NoneType' object is not subscriptable

Windows defender detect it as viruses and deleted it

Is this false alarm?