visionmedia / minstache Goto Github PK

I think we do not need strong array check at function:

function section(obj, prop, negate, thunk) {
  var val = obj[prop];
  if (Array.isArray(val)) return val.map(thunk).join('');
  if ('function' == typeof val) return val.call(obj, thunk(obj));
  if (negate) val = !val;
  if (val) return thunk(obj);
  return '';
}

I explain why. I have array-like object (extended from Array). And minstache do not understand that array-like object have Array as prototype.

I propose to change Array.isArray(val) to val instanceof Array.

And when we using Array.isArray(val) we forgot about IE8.

Thanks.

it'd be sweet for this library to support iteration through arrays.

{ contacts :
  [
    { name : 'matt' },
    { name : 'john' }
  ]
}

<ul>
  {#contacts}<li>{name}</li>{/contacts}
</ul>

I took a look at the way the lib is structured - it doesn't look trivial to implement. I feel like it's the last feature missing from a lightweight "core" mustache though.

this is more a question than an issue. Do you think it would be possible to create a "render" function that would

1. return a dom element

2. accept dom nodes as paramaters

E.g it would be awesome to be able to do :

Minstache.compile("<div>{{object}}</div>")({ object: myComponent.render() })

There is a divergence from the mustache spec for inverted sections with respect to empty arrays. minstache seems to be handling them as an iterator, not as an inverted section

https://github.com/janl/mustache.js/blob/0.8.2/README.md#inverted-sections

> require('mustache').render('{{^places}}none{{/places}}', {places: []})
'none'
> require('minstache')('{{^places}}none{{/places}}', {places: []})
''

would be nice to have support for unescaped output, maybe {{{comment}}} or {{!comment}}

Update: {{!...}} seems like a really easy fix. I can submit a pull request if you think it's a useful feature.