Comments (3)
Thanks for reporting this, @GrahamCampbell!
The planner was doing the safe thing here, we've just never invested time in making this better.
I'm changing this to a feature request - we don't want to backport these kind of planner enhancements.
from vitess.
Fair enough. Looking at the PR, I think it may have a bug - it's incorrect to push down the limit in the query for foo
for the following query:
SELECT `bar`.`id`
FROM `foo`
LEFT JOIN `bar`
ON `bar`.`b` = 2
AND `foo`.`c` = `bar`.`c`
WHERE `foo`.`a` = 1
AND `bar`.`id` in (1, 2, 3)
LIMIT 1;
I see there's a check against a null check condition, but I don't think that's enough. The bar.id
cannot be pushed into the join condition and it does have the effect of filtering null bar.id rows.
from vitess.
Fair enough. Looking at the PR, I think it may have a bug - it's incorrect to push down the limit in the query for
foo
for the following query:
I suggest we chat on the PR. You can point out the plan you think is not correct. Hard to understand without seeing the plan you are thinking of.
from vitess.
Related Issues (20)
- Feature Request: `LookupVindex` has no `internalize` command (equivalent to `ReverseTraffic`)
- Bug Report: VTOrc is not setting the correct timeout for RPC calls which can get stuck
- Feature Request: Move most VARBINARY columns to VARCHAR in examples
- Bug Report: `schemadiff` shows bogus diff on textual column where collation is undefined
- Release of `v20.0.0`
- Release of `v20.0.0-RC1` HOT 2
- `go:linkname` (de)stabilization HOT 1
- Feature Request: support private go packages
- Cleanup: Deleting the deprecated metrics in VTOrc
- Bug Report: OnlineDDL PK conversion results in table scans HOT 18
- Bug Report: `schemadiff` should not allow `INSTANT` DDL when setting expression-based default column value HOT 1
- `ApplySchema` command should reroute `ALTER VITESS_MIGRATION ... THROTTLE ...` via `UpdateThrottlerConfig`
- Remove highcharts dependency
- Bug Report: Shard ranges for 103 & 107 shards end in -ff HOT 3
- RFC: vtgateproxy HOT 2
- Bug Report: Strict semantic analysis does not handle unsharded queries correctly
- OnlineDDL: an `--in-order-completion` migration should fail if prior migrations have failed (limit to same context)
- Bug Report: schemadiff semantic analysis for views doesn't handle table names that are SQL keywords
- Bug Report: `txthrottler` watches health streams for every keyspace/shard
- Question: Is the Vitess Google Group still Active? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vitess.