Bug Report: vtctldclient fails to apply routing rules about vitess

[dbussink]

I think that we should be using protojson.Unmarshal which supports both the json names and the proto names.

This seems wrong. json2 calls protojson if the given target is a proto.Message and it adds more human readable / better error messages. We should be using json2 really and I'm very confused why it doesn't work then. I think we should understand that first before it's changed to protojson (and we might have bugs like this in more places if there's some way json2 doesn't work as expected).

vitess/go/json2/unmarshal.go

Lines 35 to 38 in 6fb0f0e

	if pb, ok := v.(proto.Message); ok {
	opts := protojson.UnmarshalOptions{DiscardUnknown: true}
	return annotate(data, opts.Unmarshal(data, pb))
	}

[mattlord]

The problem is here: https://github.com/vitessio/vitess/blob/main/go/cmd/vtctldclient/command/routing_rules.go#L84-L87

I think that we should be using protojson.Unmarshal which supports both the json names and the proto names.

Test case that fails on main:

git checkout main && make build
pushd examples/local

./101_initial_cluster.sh

vtctldclient ApplyRoutingRules --rules '{                                                                                                                        
    "rules": [
        {
            "fromTable": "sbtest1",
            "toTables": [
                "sbtest.sbtest1"
            ]
        }
    ]
}'

That same test case works as expected after this patch/fix:

diff --git a/go/cmd/vtctldclient/command/routing_rules.go b/go/cmd/vtctldclient/command/routing_rules.go
index 0ffee0c2c2..119c8dbb41 100644
--- a/go/cmd/vtctldclient/command/routing_rules.go
+++ b/go/cmd/vtctldclient/command/routing_rules.go
@@ -23,9 +23,9 @@ import (
        "strings"

        "github.com/spf13/cobra"
+       "google.golang.org/protobuf/encoding/protojson"

        "vitess.io/vitess/go/cmd/vtctldclient/cli"
-       "vitess.io/vitess/go/json2"

        vschemapb "vitess.io/vitess/go/vt/proto/vschema"
        vtctldatapb "vitess.io/vitess/go/vt/proto/vtctldata"
@@ -82,7 +82,7 @@ func commandApplyRoutingRules(cmd *cobra.Command, args []string) error {
        }

        rr := &vschemapb.RoutingRules{}
-       if err := json2.Unmarshal(rulesBytes, &rr); err != nil {
+       if err := protojson.Unmarshal(rulesBytes, rr); err != nil {
                return err
        }

I'm not sure if that's the right/best ultimate fix, but it points to the problem space.

[rohit-nayak-ps]

fixed via #16096