vkhorikov / anemicdomainmodel Goto Github PK

First of all, thanks for putting this repo online. It's a great source of inspiration to me.

However, I have one specific question: is there a reason why you commit the transaction on disposal? The controller might have already returned an OK response to the client while the transaction might fail during disposal afterwards.

Shouldn't you simply commit the transaction within UnitOfWork.Commit()?

How would you share the validation logic between the Create and Update methods on the CustomerController if you needed to check for name, email and email validation uniqueness on both methods? Would a private method be sufficient? What if that logic needed to be shared somewhere else?

I would like to be able to create a unit test where the ValueObject is not dependent on internal objects that can change.
A specific issue is how you can test something that is using the ExpirationDate class. How would you mock the public bool IsExpired => this != Infinite && Date < DateTime.UtcNow;
that is using DateTime - that will change each time the test runs.

Hi,

I'm watching your course on pluralsight and it gave me a lot of good ideas on how to implement what you've done in your sample project that i can apply in my future projects. Good stuff...

I just have some questions on Dollars operators particularly the operator *.

Hello Vladimir. Thank you for course "Refactoring from anemic to rich model"!
I have a question about validation.
We removed all validation attributes (for example Required) from DTO. Also we removed checking of model state from controller (if (!ModelState.IsValid) return BadRequest();)
And we moved validation to ValueObjects. Ok.
But how we will validate properties from DTO which not mapped to ValueObjects? Lets imagine that Customer entity has one more string property Name1 with length < 50 (and this property is not value object). Where we will check this constraint? We will add at attribute StringLenght(50) to property in DTO and return checking of Model state in controller? Or we will use another solution, for example validation of Name1.Length in constructor of Customer entity?

I wanted to see if there has been any thought with getting the Entity class outside of the Logic project? I ask as I have written many anemic applications in my life and one of the principles of the Onion architecture that I liked/followed was to try to keep infrastructure knowledge out of the Logic/Core project.

1. Do you consider this to be an important principle?
2. If important, how would you refactor?

Thanks for any consideration.

Hey Vladimir,

Big fan and thanks for the course!

Per the title, I'm a little confused when you were returning Results versus throwing exceptions. From your previous content, I believe your stance boils down to return Results for expected errors, and throw exceptions representing programmer errors or ones that can't be handled.

Customer.promote throws when already promoted, even though this is an error we expect and can handle. Unless the programmer error is he didn't check canPromote beforehand. Similarly, the value objects used factory methods return Results with input validation, but the Customer constructor throws with invalid arguments. The implication is the programmer has to validate the name and email before calling the Customer constructor.

This feels a little inconsistent and breaks encapsulation. I wonder if you still completely agree with the code here, and if so, how you would formalize this heuristic? Should value objects comprising an entity provide input validation via Results, while entities should throw errors to protect their invariants?

Thanks again.

Hi @vkhorikov,

when I look into the README.md file of this repository with a normal text editor, I see that there is an unused reference-link to [L2]: DBCreationScript.txt at the bottom of the file. I would expect that file to be in the top level directory of the repository, but it isn't anywhere in the repository. Would you consider adding it to the repository to help trainees get the database up and running?

Btw, I am very much enjoying your pluralsight course(s), awesome work 👍