vmandal / rif-issuer-server Goto Github PK

Hello, A bit more hackathon feedback.

I setup your frontend and the backend. With the backend, I got a token from Twilio. I used the front-end manager to verify my SMS message, I got the text message code, which matched the code in the console log. However, when I submitted that code, the manager says that it is invalid:

Here is the complete console log from the POST request:

Message Sent SM5a025e9eed3d4029bd0cc5be42c17550
smsCode() response :(Message Sent SM5a025e9eed3d4029bd0cc5be42c17550)
2021-06-09 18:18:37 info: POST /issuer/smsCode/ 200 1566.551 ms - 22
2021-06-09 18:18:50 info: OPTIONS /issuer/AddMobile/ 204 0.195 ms - 0
2021-06-09 18:18:50 info: 1ms Executed (default): SELECT `id`, `did`, `code`, `asset`, `createdAt`, `updatedAt` FROM `didCodes` AS `DidCodeModel` WHERE `DidCodeModel`.`code` = 'e3718f84' AND `DidCodeModel`.`did` = 'did:ethr:rsk:testnet:0x3dd03d7d6c3137f1eb7582ba5957b8a2e26f304a' LIMIT 1;
2021-06-09 18:18:50 info: 1ms Executed (default): DELETE FROM `didCodes` WHERE `did` = 'did:ethr:rsk:testnet:0x3dd03d7d6c3137f1eb7582ba5957b8a2e26f304a' AND `code` = 'e3718f84'
2021-06-09 18:18:50 info: POST /issuer/AddMobile/ 400 18.869 ms - 27

Hi @vmandal!

Thanks a lot for your submissions!
This is a first important feedback about both of your submissions for bounties #12 and #13.

We are working on a full review for them, but, while we do it, we need to point out an important issue asap. So you have some time to fix it.

As mentioned in the bounties #12 and #13, the objective was to use our existing Email vc issuer. It was required to do the integration of the Email Issuer into the Id Manager.
We also recommend it to be used as the base for the SMS VC Issuer, but this is not mandatory.

So, this initial feedback would be:

1. Mandatory: Use Email vc issuer server and codebase for the Integration into Id Mgr
2. About SMS vc issuer:
   2.1. Mandatory: if not using the Email vc issuer as codebase, keep it in a separate repo named /sms-vc-issuer or implement a new API in the same repo for verifying phone numbers.
   2.2. Recommendation (not mandatory): create the sms-vc-issuer by using the /email-vc-issuer codebase

Summary:

• email vc issuer frontend: into id mgr
• email vc issuer backend: keep it in https://github.com/rsksmart/email-vc-issuer/
• sms vc issuer frontend: into id mgr
• sms vc issuer backend: create new https://github.com/###/sms-vc-issuer/
  • you could use the one you created and rename it as sms-vc-issuer
  • or you could create a new one using the email-vc-issuer codebase and adding what’s necessary to do the sms verifications and issues


If you have any questions about this, feel free to reply here, or via the public RSK Slack.

Thanks!