Notify only upon newly claimed game about free-games-claimer

[EthanC]

I am seeing this occur with Epic Games using Discord notifications. The script runs once, hourly, and I am receiving notifications despite the games already being claimed and the logs correctly recognizing that. Note the successful claim and notification on the first run and continued notifications with the following runs.

Docker Compose

version: "3"
services:
  free-games-claimer:
    container_name: free-games-claimer
    image: voglerr/free-games-claimer:latest
    environment:
      WIDTH: 1280
      HEIGHT: 720
      NOTIFY: discord://XXXXX/XXXXX
      EMAIL: XXXXX
      EG_PASSWORD: XXXXX
      EG_OTPKEY: XXXXX
      PG_PASSWORD: XXXXX
      PG_OTPKEY: XXXXX
      GOG_PASSWORD: XXXXX
    ports:
      - 5900:5900
      - 6080:6080
    volumes:
      - /home/XXXXX/free-games-claimer:/fgc/data

Logs

Xvfb display server created screen with resolution 1280x720
VNC is running on port 5900 (no password!)
noVNC (VNC via browser) is running on http://localhost:6080
2023-01-27 20:44:01.320 started checking epic-games
Not signed in anymore. Please login in the browser or here in the terminal.
Open http://localhost:6080 to login inside the docker container.
Press ESC to skip if you want to login in the browser.
Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...
Signed in as XXXXX
Free games: [
  'https://store.epicgames.com/en-US/p/adios-b378b4',
  'https://store.epicgames.com/en-US/p/hell-is-others-789262'
]
Current free game: Adios
  Not in library yet! Click GET.
  Claimed successfully!
Current free game: Hell is Others
  Not in library yet! Click GET.
  Claimed successfully!
2023-01-27 20:45:09.117 started checking prime-gaming
Signed in as XXXXX
Number of already claimed games (total): 15
Number of free unclaimed games (Prime Gaming): 0
Number of free unclaimed games (external stores): 0
Xvfb display server created screen with resolution 1280x720
VNC is running on port 5900 (no password!)
noVNC (VNC via browser) is running on http://localhost:6080
2023-01-27 21:00:02.465 started checking epic-games
Signed in as XXXXX
Free games: [
  'https://store.epicgames.com/en-US/p/adios-b378b4',
  'https://store.epicgames.com/en-US/p/hell-is-others-789262'
]
Current free game: Adios
  Already in library! Nothing to claim.
Current free game: Hell is Others
  Already in library! Nothing to claim.
2023-01-27 21:00:12.939 started checking prime-gaming
Signed in as XXXXX
Number of already claimed games (total): 15
Number of free unclaimed games (Prime Gaming): 0
Number of free unclaimed games (external stores): 0
Xvfb display server created screen with resolution 1280x720
VNC is running on port 5900 (no password!)
noVNC (VNC via browser) is running on http://localhost:6080
2023-01-27 22:00:02.031 started checking epic-games
Signed in as XXXXX
Free games: [
  'https://store.epicgames.com/en-US/p/adios-b378b4',
  'https://store.epicgames.com/en-US/p/hell-is-others-789262'
]
Current free game: Adios
  Already in library! Nothing to claim.
Current free game: Hell is Others
  Already in library! Nothing to claim.
2023-01-27 22:00:13.636 started checking prime-gaming
Signed in as XXXXX
Number of already claimed games (total): 15
Number of free unclaimed games (Prime Gaming): 0
Number of free unclaimed games (external stores): 0
Xvfb display server created screen with resolution 1280x720
VNC is running on port 5900 (no password!)
noVNC (VNC via browser) is running on http://localhost:6080
2023-01-27 23:00:03.465 started checking epic-games
Signed in as XXXXX
Free games: [
  'https://store.epicgames.com/en-US/p/adios-b378b4',
  'https://store.epicgames.com/en-US/p/hell-is-others-789262'
]
Current free game: Adios
  Already in library! Nothing to claim.
Current free game: Hell is Others
  Already in library! Nothing to claim.
2023-01-27 23:00:15.298 started checking prime-gaming
Signed in as XXXXX
Number of already claimed games (total): 15
Number of free unclaimed games (Prime Gaming): 0
Number of free unclaimed games (external stores): 0

Notifications

[vogler]

The perils of mutability - not used to imperative programming 😄
notify_game.status was never set to existed. Thanks for the report, should work as intended now.

[vogler]

Where do you see this? It should already only notify about newly claimed games.

free-games-claimer/epic-games.js

Lines 201 to 203 in 01acfc2

	if (notify_games.filter(g => g.status != 'existed').length) { // don't notify if all were already claimed; TODO don't notify if killed?
	notify(`epic-games:<br>${html_game_list(notify_games)}`);
	}

free-games-claimer/prime-gaming.js

Lines 184 to 186 in 01acfc2

	if (notify_games.length) { // list should only include claimed games
	notify(`prime-gaming:<br>${html_game_list(notify_games)}`);
	}

free-games-claimer/gog.js

Lines 129 to 131 in 01acfc2

	if (notify_games.filter(g => g.status != 'existed').length) { // don't notify if all were already claimed; TODO don't notify if killed?
	notify(`gog:<br>${html_game_list(notify_games)}`);
	}