GithubHelp home page GithubHelp logo

worldpreview's People

Contributors

voidxwalker avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

worldpreview's Issues

1.17.1 Unable to join servers with WorldPreview

When joining any server with this mod on 1.17.1, client gets stuck on the "Connecting to server" screen. The player tehnically gets connected to the server (Player joined the server), but something breaks after that - presumably when rendering or receiving world chunks from the server.

I haven't tested any other versions, but I know 1.16.1 doesn't have this issue.

Game crashes with Java 1.8 on 1.16

1.16.1 is more stable with java 8 but the worldpreview mod does not support it, it would be nice if this gets fixed because java 17 causes a lot of crashes

1.15.2 Sodium Incompatibility

As of version 2.3.0:

java.lang.NullPointerException: Cannot invoke "me.jellysquid.mods.sodium.client.render.chunk.passes.BlockRenderPassManager.getRenderPassForLayer(net.minecraft.class_1921)" because "this.renderPassManager" is null
	at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.drawChunkLayer(SodiumWorldRenderer.java:202)
	at net.minecraft.class_761.method_3251(class_761.java:4026)
	at net.minecraft.class_761.worldpreview_renderSafe(class_761.java:5924)
	at net.minecraft.class_761.handler$zbj000$worldpreview_render(class_761.java:5788)
	at net.minecraft.class_761.method_22710(class_761.java:1133)

crash-2022-02-25_14.16.35-client.txt

Crash during HDWGH attempts

I've gotten crashes attempting hdwgh on multiple prac maps. Its only when using the mod, and it happens right before the achievement is completed.
Steps to recreate:

  1. Use 1.16.1 MrMangoHands' Sodium backport and the most recent version of World Preview (2.3.1)
  2. Use Acewhite's HDWGH practice map (linked in the AA resources channel)
  3. Using the practice attempts mode, complete the advancement
    After this, the game lags for a moment before showing an exit screen and crashing.

Example: https://drive.google.com/file/d/1sSxLnt_MXiC7fesLwTO1RcXrt1JQ5h7Z/view?usp=sharing
No error log is generated.
Log: latest.log
Let me know if anything else is needed.

-XX:MaxDirectMemorySize results in stuttering

Summary

Including -XX:MaxDirectMemorySize=256M in JVM arguments results in stuttering with WorldPreview enabled for me.

Video showing WorldPreview with the argument: https://youtu.be/eyyHyfaQ7D4
Video showing WorldPreview without the argument: https://youtu.be/PI25XlUUOb8

The stuttering is practically nonstop for the first minute or so after loading into the world, at which point it mostly stops. It appears to happen again when loading new chunks. It also seems to cause the GC to run, although I have no idea if that is related.

This issue also does not occur when Sodium is disabled.

Test cases

The log message refers to the one referenced in the next section.

  • Sodium enabled, no additional JVM arguments - no stutters, log message appears
  • Sodium disabled, no additional JVM arguments - no stutters, log message does not appear
  • Sodium enabled, -XX:MaxDirectMemorySize=256M - stutters, log message appears
  • Sodium disabled, -XX:MaxDirectMemorySize=256M - no stutters, log message appears

Additional info

This log message is the one I am referencing above.

I am additionally using this as a wrapper command in MultiMC, to help with memory usage:

sh -c "export MALLOC_ARENA_MAX=2; $INST_JAVA $@"

I similarly use -XX:MaxDirectMemorySize to reduce memory usage; using it appears to reduce memory usage in game from ~2.6GB down to ~2GB most of the time.

Memory allocation in MultiMC set to minimum 307MB, maximum 2048MB.

For posterity, here are the full JVM arguments which I use. This issue still persists when using nothing but -XX:MaxDirectMemorySize=256M.

-XX:+UseG1GC 
-Dsun.rmi.dgc.server.gcInterval=999999 
-XX:+UnlockExperimentalVMOptions 
-XX:G1NewSizePercent=20 
-XX:G1ReservePercent=20 
-XX:MaxGCPauseMillis=50 
-XX:G1HeapRegionSize=32M 
-XX:MaxDirectMemorySize=256M

Software:

  • OpenJDK 17.0.1
  • MultiMC 0.6.14-2998
  • Linux, glibc 2.35
  • Fabric 0.13.2

Mods:

  • Auto Reset 1.2.0
  • Dynamic Menu FPS 0.1
  • FastReset 1.4.0
  • LazyDFU 0.1.2
  • Lithium 0.6.6 (MangoHands version)
  • motioNO 1.0.1
  • Sodium 0.2.0+build.17 (MangoHands version)
  • SpeedrunIGT 4.19
  • Starlight 1.0.0-RC2-82ae5ca
  • Voyager 1.0.0
  • WorldPreview 2.2.5

Happy to give any more information that I didn't think to include that might be needed. You can also contact me in javacord if need be (woofdoggo#0001)

Build Error: Failed to apply plugin 'fabric-loom'. (1.19.3 Branch) (Arch Linux)

OS: Arch Linux (Kernel 6.2.12-zen1-1-zen)
DE: xfce4, GTK
Platform: OpenJDK 17

FAILURE: Build failed with an exception.

* Where:
Build file '/home/theocgaming/Downloads/WorldPreview-1.19.3/build.gradle' line: 3

* What went wrong:
An exception occurred applying plugin request [id: 'fabric-loom', version: '1.0-SNAPSHOT']
> Failed to apply plugin 'fabric-loom'.
   > You are using an outdated version of Java (8). Java 17 or higher is required.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 1s

`NullPointerException: Cannot invoke "net.minecraft.world.dimension.DimensionType.comp_651()" because "this.dimensionType" is null`

java.lang.NullPointerException: Cannot invoke "net.minecraft.world.dimension.DimensionType.comp_651()" because "this.dimensionType" is null
	at caeruleusTait.world.preview.backend.WorkManager.yMin(WorkManager.java:442)
	at caeruleusTait.world.preview.backend.WorkManager.yMax(WorkManager.java:446)
	at caeruleusTait.world.preview.RenderSettings.resetCenter(RenderSettings.java:37)
	at caeruleusTait.world.preview.client.gui.screens.PreviewContainer.lambda$new$1(PreviewContainer.java:176)
	at MC//net.minecraft.client.gui.widget.ButtonWidget.onPress(ButtonWidget.java:94)
	at MC//net.minecraft.client.gui.widget.PressableWidget.onClick(PressableWidget.java:56)
	at MC//net.minecraft.client.gui.widget.ClickableWidget.mouseClicked(ClickableWidget.java:189)
	at MC//net.minecraft.client.gui.ParentElement.mouseClicked(ParentElement.java:38)
	at MC//net.minecraft.client.Mouse.method_1611(Mouse.java:98)
	at MC//net.minecraft.client.gui.screen.Screen.wrapScreenError(Screen.java:409)
	at MC//net.minecraft.client.Mouse.onMouseButton(Mouse.java:98)
	at MC//net.minecraft.client.Mouse.method_22686(Mouse.java:169)
	at MC//net.minecraft.util.thread.ThreadExecutor.execute(ThreadExecutor.java:102)
	at MC//net.minecraft.client.Mouse.method_22684(Mouse.java:169)
	at org.lwjgl.glfw.GLFWMouseButtonCallback$Container.invoke(GLFWMouseButtonCallback.java:81)
	at com.moulberry.axiom.editor.CustomImGuiImplGlfw.mouseButtonCallback(CustomImGuiImplGlfw.java:190)
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at org.lwjgl.system.JNI.invokeV(Native Method)
	at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
	at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237)
	at MC//net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1244)
	at MC//net.minecraft.client.MinecraftClient.run(MinecraftClient.java:802)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at app//net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at app//net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at app//net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at app//org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
	at app//org.prismlauncher.EntryPoint.listen(EntryPoint.java:127)
	at app//org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

Minecraft 1.14.4 Crash!

I play minecraft 1.14.4 with fabric loader 0.13.3 . Mods are optifine optifabric atum speedrunigt and worldpreview . It will crash when launching . When i deleted the worldpreview , the game will successfully launch. Please fix the bug. Thanks.

Nether Ambient sounds continue to play after leaving nether, version 1.16.1

After leaving the nether through a nether portal, the nether ambient sounds continue to play on overworld or in the End. Current fix is either reloading textures or leave and rejoin the world. (Tested in 2.3.0 and 2.3.2) Also, after about 3-4 hours of playtime, the general sound starts to glitch out, till you dont hear any sounds at all anymore. Current fix is also reloading textures or leave and rejoin the world. (Tested in 2.3.0, might be fixed in 2.3.2?)

Minecraft 1.16.1 game crashed

[17:08:29] [main/INFO]: Loading Minecraft 1.16.1 with Fabric Loader 0.14.8
[17:08:30] [main/INFO]: Loading 48 mods:
- fabric 0.18.0+build.387-1.16.1
- fabric-api-base 0.1.3+12a8474c02 via fabric
- fabric-biomes-v1 0.2.7+059ea86602 via fabric
- fabric-blockrenderlayer-v1 1.1.4+c6a8ea8902 via fabric
- fabric-command-api-v1 1.0.8+5ce5339802 via fabric
- fabric-commands-v0 0.2.0+52d3083602 via fabric
- fabric-containers-v0 0.1.8+045df74f02 via fabric
- fabric-content-registries-v0 0.1.9+059ea86602 via fabric
- fabric-crash-report-info-v1 0.1.2+b7f9825d02 via fabric
- fabric-dimensions-v1 1.0.0+a71b305302 via fabric
- fabric-events-interaction-v0 0.4.0+e540c58402 via fabric
- fabric-events-lifecycle-v0 0.2.0+16acbe5b02 via fabric
- fabric-game-rule-api-v1 1.0.0+fe81e12502 via fabric
- fabric-item-api-v1 1.0.0+16acbe5b02 via fabric
- fabric-item-groups-v0 0.2.0+438f963602 via fabric
- fabric-key-binding-api-v1 1.0.1+f404f3be02 via fabric
- fabric-keybindings-v0 0.2.0+3fa9f7c502 via fabric
- fabric-lifecycle-events-v1 1.2.0+e83e061c02 via fabric
- fabric-loot-tables-v1 1.0.0+386eb69e02 via fabric
- fabric-mining-levels-v0 0.1.2+b764ce9902 via fabric
- fabric-models-v0 0.1.0+dfdb52d602 via fabric
- fabric-networking-blockentity-v0 0.2.5+b50ffc7b02 via fabric
- fabric-networking-v0 0.1.10+e00ecb5f02 via fabric
- fabric-object-builder-api-v1 1.5.7+2242e77202 via fabric
- fabric-object-builders-v0 0.6.1+a2d21ddd02 via fabric
- fabric-particles-v1 0.2.1+0a6f2a7002 via fabric
- fabric-registry-sync-v0 0.3.8+7dba2d6c02 via fabric
- fabric-renderer-api-v1 0.2.13+eae12eb802 via fabric
- fabric-renderer-indigo 0.3.4+34d6c87102 via fabric
- fabric-renderer-registries-v1 2.1.0+be551d3c02 via fabric
- fabric-rendering-data-attachment-v1 0.1.3+b7f9825d02 via fabric
- fabric-rendering-fluids-v1 0.1.8+b7084faa02 via fabric
- fabric-rendering-v0 1.1.0+5341049002 via fabric
- fabric-rendering-v1 1.1.2+346247d702 via fabric
- fabric-resource-loader-v0 0.2.6+f41e209802 via fabric
- fabric-screen-handler-api-v1 1.1.0+97324d1102 via fabric
- fabric-tag-extensions-v0 0.2.7+a4c57d8e02 via fabric
- fabric-textures-v0 1.0.4+eae12eb802 via fabric
- fabric-tool-attribute-api-v1 1.2.1+91fca5cd02 via fabric
- fabricloader 0.14.8
- java 8
- lithium 0.6.6
- minecraft 1.16.1
- modmenu 1.14.5+build.30
- phosphor 0.6.0+build.7
- sodium 0.1.0
- speedrunigt 10.10+1.16.1
- worldpreview 2.3.3+1.16.1
[17:08:33] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/C:/Users/19535/AppData/Roaming/.minecraft/libraries/net/fabricmc/sponge-mixin/0.11.4+mixin.0.8.5/sponge-mixin-0.11.4+mixin.0.8.5.jar Service=Knot/Fabric Env=CLIENT
[17:08:34] [main/INFO]: Loaded configuration file for Lithium: 79 options available, 0 override(s) found
[17:08:34] [main/INFO]: Loaded configuration file for Sodium (38 options available, 0 user overrides)
[17:08:34] [main/INFO]: Sodium has been successfully discovered and initialized -- your game is now faster!
[17:08:52] [main/ERROR]: Minecraft has crashed!
net.fabricmc.loader.impl.FormattedException: java.lang.IllegalAccessError: no such constructor: net.minecraft.class_1550.(class_1299,class_1937)void/newInvokeSpecial
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:463) ~[fabric-loader-0.14.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.14.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.14.8.jar:?]
Caused by: java.lang.IllegalAccessError: no such constructor: net.minecraft.class_1550.(class_1299,class_1937)void/newInvokeSpecial
at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:483) ~[?:1.8.0_51]
at net.minecraft.class_1299.(class_1299.java:169) ~[client-intermediary.jar:?]
at net.minecraft.class_2378.method_10252(class_2378.java:171) ~[client-intermediary.jar:?]
at net.minecraft.class_2378$$Lambda$127/1306085976.get(Unknown Source) ~[?:?]
at net.minecraft.class_2378.method_29110(class_2378.java:220) ~[client-intermediary.jar:?]
at net.minecraft.class_2378$$Lambda$169/654740048.accept(Unknown Source) ~[?:?]
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:676) ~[?:1.8.0_51]
at net.minecraft.class_2378.(class_2378.java:219) ~[client-intermediary.jar:?]
at net.minecraft.class_2966.method_12851(class_2966.java:41) ~[client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:137) ~[fabric-loader-0.14.8-1.16.1.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.8.jar:?]
... 2 more
Caused by: java.lang.UnsupportedClassVersionError: net/minecraft/class_3222 has been compiled by a more recent version of the Java Runtime (class file version 60.0), this version of the Java Runtime only recognizes class file versions up to 52.0
at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_51]
at java.lang.ClassLoader.defineClass(ClassLoader.java:760) ~[?:1.8.0_51]
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) ~[?:1.8.0_51]
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.defineClassFwd(KnotClassLoader.java:186) ~[fabric-loader-0.14.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:347) ~[fabric-loader-0.14.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145) ~[fabric-loader-0.14.8.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandleNatives.resolve(Native Method) ~[?:1.8.0_51]
at java.lang.invoke.MemberName$Factory.resolve(MemberName.java:962) ~[?:1.8.0_51]
at java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:987) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:1390) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandles$Lookup.linkMethodHandleConstant(MethodHandles.java:1746) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:477) ~[?:1.8.0_51]
at net.minecraft.class_1299.(class_1299.java:169) ~[client-intermediary.jar:?]
at net.minecraft.class_2378.method_10252(class_2378.java:171) ~[client-intermediary.jar:?]
at net.minecraft.class_2378$$Lambda$127/1306085976.get(Unknown Source) ~[?:?]
at net.minecraft.class_2378.method_29110(class_2378.java:220) ~[client-intermediary.jar:?]
at net.minecraft.class_2378$$Lambda$169/654740048.accept(Unknown Source) ~[?:?]
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:676) ~[?:1.8.0_51]
at net.minecraft.class_2378.(class_2378.java:219) ~[client-intermediary.jar:?]
at net.minecraft.class_2966.method_12851(class_2966.java:41) ~[client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:137) ~[fabric-loader-0.14.8-1.16.1.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.8.jar:?]
... 2 more

2.3.3+1.16.1 crashing on launch

Minecraft crushes with exit code 1 before even the Mojang logo screen apperaing.
I tested all the other mods in the folder and it only happends when WorldPreview is in the mods folder.
Is there anything I should do before installing the mod or maybe is it meant to be used with specific macro?
Version 2.3.1 works fine tho
I use java 18.
I attach latest.log
latest.log

Minecraft Insta Crashing

When using the newest Version 2.3.2, the game starts, but insta crashes without even showing the loading screen on 1.16.1. The Version 2.3.1 works perfectly fine tho

1.19.2?

I love this mod! I would like to know if this is going to receive a update to the more recent Minecraft versions anytime soon?

Black Preview

Issue

The preview turns, besides the little chunk map, completly black, whenever minecraft is getting resized/fullscreened/gui-scale is changed, but only while being frozen.

blackPreview.mp4

Steps to replicate

  1. Reset
  2. Freeze Preview
  3. Resize Minecraft / switch to fullscreen / change the gui-scale

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.