GithubHelp home page GithubHelp logo

Comments (5)

vossstef avatar vossstef commented on June 22, 2024

@prcoder-1 would you pls. try this correction and let me know ?
Control Audio Volume via OSD (F12 Key) Thx !

from tang_nano_20k_c64.

prcoder-1 avatar prcoder-1 commented on June 22, 2024

@prcoder-1 would you pls. try this correction and let me know ? Control Audio Volume via OSD (F12 Key) Thx !

I tried adjusting the volume through the OSD menu (F12). Only the "Off" option works. The rest (33%,66%,100%) work exactly the same and output over-amplified, distorted sound.

from tang_nano_20k_c64.

vossstef avatar vossstef commented on June 22, 2024

strange... Added even rather new HMDI core enhancements and Audio processing identical to Mister main branch. In my opinion there should be a difference. There was a clearly noticeable difference on my Monitor.
I added for your convenience the .fs file too.

https://github.com/vossstef/tang_nano_20k_c64/blob/dev_audiofix/impl/pnr/tang_nano_20k_c64.fs

May you try this ready made synthesized .fs file and let me know ? Sorry for inconvenience. Thx

from tang_nano_20k_c64.

prcoder-1 avatar prcoder-1 commented on June 22, 2024

Your .fs file work fine. Sounds right. But volume control doesn't work. Only 'Off' for no sound and other value for sound on.

After these changes, the sound worked fine for me in the version I synthesized:

index edacadd..57bcdae 100644
--- a/src/tang_nano_20k_c64_top.vhd
+++ b/src/tang_nano_20k_c64_top.vhd
@@ -397,8 +397,8 @@ port map(
       g_in      => std_logic_vector(g(7 downto 4)),
       b_in      => std_logic_vector(b(7 downto 4)),
 
-      audio_l => '0' & audio_data_l(17 downto 11) & audio_data_l(17 downto 10),
-      audio_r => '0' & audio_data_l(17 downto 11) & audio_data_l(17 downto 10),
+      audio_l => audio_data_l(17 downto 2),
+      audio_r => audio_data_r(17 downto 2),
       enabled => osd_status,
 
       mcu_start => mcu_start,

I don't understand how this logic works and why only the left channel (audio_data_l() is used in both cases (audio_l and audio_r ):
'0' & audio_data_l(17 downto 11) & audio_data_l(17 downto 10),

Now I want to try to synthesize dev_audiofix branch.

from tang_nano_20k_c64.

prcoder-1 avatar prcoder-1 commented on June 22, 2024

Branch dev_audiofix synthesized and works well. But the sound volume is not adjustable, it can only be turned off.

from tang_nano_20k_c64.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.