All Numeric MAC causes Detail: undefined method `upcase' about puppet-dhcp

[petems]

@ppouliot What does the code you're using look like? Are you passing the mac address within quotes? It looks like its turning the mac address into a number

I'm trying to recreate in tests and I can get it to fail.

It'd be easy enough to fix IMO:

hardware ethernet   <%= @mac.to_s.upcase %>;

[alexjfisher]

I'm trying to recreate in tests and I can get it to fail.

@petems You can get it to fail? I've not been able to yet.

[petems]

Typo, shoudve been cant :)

[ppouliot]

So we're using hiera to push all data into the module. No quotes used on the mac address in the yaml files.

[ppouliot]

Hiera i'm using is as follows:

dhcp::dnsdomain:
      - contoso.ltd
      - 0.168.192.in-addr.arpa

dhcp::nameservers:
      - 192.168.0.1
      - 192.168.0.2

dhcp::ntpservers:
  - bonehed.lsc.mit.edu
dhcp::interfaces:
  - eth0

dhcpdata:
  contoso.ltd:
    failover: dhcp-failover
    network: 192.168.0.0
    mask: 255.255.255.0
    gateway: 192.168.0.254
    range:
      - 192.168.0.100
      - 192.168.0.220
    options:
      - domain-name-servers 192.168.0.1
      - domain-name "contoso.ltd"
      - ntp-servers bonehed.lcs.mit.edu
    parameters:
      - ddns-domainname "contoso.ltd, 0.168.192.in-addr.arpa"

static_leases:
  myhost:
    mac: 00:1a:2b:3c:4d:5e
    ip: 192.168.0.3
# Uncomment this entry to test mac addresses that are only numeric
#  allnumericmac:
#    mac: 00:07:43:14:15

[petems]

Ah, that would explain it. You might want to obfuscate the data btw, just in case.

Can you try putting quotes around the mac addresses in the yaml?

[ppouliot]

so I'm trying that now, here's the output from data, and it's not actually my working data, it's just basics for testing the modules. I've got 15000 lines of hiera we feed into the module with our specifics.

When I add quotes to my code defining the record I get this as output in the dhcpd.hosts file.

host allnumericmac {
hardware ethernet 6535303;
fixed-address 192.168.0.4;
ddns-hostname "allnumericmac";
}

[ppouliot]

So quotes in the hiera appears to work.
Output after adding quotes for the record is as follows.

host allnumericmac {
hardware ethernet 00:07:43:14:15:30;
fixed-address 192.168.0.4;
ddns-hostname "allnumericmac";
}

[ekohl]

Now #110 is merged, can this be closed?

[alexjfisher]

@ekohl I think so. @ppouliot has a solution and we've got extra validation in the module from now on.