Ubuntu 18.04 Interfaces not set about puppet-dhcp

[bastelfreak]

Hi @nigemar, we've a test for the interfaces parameter which works:
https://github.com/voxpupuli/puppet-dhcp/blob/master/spec/classes/dhcp_spec.rb#L68
Maybe the hiera lookup isn't working properly? Can you implement a notice to verify the content of $interfaces in your profile?

[nigemar]

Hi @bastelfreak, I will try this again.
cheers
-Nigel

[nigemar]

Hi,
Unfortunately the issue still persists:

Puppet run with a notify:

root@grace# puppet agent -t
Info: Using configured environment 'master'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for grace.network.local
Info: Applying configuration version 'puppet-master-889eb9d1868'
Notice: Inside the base class
Notice: /Stage[main]/Profile::Base/Notify[Inside the base class]/message: defined 'message' as 'Inside the base class'
Notice: Inside the dhcp class interface: eno1
Notice: /Stage[main]/Profile::Dhcp/Notify[Inside the dhcp class interface: eno1]/message: defined 'message' as 'Inside the dhcp class interface: eno1'
Notice: Applied catalog in 0.40 seconds

I had to disable the class, so now here is the run with the class enabled

root@grace# puppet agent -t
Info: Using configured environment 'master'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, You need to set $interfaces in dhcp (file: /etc/puppetlabs/code/environments/master/modules/dhcp/manifests/init.pp, line: 104, column: 5) on node grace.network.local
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run`

Cheers
-Nigel

[bastelfreak]

Can you please provide a PR that uses your code as an acceptance test?

[nigemar]

Just checking you want a pull request which includes:

1. role
2. profile
3. manifest
4. node yaml

Is that correct?

[nigemar]

Pull request created.
All data under tests directory.

#223

[nigemar]

I have tested this on Centos 7 and I get the same response:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, You need to set $interfaces in dhcp (file: /etc/puppetlabs/code/environments/master/modules/dhcp/manifests/init.pp, line: 104, column: 5) on node grace.network.local

Class is still the same.

[nigemar]

I think I have this sorted, perhaps its my lack of understanding of how to implement this class, but I have this work around, but explicitly setting the interface and interfaces value being passed to class.

# Class: profile::dhcp()
class profile::dhcp(

  String $dns_server,
  String $gateway,
  String $pxe_server,
  Array[String] $interfaces,
  Optional[String] $interface = 'NOTSET',

){

  class { 'dhcp':
    service_ensure => running,
    dnsdomain      => [
      'network.local',
      '0.168.192.in-addr.arpa',
    ],
    nameservers    => [$dns_server],
    ntpservers     => ['192.168.0.1'],
    interfaces     => $interfaces,
    pxeserver      => $pxe_server,
    pxefilename    => 'pxelinux.0',
  }

  dhcp::pool {'sn_192.168.0.0' :
    network     => '192.168.0.0',
    mask        => '255.255.255.0',
    range       => '192.168.0.120 192.168.0.140',
    nameservers => [$dns_server],
    gateway     => $gateway,
  }
}