Comments (4)
I think it's bad to apply the clang-format automatically, it should be done manually and any changes reviewed for how appropriate they are. Build systems that change source code automatically are dangerous and would strongly recommend against doing so.
FYI, this is clang-format version I'm using:
clang-format --version
Ubuntu clang-format version 14.0.6-1
My intention with the built in make clang-format targets in the VSG projects if for them to be run occasionally, mostly something I will do to keep the codebase tidy.
If later clang-format versions move the goal posts on how it interprets existing .clang-format files then we'll either have to be aware of this, as to what versions might cause problems we'll just need to test them and flag up the problem. I don't know how formal we need to go with such build utilities.
from vsgexamples.
The way the project's set up at the moment, you've already got it applying automatically when a Visual Studio CMake generator is used. The root cause is the same as vsg-dev/VulkanSceneGraph#989, but I hadn't found that problem yet when I reported this.
from vsgexamples.
I wasn't aware that Visual Studio was automatically running targets that users hadn't explicitly run. Is this a CMake error or just the way VisualStudio attempts to do things?
from vsgexamples.
As discussed in the linked MR, kind of a mixture of both.
from vsgexamples.
Related Issues (20)
- how to render models with tileData? HOT 1
- If vsgTransform is no command line parameter, it will crash. HOT 1
- vsgviewer render readymap.vsgt? HOT 5
- Wayland support HOT 2
- Compiling issues for vsgvolume example HOT 4
- vertex and fragment source for vert_PushConstants.spv and frag_PushConstants.spv HOT 5
- vsgshadow without shadows on MacOS HOT 16
- None of the example models are actually compatible with vsgclip example HOT 2
- vsgshadow has black patches flickering on the ground HOT 4
- No CMakeLists.txt file for vsgoffscreenshot HOT 2
- vsgscreenshot can produce strange output HOT 2
- vsgexecutecommands crashes on windows HOT 8
- VSG_INSTANCE_POSITIONS format change HOT 2
- Request for a hello-world example HOT 3
- How to display a point on the earth map? HOT 1
- vsgvolume is actually broken on Windows 11 and Ubuntu 22.4 HOT 3
- problem with overlay views using multiple render graphs in the same window HOT 3
- DescriptorPool warning when using compileManager with storage buffers HOT 2
- Examples abort on shutdown when run in Debug HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vsgexamples.