GithubHelp home page GithubHelp logo

product-comparison's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

product-comparison's Issues

Error unchecking comparison input

Sometimes it is not possible to deselect the imput of the comparison component, sometimes it works and sometimes it doesn't.

product-comparison.min.mp4

Product Comparison does't work under product page context.

Describe the bug
I'm no very sure if it's a bug that should be working, or a request for a feature.. but..
When trying to use the product comparison interfaces in product page, just as it is done in search result, the blocks are rendered, no errors are given into the terminal... but when trying to add the product to the queue to be compared, it's not added, and that behavior also makes the comparison in search result to not work properly...
idk if it's some context issue.

To Reproduce
Steps to reproduce the behavior:

  1. Reproduce the same steps and configuration for store.search in store.product
  2. Try to add the product to compare
  3. See that the drawer is rendered but no list context. Try to go back to the search result(configured as well) and see the same behavior.

Expected behavior
Expected to behavior just like in search-page, being able to add a product to the comparison list through product page.

Grouped Specifications shows "AllSpecifications" Pseudo group

Hi!
When displaying the grouped specifications, the code iterates through all groups to render them.
On the product context however, there is one Pseudo-Group "allSpecifications" that - as the name says - contains all specifications in a flat structure.

This has the consequence, that the Specs are shown twice. once in their correspoding group and once below in "allSpecifications".

a PR with the bugfix is on its way.

Pull Request

Hello,

I opened a new application 18 days ago and now I see that no one has been assigned for the examination. Can anyone take a look? We have customers waiting for this change.

Thanks.

Product comparison page displaying console error "error in dispatch"

I followed all vtex.product-comparison config steps and search page, category page, product page and bucket area for products to compare are working fine. Just only the product-comparison page is not working (blank page), giving me console error error in dispatch {args: {โ€ฆ}, type: 'SET_SHOW_DIFFERENCES'}. I created a "store.custom#product-comparison-list" block following this step and the properly route to product-comparison.

I've already reviewed all the settings and I'm trying to debug through app link, which I cloned in the version I'm using.

I think some undocumented step is missing.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.