vttred / old-school-essentials-advanced-fantasy-for-foundry-vtt Goto Github PK

What happened?

Using the Advanced Fantasy Macros for encounters, an error is thrown in the console and no result is returned.

What is the expected behaviour?

Macros should produce encounters in the chat.

Relevant Errors and Warnings

undefined. Cannot read properties of undefined (reading 'index')
[Detected 1 package: ose-advancedfantasytome]
    at OSE.util.wildEncResult (encounterTables.js:145:26)
    at OSE.util.wildEncounter (encounterTables.js:107:16)
    at Macro.eval (eval at #executeScript (foundry.js:22452:16), <anonymous>:3:10)
    at #executeScript (foundry.js:22456:17)
    at Macro.execute (foundry.js:22404:35)
    at MacroConfig._onExecute (foundry.js:74437:17)
OSE.util.wildEncResult @ encounterTables.js:145
OSE.util.wildEncounter @ encounterTables.js:107
eval @ VM977:3
#executeScript @ foundry.js:22456
execute @ foundry.js:22404
_onExecute @ foundry.js:74437
await in _onExecute (async)
dispatch @ jquery.min.js:2
y.handle @ jquery.min.js:2

Additional Support Details

Foundry Version 11
Windows 11
Edge Browser (latest)

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Microsoft Edge

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

Links for Treasure Type Table is broken in monster stat blocks from the compendium. The treasure tables are present in their proper compendium and can be added to the monster block manually.

What is the expected behaviour?

Link should not be broken

Relevant Errors and Warnings

No errors in  console

Additional Support Details

Foundry Virtual Tabletop: Version 11 Stable, 11.299
Game System: ose, 1.9.1
Active Modules: 27
Performance Mode: 3

OS: Unknown
Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36 Edg/113.0.1774.50
GPU: ANGLE (NVIDIA, NVIDIA GeForce RTX 3080 Direct3D11 vs_5_0 ps_5_0, D3D11)
Max Texture Size: 16384

Scene: 1210 x 1186 | Grid Size: 100 | Padding Percentage: 0
Walls: 0 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 0

Actors: 24 | Items: 0 | Journal Entries: 33 | Rollable Tables: 3 |
Playlists: 1 | Compendium Packs: 30 | Chat Messages: 4

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Microsoft Edge

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

The hellhound is missing from the "classic" half of the monster compendium

Package Version

1.0.0

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

1. open pick locks ability in thief abilities compendium
2. the link there is broken

What is the expected behaviour?

the text should be more like

Requires @UUID[Compendium.ose-advancedfantasytome.equipment.Item.jAbvsYZnqDvu2jZ8]{Thieves' Tools}. A thief can only try this skill once per lock. If the roll fails, the thief may not try the same lock again before gaining an experience level.

Relevant Errors and Warnings

No response

Additional Support Details

version 2.0.1

Foundry VTT Core Version

V11

Old-School Essentials Core Version

No response

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Chrome

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

The level progression tables are only included as a journal entry and not a class ability. This is inconvenient for those wanting to show their level progression to their players inside their character sheet.

Package Version

1.0.1

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

1. No effect. Just a console error when Foundry VTT is loading.

What is the expected behaviour?

No response

Relevant Errors and Warnings

ReferenceError: Error thrown in hooked function '' for hook 'OSE Initialized'. OSRCB is not defined
    <anonymous> http://localhost:30000/modules/ose-advancedfantasytome/scripts/classData.js:71
    #call http://localhost:30000/scripts/foundry.js:730
    call http://localhost:30000/scripts/foundry.js:712
    <anonymous> http://localhost:30000/modules/ose-advancedfantasytome/scripts/init.js:14
    #call http://localhost:30000/scripts/foundry.js:730
    callAll http://localhost:30000/scripts/foundry.js:687
    initialize http://localhost:30000/scripts/foundry.js:8529
    <anonymous> http://localhost:30000/scripts/foundry.js:90096
    async* http://localhost:30000/scripts/foundry.js:90077
foundry.js:753:30
    onError http://localhost:30000/scripts/foundry.js:753
    #call http://localhost:30000/scripts/foundry.js:734
    call http://localhost:30000/scripts/foundry.js:712
    <anonymous> http://localhost:30000/modules/ose-advancedfantasytome/scripts/init.js:14
    #call http://localhost:30000/scripts/foundry.js:730
    callAll http://localhost:30000/scripts/foundry.js:687
    initialize http://localhost:30000/scripts/foundry.js:8529
    <anonymous> http://localhost:30000/scripts/foundry.js:90096
    <anonymous> http://localhost:30000/scripts/foundry.js:90077

Additional Support Details

No response

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

A chapter has gone missing: R07. Sentient Swords. The chapter appears to be blank.

Reported via Discord

Package Version

1.0.0

PDF Version

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

Reproduction steps:

1. I clicked on P02. Character Classes
2. I clicked on Paladin
3. I saw the line for level 14 on the Paladin Level Progression table looked incorrectly formatted:
   

What is the expected behaviour?

I expect it to look like this:

Relevant Errors and Warnings

No errors, just a formatting error

Additional Support Details

This is an easy fix.
Instead of

<tr>
    <td>14</td>
    <td>1,100,000 9d8+10* 10 [+9]</td>
    <td>2</td>
    <td>3</td>
    <td>4</td>
    <td>3</td>
    <td>6</td>
    <td>3</td>
    <td>2</td>
    <td>1</td>
</tr>

It should be

<tr>
    <td>14</td>
    <td>1,100,000</td>
    <td>9d8+10*</td>
    <td>10 [+9]</td>
    <td>2</td>
    <td>3</td>
    <td>4</td>
    <td>3</td>
    <td>6</td>
    <td>3</td>
    <td>2</td>
    <td>1</td>
</tr>

Foundry VTT Core Version

V11

Old-School Essentials Core Version

No response

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

I get the following message trying to update the OSE Advanced Fantasy (premium) module in Foundry v11:

Failed to install module: Unable to load valid module manifest data from "https://github.com/vttred/Old-School-Essentials-Advanced-Fantasy-for-Foundry-VTT/releases/download/latest/module.json" The requested manifest at "https://github.com/vttred/Old-School-Essentials-Advanced-Fantasy-for-Foundry-VTT/releases/download/latest/module.json" did not provide module manifest data.

What is the expected behaviour?

It should update the module...

Relevant Errors and Warnings

"Failed to install module: Unable to load valid module manifest data from "https://github.com/vttred/Old-School-Essentials-Advanced-Fantasy-for-Foundry-VTT/releases/download/latest/module.json" The requested manifest at "https://github.com/vttred/Old-School-Essentials-Advanced-Fantasy-for-Foundry-VTT/releases/download/latest/module.json" did not provide module manifest data."

Additional Support Details

Foundry v11 stable build 299

Foundry VTT Core Version

V11

Old-School Essentials Core Version

v1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Chrome

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

Many of the Swords and other Weapons listed in the table on pages 222 and 228 of the Referee's Tome were missing. These were likely overlooked because they are not listed outside of the table itself.

Package Version

1.0.0

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

1. Attempt to update this module
2. There is an error message and the update does not complete successfully

What is the expected behaviour?

No response

Relevant Errors and Warnings

No response

Additional Support Details

No response

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

The base movement rate on the character sheets are not editable. Further, characters who were created in previous version of the system have wrong numbers in their base movement rate.

What is the expected behaviour?

The movement base movement rate should be editable for all characters.

Relevant Errors and Warnings

N/A

Additional Support Details

Foundry Virtual Tabletop: Version 11 Stable, 11.299
Game System: ose, 1.9.1
Active Modules: 30
Performance Mode: 3

OS: Unknown
Client: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36 Edg/113.0.1774.57
GPU: ANGLE (Apple, Apple M1, OpenGL 4.1)
Max Texture Size: 16384

Scene: 5412 x 3678 | Grid Size: 108 | Padding Percentage: 0.25
Walls: 38 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 1

Actors: 392 | Items: 723 | Journal Entries: 66 | Rollable Tables: 31 |
Playlists: 1 | Compendium Packs: 54 | Chat Messages: 4

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Microsoft Edge

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

The Referee's Reference journal contain empty journal pages for the Wilderness tables. This is due to a change in production style between Wilderness encounter journal entries and Wilderness encounter roll tables. The correct place to roll for encounters is in Wilderness Encounter roll tables

Package Version

1.0.1

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

Token disposition should be neutral, or hostile if written as always hostile in monster description

Package Version

1.0.2

PDF Version

n/a

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

"Hide in Shadows" ability for Assassins is rolled using 1d00 instead of 1d100, so it will always succeed. The same is true for Acrobats

Submitted by email

What is the expected behaviour?

No response

Relevant Errors and Warnings

No response

Additional Support Details

No response

Foundry VTT Core Version

None

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

Reported on Discord

Multiple Ioun Stone types have missing powers

Package Version

1.0.1

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

Advanced Fantasy Animals

Camel - Token name is Draft Horse
Mule - Token name is Draft Horse
Riding Horse - Token name is Draft Horse
War Horse - Token name is Draft Horse

Advanced Fantasy Monsters

Dragons in general - add specific breath type?
Anhkheg - add HD to names, must open to differentiate
Leucrotta & Leucrocotta?
Otyugh - add HD to names, 2 6d8 Otyugh - one should be 8d8
Piercer - they list HD, but they all have 1d8
Remorhaz - add HD to names
Shambling Mound - Token name is blank monster

Classic Fantasy Monsters

Chimera - Token name is Sabre-Toothed Tiger
Green Dragon - Token name is Blue Dragon
Dryad - No treasure type
Fish, Giant - folder type (Fish, Fiant)
Hellhound (3-7HD) - All token name Halfling
Harpy - Token name is Halfling
Sea Hydra - Token name is Hydra
Wererat - Token name is Wereboar
Weretiger - Token name is Wereboar
Aranea (spider) - Token name is blank monster
Troglodyte - Token name is Goblin

Package Version

2.0.1

PDF Version

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

It's possible this page should not exist (the contents of this section are exactly equivalent to the monster compendium)

Package Version

1.0.2

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

Druid - path-finding
Gnome - infravision

Package Version

1.0.2

PDF Version

n/a

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

Due to the way Class Abilities and Race abilities are used by third party modules, these two need to be two separate compendiums (at least for the time being)

Package Version

1.0.1

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

These should be rolling the subtables automatically anyway

Package Version

1.0.2

PDF Version

n/a

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

In the entry for Half-orc in the P02. Character Classes compendium, there is a broken link to "Half-Orc Thieving Skills Chance of Success" and that table is nowhere to be found on that page.

Package Version

1.0.4

PDF Version

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

What's wrong?

There should be a monster named Troglodyte (Advanced Fantasy page 120)

Package Version

1.0.1

PDF Version

1.3

Code of Conduct

• I agree to follow this project's Code of Conduct