GithubHelp home page GithubHelp logo

ose-content's People

Stargazers

avatar avatar avatar

Watchers

avatar

Forkers

freohr anthonyronda bayne7400 tuirgin tmenzonatto matthewfee

ose-content's Issues

[OSE 1.4.0] template.json update

template.json diff

FVTT updates all compendiums to add missing keys, inserting the default values provided. In this case, we do not have to write a compendium migration in the ose code because the default values are the values we want. The old version of ose-content is still compatible with the new version of ose.

We will eventually add this change to the package but this is low priority as it does not affect play or performance.

[OSE 1.7.3] Containers not actually containers

Bag of Holding, Sack (Small), Sack (Large), and Backpack are not stored correctly as "type": "container", which leads to problems seen in vttred/ose#291 .

Expected behavior:

  1. Drag bag-like item from Compendium to Actor.
  2. Container created on Actor.

Actual behavior:
2. Misc item (type=item) created on actor.

Potion icon not shown for holy water

The entries for Holy water at

ose-content/packs/equipment-adventuring-gear.db

Line 1 in 421fde0

{"_id":"00gPVNNHm6YRbe9p","name":"Holy water (vial)","permission":{"default":0,"fBZINKCGziZzc3CU":3},"type":"item","data":{"description":"<p>Water that has been blessed by a holy person. It is used in some religious rituals and inflicts damage on undead monsters (see <a href=\"https://oldschoolessentials.necroticgnome.com/srd/index.php/Weapons_And_Armour\">Weapon Combat Stats</a>).</p>\n<p>Holy water does not retain its power if stored in any other container than the special vials it is blessed in.</p>","quantity":{"value":1,"max":null},"treasure":false,"cost":25,"weight":null},"flags":{},"img":"modules/ose-content/assets/weapons/PotionIconsAdd_09_b.png","effects":[]}
and

ose-content/packs/equipment-weapons.db

Line 5 in 421fde0

{"name":"Holy water vial","permission":{"default":0,"fBZINKCGziZzc3CU":3},"type":"weapon","data":{"range":{"short":10,"medium":30,"long":50},"save":"","pattern":"white","description":"<p><strong>Missile:</strong>&nbsp;Thrown or fired weapon (greater than 5’ distance).The distances for short (+1 to hit), medium, and long (–1 to hit) range are shown in parentheses.</p>\n<p><strong>Splash weapon:</strong> On a successful attack, the container smashes and douses the target with the liquid.The listed damage is inflicted over two rounds, as the liquid drips off.</p>","damage":"1d8","bonus":0,"tags":[{"title":"5’–10’ / 11’–30’ / 31’–50’","value":"Missile"},{"title":"Splash weapon","value":"Splash weapon"}],"slow":false,"missile":true,"melee":false,"cost":25,"equipped":false,"weight":10,"counter":{"value":0,"max":0}},"flags":{},"img":"modules/ose-content/assets/weapons/PotionIconsAdd_09_b.png","effects":[],"_id":"HlrI4FpUj8YbcBqc"}
refer to "img":"modules/ose-content/assets/weapons/PotionIconsAdd_09_b.png" which I believe is not shipped with the module package.

So it feels to me that issue might be a missing asset.

Using old manifest key for system compatibility

Reported by Snowfall on Discord

Foundry V9 produces the following warning in console:

Package ose-content is using the old "systems" manifest key where a "system" key is expected

The fix is to remove a single letter in the module.json
Support for the old key may be removed in V10
Support for the new key was added in V8(?). Cody didn't know for sure

Manifest uses old key for pack types

Reported by Snowfall on Discord

Foundry V9 produces the following warning in console:

Package ose-content contains 33 compendium definitions that still use the deprecated 'entity' field instead of 'type'

The fix is to swap each usage of the entity key for the type key in the module.json
Support for the old key may be removed in V10
Support for the new key was added in V9

It was noted that both may be included to support 0.8.x, V9, and future versions

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.