vttred / tips Goto Github PK

Is your feature request related to a problem? Please describe.
Some modules or systems have little tid-bits which only apply to GMs or Players. Example: GM Screen tip might be "You can drag and drop items into GM Screen Cells," which is of no use to players.

Describe the solution you'd like
It would be neat to be able to define a set of tips as intended only for GMs.

Describe alternatives you've considered
The current pattern would be to mention that the tip is only useful for a GM, which would tell the player that they should ignore that tip.

Is your feature request related to a problem? Please describe.
Click to Close should be a localized string

Is your feature request related to a problem? Please describe.
The localization solution is great and very helpful, but I would like to have a file outside of the /data/modules , one that allows more contextually relevant information.

Describe the solution you'd like
allow a directory in the worlds' directory, if a /tips is present, stitch the *.jsons within for such.
So that the module references to include as additional tips that are campaign/game specific.

Ideally there would also allow "support" for other modules/systems to include a /tips directory or tip.json in their package so that if the module is loaded it includes those tips into the possible offerings. (this would likely also require settings for enabling/disabling of those tips)

Describe alternatives you've considered
Considered doing a single file for worlds , but was looking at how to expand the module's offering to help with other projects in their use to help bring people into foundry as a platform easier, or into their game, into using their module (functionality) or their adventure/world, or even game system.

(ie someone wants to make a tutorial / session zero module to help, but not force those elements into ALL their other worlds - or wanted to include additional/optional help that will be stitched into the main offerings)

• New tip contribution
• Translation contribution/help
• Bug
• Feature Request

Is your feature request related to a problem? Please describe.
BrotherSharp of the Japanese Foundry community felt as though this might be less helpful in Japanese because of the size of text.

Describe the solution you'd like
In Japanese we can set the default behavior to send chat messages instead of a custom popup modal

Describe alternatives you've considered
Make chat messages the default tip type for everyone.

Enables .gitignore /dist

Describe the bug
A clear and concise description of what the bug is.

Reported by a Discord user: The tips box is no longer visible in V9S2 (errors in console are possible)

Edit: this is caused by a module using Foundry Tips. We're still investigating which one is causing this to occur.

To Reproduce
Steps to reproduce the behavior:
???

Screenshots
If applicable, add screenshots to help explain your problem.
see comment

Other Diagnostic Info (please complete the following information):

• OS: all
• Browser if applicable: all
• FVTT Version: V9.245
• Foundry Tips Version: 21.05.03

Additional context
UPDATE: this is the module working as intended. See reply

@all-contributors please add @VanceCole and @Norc for ideas

Pretty sure this is system agnostic, not documented anywhere, and super handy.

Is your feature request related to a problem? Please describe.
It's currently unclear which module suggested a given tip. This might make it harder to figure out what's core functionality vs what comes from a tiny module you forgot you installed.

Describe the solution you'd like
Either inline with the tip or elsewhere, the tip source module name is written in the tip box.

Is your feature request related to a problem? Please describe.
It is unclear whether the steps in a tip describe a player action or a GM action.

Describe the solution you'd like
Tag each tip so that players and GMs who can and can't perform the action.

Describe the bug
Pictures speak a thousand words. Various UI elements are overlapping here. See the screenshots below.

To Reproduce
Steps to reproduce the behavior:

1. Have way too many modules that add buttons installed and enabled
2. Have another module such as Small Time installed and enabled
3. Enable Foundry A/V
4. Dismiss the player list

Expected behavior
Button UI should wrap back to the top
Modules should learn how to share this screen space
A/V webcam element should be kept to the right when there's a module in this corner and the player list is dismissed

Screenshots

Other Diagnostic Info (please complete the following information):
N/A

Additional context
There's some discussion in the League of Extraordinary Foundry VTT Devs about a potential library module, or allowing button-overflow to serve that purpose of "governing" this space.

• Screenshot
• Detailed description
• Contributing Guide
• • English Tips
• • Localization
• • Code

Possibly borrow the Discord syntax, eg :fa-lightbulb:

no other modules installed

Allows non-100% contributions to tips translations

Is your feature request related to a problem? Please describe.
Seeing a tip again after you've read it already is disappointing

Describe the solution you'd like
Each tip is marked as read when closed, and not re-shown until all of them have been shown once.
It's also possible tips never get re-shown period.

"You can configure a scene to have an Initial View Position that players see when they load in. However, if a player owns a token on that scene, their view will always be centered on their token instead."

I was today years old when Iearned this one myself (the second part).