vuestorefront / ecommerce-integration-boilerplate Goto Github PK

Expected Behavior

No response

Actual Behavior

After running yarn dev this warning will be shown in console print:

ERROR (node:28690) [DEP0128] DeprecationWarning: Invalid 'main' field in 'node_modules/@vue-storefront/nuxt-theme/package.json' of 'lib/module.js'. Please either fix that or report it to the module author
[dev:theme] (Use node --trace-deprecation ... to show where the warning was created)

Possible Solution

No response

Steps to reproduce

No response

What version of replace_me integration are you using?

any

What version of Node.js are you using?

any

What browser (and version) are you using?

any

What operating system (and version) are you using?

any

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Expected Behavior

No response

Actual Behavior

Possible Solution

No response

Steps to reproduce

No response

What version of replace_me integration are you using?

any

What version of Node.js are you using?

any

What browser (and version) are you using?

firefox

What operating system (and version) are you using?

any

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Expected Behavior

No response

Actual Behavior

Possible Solution

No response

Steps to reproduce

No response

What version of replace_me integration are you using?

any

What version of Node.js are you using?

any

What browser (and version) are you using?

any

What operating system (and version) are you using?

any

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

How the project can be improved?

The project will have the ability by default to use generated documentation from code.

What are the acceptance criteria?

The project should have auto-generated docs files.

Additional information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Expected Behavior

No response

Actual Behavior

1- The menu will not close when an item is clicked - on mobile

2- After clicking home in nav bar items, the menu items gets disappeared - on mobile
Steps to reproduce:
On mobile size -> open menu -> click on an item -> related category will be loaded (the menu is still open) -> now click on home in nav bar items -> menu items disappear

image:

Possible Solution

No response

Steps to reproduce

No response

What version of replace_me integration are you using?

any

What version of Node.js are you using?

any

What browser (and version) are you using?

any

What operating system (and version) are you using?

any

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Expected Behavior

yarn prepare linking $GIT_DIR/hooks to .husky when present

Actual Behavior

yarn prepare fails because .git is a file instead of a directory and still claims success

Possible Solution

use git rev-parse --git-dir instead of assuming .git/, and use negative logic instead of || true

diff --git a/package.json b/package.json
index 0235c08..a1a8e59 100644
--- a/package.json
+++ b/package.json
@@ -20,7 +20,7 @@
     "docs:dev": "cd docs && yarn dev",
     "docs:install": "cd docs && yarn",
     "lint": "eslint . --ext .ts,.vue",
-    "prepare": "[ -d '.husky' ] && (husky install && shx rm -rf .git/hooks && shx ln -s ../.husky .git/hooks) || true",
+    "prepare": "[ ! -d '.husky' ] || (GIT_DIR=$(git rev-parse --git-dir); husky install && shx rm -rf \"$GIT_DIR/hooks\" && shx ln -s $(realpath --relative-to=\"$GIT_DIR\" .husky) \"$GIT_DIR/hooks\")",
     "publish:api-client": "node ./scripts/publishApi.js",
     "publish:composables": "node ./scripts/publishComposable.js",
     "start": "cd packages/theme && yarn start",

unfortunately realpath doesn't seem to be available on macOS and I don't know how to handle that without making the script call way more complex.,,

Steps to reproduce

mkdir foo
cd foo
git init
git submodule add https://github.com/vuestorefront/ecommerce-integration-boilerplate
cd ecommerce-integration-boilerplate
yarn

What version of replace_me integration are you using?

9148bd7 (main's HEAD)

What version of Node.js are you using?

v16.13.1

What browser (and version) are you using?

None

What operating system (and version) are you using?

Ubuntu 21.10

Relevant log output

# BEFORE
#
$ yarn prepare
yarn run v1.22.17
$ set -x; [ -d '.husky' ] && (husky install && shx rm -rf .git/hooks && shx ln -s ../.husky .git/hooks) || true
+ [ -d .husky ]
+ husky install
husky - Git hooks installed
+ shx rm -rf .git/hooks
+ shx ln -s ../.husky .git/hooks
ln: ENOTDIR: not a directory, symlink '../.husky' -> '/home/amery/projects/go-nuxt/src/github.com/goshop-project/vuestorefront/.git/hooks'
+ true
Done in 0.19s.

# AFTER
#
$ yarn prepare
yarn run v1.22.17
$ set -x; [ ! -d '.husky' ] || (GIT_DIR=$(git rev-parse --git-dir); husky install && shx rm -rf "$GIT_DIR/hooks" && shx ln -s $(realpath --relative-to="$GIT_DIR" .husky) "$GIT_DIR/hooks")
+ [ ! -d .husky ]
+ git rev-parse --git-dir
+ GIT_DIR=/home/amery/projects/go-nuxt/.git/modules/src/github.com/goshop-project/vuestorefront
+ husky install
husky - Git hooks installed
+ shx rm -rf /home/amery/projects/go-nuxt/.git/modules/src/github.com/goshop-project/vuestorefront/hooks
+ realpath --relative-to=/home/amery/projects/go-nuxt/.git/modules/src/github.com/goshop-project/vuestorefront .husky
+ shx ln -s ../../../../../../src/github.com/goshop-project/vuestorefront/.husky /home/amery/projects/go-nuxt/.git/modules/src/github.com/goshop-project/vuestorefront/hooks
Done in 0.21s

Code of Conduct

• I agree to follow this project's Code of Conduct

When running yarn lint command, there are plenty of issues reported by eslint that should be fixed.

Once this is done, lint step in CI should be re-enabled: https://github.com/vuestorefront/ecommerce-integration-boilerplate/blob/master/.github/workflows/test.yml#L35-L55

Expected Behavior

when build and start ,the api url while add undefined
show step:

yarn build
yarn start

when do any api, the url will add undefined between domain and endpoint.

Actual Behavior

Possible Solution

No response

Steps to reproduce

No response

What version of replace_me integration are you using?

master

What version of Node.js are you using?

v16.15.1

What browser (and version) are you using?

chrome

What operating system (and version) are you using?

macOS

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct