vvo / analytics.js-loader

Asynchronously load segment.com analytics.js with an npm module

Hi there 👋

Maker

• TurnShift: Automate Your Team Schedule
• Tweets @vvoyer: JavaScript, React, Next.js, Building In Public
• Next.js News: The Next.js Monthly Newsletter (sold)
• Source Karma: Discover how people react to you on GitHub 👍 (archived)

analytics.js-loader's Issues

Doesn't Actually Send Data

I think this library doesn't actually do the right thing. Real issue being the goofy way Segment has done their JS. When the analytics script is loaded, it doesn't actually fix the initial window.analytics, it just replaces it, and the fact that this module exports a reference to the initial object, means that after the script is loaded, events aren't actually sent to Segment and tracked.

I could be wrong, but that is what I was observing.

Here is the module I created to fix this issue:

import loadAnalytics from 'analytics.js-loader';

/*
 * The analytics.js-loader module returns the "initial" analytics
 * object, which is basically just a queue to hold events until the
 * "real" one is loaded with a global script.  Problem is, the "real"
 * one simply replaces `window.analytics`, and doesn't change over
 * this initial "queue" object, meaning that nothing gets registered
 * after the "real" one is loaded - things just keep adding to the queue.
 * This is why we save off `initialAnalytics`, and then always run
 * methods through `window.analytics`, which might be the queue, and
 * might be the real one.
 */
const initialAnalytics = loadAnalytics({
    writeKey: 'KEY',
    skipPageCall: true
});
window.analytics = initialAnalytics;

const analytics = {};
_.each(initialAnalytics.methods, method => {
    analytics[method] = function() {
        return window.analytics[method].apply(window.analytics, arguments);
    };
});

export default analytics;

No data being sent

Continuing #6 ...

I am not seeing any data sent when using this package unless I remove the changes in 5871aa7

Is anyone else having this issue?

I was having an unrelated issue. The commit works great. Thank you.

Reset method missing

The analytics object returned by the loader should have the reset method.

Could call to analytics.page be conditional?

In the single page application I am working on we call analytics.page() whenever we render a new page. The issue is, on initial page load, this will be fired twice since it is also called at the end of index.js.

Could an option be passed to omit this call in case a consumer of this library wants to manually call it later?