vyznev / soup Goto Github PK

Sadly, SOUP seems to prevent Chatjax++ from loading. Could you fix this?

Thanks.

See https://meta.stackoverflow.com/questions/362554/why-are-the-chat-faq-in-almost-identical-links-different; the page tries to use $.curCSS() which is gone from jQuery.

Could S.O.U.P. provide a shim; (such as the one provided here)?

Firefox ESR here.

Per https://meta.stackexchange.com/a/332571/377214, mse322619 is now fixed in the SE engine. Please remove it from SOUP.

In Microsoft Edge, running the latest stable version of SOUP in Tampermonkey, the user avatars appear in the wrong spot, below where they should be:

Question where this screenshot was taken

When you opt-in to the new SO navigation (see https://meta.stackoverflow.com/questions/343103/help-test-the-new-top-nav-phase-3-testing-runs-this-week), the inbox and achievent boxes jump after ajax load completes:

Just to be clear: the box should not load empty in one location, then jump to another.

This only happens when SOUP is enabled in tampermonkey. When I disable SOUP, the boxes stay put.

Tested on macOS Sierra 10.12.2, Chrome 55.0.2883.95

http://stackapps.com/questions/4465/bookmarklet-to-show-deleted-messages-in-chat

Add a button to load deleted messages in chat for mods/room owners so that they can pick apart what happened.

It seems SOUP is affecting the comment boxes breaking the Enter key. With it enabled, pressing Enter to submit or edit a comment doesn't work, nothing happens. Disabling fixes the issue.

Perhaps a fix similar to the one for http://meta.stackexchange.com/a/285035 is needed. Michael mentions something about changes to the :visible selector.

SOUP 1.45.22 (via Tampermonkey 4.1.10)
Stack Overflow rev 2016.10.5.4036
Win 7 SP1
Chrome 53.0.2785.143

The site doesn't serve over HTTPS, so the link from election pages is broken when SOUP is active.

Can an exception be added for this or is that counter-productive?

I find the implementation of the placeholder text ("spoiler: hover/click to reveal") a bit unproductive. With SOUP enabled, I've to wait a bit longer to view what's inside the spoiler. First the placeholder text ("spoiler: hover/click to reveal") fades out, and only then the spoiler text fades in.

I am pretty sure that the time taken for the spoiler text to load is longer than it used to be without SOUP enabled. Is there a way to reduce the time to load spoiler text as it used to be originally (without SOUP)?

The mse90713 fix (which adds a warning to the close dialog on questions with active bounties indicating that they cannot be voted for closure) broke at some point, possibly due to SE design changes. (I can't pinpoint when exactly, since I've not run into a case where I've attempted to close a bountied question in a while.)

Today SE rolled out a change titled "Refactor post validation", causing the following error to appear in the console:

TypeError: StackExchange.postValidation.getSidebarPopupOptions is not a function -1:333:47
    <anonymous> https://stackoverflow.com/users/message/create/-1:333
    jQuery 3
    MarkdownEditor https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:2
    e https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:2
    t https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:3
    n https://cdn.sstatic.net/Js/full.en.js?v=1d06422f5fb7:4

This is from fixes.mso300679:

Unfortunately, this breaks the moderator-only 'contact user privately' feature, so I've had to disable S.O.U.P. altogether. This also breaks the WMD editor elsehwere, just not as completely; the editor is left in an unfinished state without buttons.

I recently encountered a bug when viewing a post with multiple pages of answers that a moderator had locked and deleted, which had helpful spam or rude/abusive flags.

When trying to navigate to a subsequent page of answers using the pagination link, or when trying to access a specific answer that happens to be on a page other than the first page, the server-side logic that automatically removes the question title from the URL (to prevent it from being exploited by spammers) also causes things like ?page=2 to be stripped out, making it impossible to view a subsequent page unless I manually modify the URL to remove the question title while leaving the query parameter intact.

I've posted a detailed answer showing the cause of the bug and the workaround.

It would be nice to have the fix in SOUP. I think it's reasonable because all that needs to be done is remove the question title from the pagination links for deleted posts. (The "Return to Answer" links may not be fixable, but still.)

With SOUP enabled, I am unable to comment on posts in SO Teams. I get the following console errors:

TypeError: str is undefined[Learn More] 160:505:4

Error: Syntax error, unrecognized expression: #post-editor-/c/moderators160 jquery.min.js:2:12733

The format of a Team URL is https://stackoverflow.com/c/(team name)/questions/### -- the "/c" is the special marker here.

I've locally modified the script to operate on stackoverflow.com/questions (as opposed to *) to bypass the problem -- not ideal, but I don't know how to do "@match all except this pattern".

mse307976 assumes that there is a $header whose .offset() returns an object with a .left property.

The page, as shown to me, has no such element (nor does it have $bar). A simple check like this should be added:

if ($header.length) {
  /* ... */
}

Could you include a patch to restore the previous structure of the tag popup (with links to tag wiki etc, optionally also removing the two big buttons the new styling brought in)? For active users in general (and mods in special), those tag-wiki links are way more important than subscribing to or ignoring tags, so I feel the current design a big step backwards. Reference on MSO: Restore previous variant of tag popup.

Thanks in advance!

The "hover / click to show spoiler" text on spoilers hasn't been working for quite a while now, probably because of SE changes a while ago. (I couldn't find which fix is the specific one for this, as there's only one that mentions spoilers in the list of fixes, and it's not related to this one.)

I recently filed mse341498, which reports that spoilers in user profiles don't continue to show when they are clicked, which contradicts the expected behavior for posts.

Can a client-side workaround for this please be implemented in SOUP?

It appears that the CSS-sniffing hack used to set the SOUP.isBeta flag (which in turn is user to determine the rep threshold for various privileges) does not work (at least) on Chrome 67, causing the flag to always be false.

Fortunately, the only fix currently (as of SOUP v1.52) using this flag is mse115702. Thus, the only visible effect of this breakage is that delete links may not appear when they should when downvoting an answer to -1 on a beta site for users with at least 4k but less than 20k rep.

In any case, with the advent of design-independent graduation, the whole idea of this flag has become fundamentally misguided. The proper fix would be to replace it with an SE API user privileges query. The tricky part here is that we want to minimize the number of API queries made, which implies at least heavy caching of the results (e.g. in LocalStorage) and probably also on-demand fetching (with its attendant asynchronous complications).

The API query implementation from the Bounty Bar user script could presumably be used as a basis for this. It's rather bare-bones, but it seems to work well enough.

soup-mse223737-link is redundant as SE already provides a <a href="https://stackexchange.com/users/USER_ID?tab=inbox">all items</a> to the right side of the Notification Inbox.

Screenshot:

Small bug, but I thought I'd mention it. Normally, the comments look like this:

However SOUP adds an extra space between the comment and the dash:

This causes the timestamps to shift a bit when the page loads.

A new "share" dialog was deployed that causes the current fix in the script to no longer work. Can it please be modified to work with the new one?

This breaks the new activity style. It should look like:

However it looks like this:

Removing the following style fixes this for me.

.question-summary .question-hyperlink {
  display: block;
}

As I'm sure you're aware, Greasemonkey 4, due to release with FF 57, is not backwards compatible. Scripts will need to be adapted.

Please document which of the following options for Greasemonkey <4 users will be open regarding SOUP:

1. SOUP will be ported to Greasemonkey 4.
2. SOUP will no longer be support Greasemonkey; use Tampermonkey (or...?).
3. SOUP will no longer be support Firefox as a userscript; use the browser extension.

Windows 7 Home Premium 64 bit, Firefox 49.0.1

SOUP 1.44.2

OK and Cancel not longer work when using CtrlL in the editor to enter a hyperlink.

The following error is generated:

Works fine if SOUP is disabled.

Consequence of We have updated jQuery to 1.12.4 - please report related bugs here?

When using this script along with SOUP in Microsoft Edge, the dropdown it adds to the page shows up twice (or used to until the author of that script added a workaround). Disabling SOUP fixes it.

I reported this to the developer of that script, who responded by implementing a workaround that explicitly prevents their script from loading twice and displays a console error message if it attempts to load twice. With SOUP disabled, I don't see this console message; with SOUP enabled, I do. This is still a bug, because the script shouldn't be attempting to load twice with SOUP enabled in the first place.

Also, according to that script's developer, the problem does not occur in Chrome, so it could be a bug in Edge or in the implementation of the Edge port of Tampermonkey. I reported this here to investigate if this is indeed a problem in SOUP or not, since disabling SOUP fixes the issue.

SE recently started deploying a new responsive design, but not all pages are responsive yet. Q&A is, but profiles and reviews aren't.

I recently noticed a problem with the top bar on those non-responsive pages and filed a bug report, but it turns out to be coming from something SOUP is doing. (I disabled user scripts one at a time until I found the one that introduced the change.) That bug report, with screen shots, is here: https://meta.stackexchange.com/q/311489/162102 . Basically, in a smaller window size (mine is 1036px wide), the right side of the top bar is clipped off only on these pages. On sites that don't have the responsive design yet (almost all of them) and responsive pages on SO and Meta.SE, the problem does not occur.

Eventually they're going to make everything responsive and presumably the problem will go away, but it's going to take them weeks to months to do that. Is there anything that can be done in the meantime? I have no idea how large or small an investigation/change this would be.

I really appreciate all the work you've put into SOUP! I'm sorry to come here asking for a fix instead of working it out and offering you a PR.

In case it matters, I'm using the userscript version, not the add-on.