w8r / l.control.linestringselect Goto Github PK

Hello,
Nice work!!! This is a really cool component !
But with Leaflet 1.3.1, i got an issue, can you help me ?

This is what my google console show me :
https://image.noelshack.com/fichiers/2018/20/4/1526566662-scene-1-2018-05-17-16-15-14.jpg

Hello,
Nice work!!! This is a really cool component. I am developing a custom map tool in Angular2/4 project and would like to include your tool. I am having issue getting it to load in my angular project (Typescript). Do you have any Typescript support or recommendations for type script support and including and using in an Angular2/4 project?

Thank you in advance.

It seems that this class would fit better under L.Handler, since it is enabled/disabled and uses markers (much like the Draw handlers), and isn't added to a control corner (like other L.Control types)

Is there a reason that this wasn't extended from L.Handler?

How would it be possible to set a starting point that doesn't move, and only allow the end handle to respond to drag events?
This would need blocking the swapping of start and end points to go only in one direction.

There is an issue with creating a selection from the lineString, I have used your demo to illustrate.
Grabbing the marker and pulling it past the end of the segment extends the marker itself out to the point where the cursor influences the base feature. This influence (in latitude and longitude) becomes greater as the map is zoomed out.

I increased the thickness of the base feature to illustrate the discrepancy between its end and the end of the selection which was achieved at a lower zoom level.

On a new reactjs project https://github.com/keyanyang/react-leaflet-webpack-boilerplate
npm install --save leaflet-linestring-select

I just add this lines in App.js

import { Map, TileLayer } from 'react-leaflet';
import Select from 'leaflet-linestring-select'

or

import { Map, TileLayer } from 'react-leaflet';
var Select = require('leaflet-linestring-select');

Uncaught Error: Cannot find module 'rbush'
    o http://localhost:8080/main.js?c2066d2489971b870df7:1666
    ./node_modules/leaflet-linestring-select/dist/L.Control.LineStringSelect.no-rbush.js/</</<[5]</<

On line : var Rbush = global.Rbush || require('rbush');

What I'm doing wrong ?

Hello @w8r @Oliv
there are no dist files in /dist directory. When I browse commit history, there was .min.js file in the past, for example here:
https://github.com/w8r/L.Control.LineStringSelect/blob/a3f16b868a0de130a9c81c0a323ea1ce00c275f8/dist/L.Control.LineStringSelect.min.js

I am wondering if this library work with closed line, Like Polygon exterior ring.

Please provide any reference or documentation in order to implement this great tool in typescript or angular.