Iframe bug with CodeMirror about ckeditor-textselection-plugin

[w8tcha]

can you post your editor config? and also can you post the content that is is added, or make a screen shot?

[larsinsd]

Ok - here are all the details. Let me know if you need anything else from me to help you fix it:

The error I'm finding only appears once I add the textselection plugin. As soon as I remove it, everything works great.

The problem is when you put <iframe src="anything"></iframe> in the source and then switch to HTML view and then back. You can see what happens because it looks like this:

<p><iframe src="http://www.google.com ">&lt;!--{cke_protected}{C}%3C!%2D%2Dcke_bookmark_99S%2D%2D%3E--&gt;&lt;!--{cke_protected}{C}%3C!%2D%2Dcke_bookmark_99E%2D%2D%3E--&gt;</iframe ></p>

(Note: I had to add the space after the http://www.google.com URL to make the code render the above correctly in Github)

These are all the plugins I have installed. I did a minimum install of CKEditor 4.3.1 and manually added these back in (yes, I know, a lot of extra work).

config.plugins = 'dialogui,dialog,floatpanel,a11yhelp,dialogadvtab,menubutton,basicstyles,stylescombo,bidi,blockquote,clipboard,button,panelbutton,panel,colorbutton,colordialog,templates,menu,contextmenu,div,resize,toolbar,elementspath,list,indent,indentblock,indentlist,enterkey,entities,popup,find,fakeobjects,flash,listblock,richcombo,font,forms,format,htmlwriter,horizontalrule,iframe,wysiwygarea,image,smiley,justify,link,liststyle,magicline,maximize,pagebreak,pastetext,pastefromword,preview,print,removeformat,save,selectall,showblocks,showborders,sourcedialog,specialchar,tab,table,tabletools,undo,onchange,htmlbuttons,codemirror,autogrow,tableresize,iframedialog,docprops,wsc,scayt,xml,ajax,placeholder,stylesheetparser,textselection';
config.skin = 'moonocolor';

And this is now I instantiate it:

var editor = CKEDITOR.replace('Notes',{ uiColor : '#d3e1f5', language : '$language' , width : '90%' , height : '300px' , autoGrow_minHeight: 300 , autoGrow_maxHeight : maxHeight , autoGrow_bottomSpace: 0 , autoGrow_onStartup : true , resize_dir : 'both' , resize_minHeight : 200 , dialog_backgroundCoverColor : '#d7e6f9' , dialog_backgroundCoverOpacity : 0.75 , colorButton_enableMore : true , tabSpaces : 5 , fullPage : false , autoUpdateElement : true , toolbarStartupExpanded : true , filebrowserImageUploadUrl : 'uploadImageToEditor.pl' , extraPlugins : 'simpleuploads,imageloader,tableresize,countdown,linker,articleloader,mailmerge,loadwiki,wordcount,doksoft_maps' , toolbar : [ ['Bold','Italic','Underline','Strike','-','Subscript','Superscript'] , ['NumberedList','BulletedList'], ['JustifyLeft','JustifyCenter','JustifyRight','JustifyBlock'] , ['Cut','Copy','Paste','PasteText','PasteFromWord'] , ['Undo','Redo'], ['Find','Replace','Scayt'] , '/', ['linker','Unlink','Anchor'] , ['Table','HorizontalRule','Smiley','SpecialChar'] , ['doksoft_maps'] , ['countdown'] , ['mailmerge'] , ['loadwiki'] , ['articleloader'] , ['imageloader'] , '/', ['Styles','Format','Font','FontSize'], ['TextColor','BGColor'], ['RemoveFormat','-','ShowBlocks'], ['Source'] ]});

[w8tcha]

Thanks iam able to reproduce looks like it only happens when the cursor is inside the iframe tags. then the ckeditor is adding the protected source code and encodes the content. But this is not an issue of the plugin. this is a bug in the editor

Try this.

1. Open the editor demo - http://ckeditor.com/demo
2. Switch to Source
3. Enter

<iframe src="http://google.de"><!-- Hello -->This is atest</iframe>

1. switch to wysiwyg mod and the content is changed to

<iframe src="http://google.de">&lt;!--{cke_protected}{C}%3C!%2D%2D%20Hello%20%2D%2D%3E--&gt;This is atest</iframe>

This should be reported in the ckeditor tracker not here. Sorry but i can't fixed that.

[larsinsd]

That is not my experience. It works fine without the TextSelection plugin enabled.

Now, I think you are right with leaving the cursor inside an iframe tagset and putting comment tags in there, but the cke_protected cke_bookmark_99 thing appears whenever you change from Source to WYSIWYG to Source regardless of where the cursor is.

[w8tcha]

I reported this issue on the CKEditor bug tracker

https://dev.ckeditor.com/ticket/11442

I closed the issue because this is nothing i can fix from my plugin.