walktalkchalk / tabstache Goto Github PK

I'd love a PR to refactor the code a bit to make the code more readable and testable. Moving chrome extension functionality out of the event handler and calling those functions might be a good place to start.

In situations with several tabs (15-20) not all tabs are closed and saved to the stash. I think this might be a threading issue between the bookmarking and the closing.

I wanted to check if I can help with issue #4 (yes, Hacktoberfest :) ).
So, first I wanted to check how it works, but when I tried to create new stache, it didn't worked(only created new tab).
Quick check at console shows that at start it throw error:

Error in response to bookmarks.getTree: ReferenceError: otherBookmarksID is not defined
    at chrome.bookmarks.getTree [as callback] (chrome-extension://cbpangmphioghangmilmccnjcgahlcdc/popup.js:13:28)
    at chrome.bookmarks.search [as callback] (chrome-extension://cbpangmphioghangmilmccnjcgahlcdc/popup.js:12:24)

It looks like it won't work if there is no TabStache_base folder in bookmarks. I will make PR with quick fix.

To allow for quickly loading and unloading a save the name of an unloaded stash and use it as the default name for the next stash. This should be cleared out when a new stash is made.

Currently some of tabs are ignored, but it's hardcoded.
I thinks it will be good to allow to configure list of ignored addresses (option page probably needed).
Also option to choose if ignored tabs should be closed or not.

ability to somehow share a stache with someone else who has tabStache

Add a + button to the tabs list that will allow the user to add the currently open tabs to the associated tab list. This should function similarly to the new stash functionality (ignored tabs, close stashed tabs).

Concerns:
It might be easy for a user to open a stash instead for appending. A little dead (non-clickable) space between the + and name would be appropriate.

Add the ability to import/export a stash from/to a text file. This would allow you to build a stash and archive all the links in the stash. This could be useful for easily storing and accessing the domain knowledge required to make a change or document the reasoning for a design decision.

When storing a stache, ignore common tabs that would likely be duplicates (about:blank, extensions, apps, ...)

Add a couple Automated User Tests to verify functionality. Can chrome be fired up with an unpacked extension installed? Open a few tabs, Stash them, verify the bookmarks and the tabs went away, unstash the tabs, verify the tabs have been restored.

Currently it is possible to create empty stache

Looking for some updates on improving the face of the extension before releasing to as an "official" extension.

This was first written when I was still new at JS. The code could use some cleanup. (for loops?). Please submit PRs in smaller chunks.