wangshengjia / leego

Declarative, configurable & highly reusable UI development as making Lego bricks.

Yo 👋 I'm victor.

Having coffee at Citymapper, keep learning.

Startup, tech, product, food. Talk to me.

Living in London, regularly back to Paris and Shanghai.

• 📚 Learning
• 🏗 Building
• 🍜 Ramen!
• 💻 写代码，但是更爱做产品
• 💀 啊 程序员之耻!

Have fun.

leego's Issues

Implement Encodable & Decodable for configuration

Configuration <-> Json Format

Refactor Layout to use declarative NSLayoutAnchor

With the NSLayoutAnchor, we can now use it to avoid the layout format language. Imagine, in your function that defines layout, we could pass the view and return an array of objects. Like this:

let title = "title".build(UILabel.self).style([.numberOfLines(0), .text("test")])
let subtitle = "subtitle".build(UILabel.self).style([.numberOfLines(0), .text("subtitle")])

let brick = "details".build().bricks(title) { container, title in
    return [
        title.centerXAnchor.constraint(equalTo: container.centerXAnchor),
        title.centerYAnchor.constraint(equalTo: container.centerYAnchor),
    ]
}

However, this approach will require some refactoring. I can volunteer, if you want :)

Fix NSAttributedString bug

Component configuration need a default value

Need a way to handle component's action

Build with CI

TravisCI, CircleCI or Codecov.io

Compatible with Cocoapods & Carthage

Debug mode

Manipulate components and layout in a functional way

components.map { component1, component2 in
  // manipulate styles
 }.reduce {
  // reduce to single component with layout
}.compose { 
  // ... 
}.bind {}

Support Behaviours ?

http://objc.io/issues/13-architecture/behaviors/

Need to remove old style when apply diff style

Already begin, need to be finished

Brick.bricks field shares ambiguous name with methods.

In Xcode 9.4.1 (Swift 4.1.2) if you try to get the child bricks for a Brick instance, the compiler complains: Ambiguous reference to member 'bricks(_:layout:)'

Example (using code from DetailsViewController in the Demo App):

let title = "title".build(UILabel.self).style([.numberOfLines(0), .text("Lorem Ipsum is simply dummy text of the printing industry")])
let description = "description".build(UILabel.self).style([.textColor(UIColor.lightGray), .numberOfLines(0), .font(UIFont.systemFont(ofSize: 14)), .text("Lorem Ipsum has been the industry's standard dummy text ever since the 1500s")])
let redBlock = "red".build().style(Style.redBlockStyle)
let greenBlock = "green".build().style(Style.greenBlockStyle)
let blueBlock = "blue".build(UIImageView.self).style(Style.blueBlockStyle + [Appearance.custom(["shadowColor": UIColor.brown, "shadowOpacity": Float(1.0)])])

let blocks = Brick.union("blocks", bricks: [
    redBlock.height(50),
    greenBlock.height(80),
    blueBlock.height(30)],
    axis: .horizontal, align: .top, distribution: .fillEqually, metrics: LayoutMetrics(10, 10, 10, 10, 10, 10)).style(Style.blocksStyle)

Then call add the line:

print(blocks.blocks.count) //Generates compiler error: Ambiguous reference to member 'bricks(_:layout:)'

Handle UIScrollView with auto layout

https://developer.apple.com/library/ios/technotes/tn2154/_index.html

Handle custom errors

Handle cell's auto calculating height in a better way

• Handle better manual calculating height API
• Support both UITableView & UICollectionView
• Height cache mechanism

LeeGo on Swift 3.0

Handle custom init

ex: UIButton(type: .Custom)

All value type object or model objects should conform Equatable & Printable

Add convenience methods for auto layout

Handle better when dealing with UIScrollView

Keep the coherence between: configuration, sub configuration AND view's attributes, subview's attributes

Add UIStackView inspired convenience methods

Such as arrangedComponents(components: [Component], flowDirection: Direction)

Need a way to alternatively calculate cell's height or whole layout manually to get better performance

Travis CI configuration needs to be updated

When making a pull request, the following error is generated by Travis CI and the build fails:
❌ “Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

Need to rename some objects

Ex: ComponentTarget or Configuration ??

Be able to show/hide one of the component with or without animation

Be able to show/hide one of the component (and its relevant margin layout) with or without animation.

Some inspirations
https://github.com/forkingdog/UIView-FDCollapsibleConstraints

Sample project, show the suit case and potential power of LeeGo

Le Monde, Twitter, NYT, Airbnb, LinkedIn, Weibo, Zhihu

Should be able to init from custom initializer ?

Apply configuration with only diff part

Need a way to find diff parts between two configurations. How to deal with auto layout?

Need to be thread safe ?

Add Z index to component ?

Mixed view components

Hello Wang,

Nice work there, congrats! I was playing around w/ Leego for some time and wondering what's the best approach to integrate e.g. UICollectionView inside table view cell (for carousal) and may be some dynamic image carousals mixed w/ static cells.

Built-in components, layouts or some kind of `Theme`

• UIStackview like layout
• Separator: 0.5pt line with color
• Sticky header view

Handle several components with same name, typical case is "Separator"

How ?

Are the explicit types in the README there deliberately?

eg.

import LeeGo

let titleBrick: Brick = "title".build(UILabel).style([.text("Showcase"), .backgroundColor(UIColor.lightGrayColor())])

could become

import LeeGo

let titleBrick: Brick = "title".build(UILabel).style([.text("Showcase"), .backgroundColor(.lightGrayColor())])

and

let bricks = ["red".build().style(Style.redBlockStyle).height(50),
 "green".build().style(Style.greenBlockStyle).height(80),
 "blue".build().style(Style.blueBlockStyle).height(30)]

let layout = Layout(bricks: bricks, axis: .Horizontal, align: .Top, distribution: .FillEqually, metrics: LayoutMetrics(10, 10, 10, 10, 10, 10))
let viewBrick = "view".build().style(Style.blocksStyle).bricks(bricks, layout: layout).height(100)

could become

let bricks = ["red".build().style(.redBlockStyle).height(50),
 "green".build().style(.greenBlockStyle).height(80),
 "blue".build().style(.blueBlockStyle).height(30)]

let layout = Layout(bricks: bricks, axis: .Horizontal, align: .Top, distribution: .FillEqually, metrics: LayoutMetrics(10, 10, 10, 10, 10, 10))
let viewBrick = "view".build().style(.blocksStyle).bricks(bricks, layout: layout).height(100)

But I understand if this was done intentionally; it is clearer and more easily readable (?) in the examples.

If this wasn't done deliberately, I'd gladly help using implicit type inference. :)

Documentations

Component Action

Hi Wang,

Congrats on the great tool, nicely done !! I was wondering what's your plan for providing actions for components, like Button, swipe, tap, or anything? Blockable actions?

Best way to handle responsive configuration

Brick.bricks is not publicly accessible

It would be nice to iterate over the child bricks like so:

  func update(_ targetView: UIView, with brick: Brick) {
        for child in brick.bricks {
            switch targetView {
            case let label as UILabel where brick == FooBrickBuilder.name:
                label.text = name
            case let label as UILabel where brick == FooBrickBuilder.address:
                label.text = address
            default:
                break
            }
        }
    }

Code Coverage 85%+

Support view style with layer properties

ex: cornerRadius, borderWidth, borderColor, etc ...

Add unit tests

Directly configure a view in nib file with custom attributes

LeeGo on Swift 2.3

Move LeeGo to adapt Swift 2.3

Add prefix to all extension methods which based on NSObject

Swift 3.0 style API (Breaking change)