waxtell / serilog.sanitizer Goto Github PK

Describe the bug
It seems that the latest version (preview version) is not working anymore in .NET Framework 4.7.2.
The strong named preview seemed to be working last year, in May, when we tested it, but we waited for a official release to add it to our projects.

To Reproduce
Steps to reproduce the behavior:

1. Create new ASP.NET web application (from VS sample)
2. Add the Serilog.Sanitizer package 1.3.1 (or alpha)
3. Run the application from VS (or publish in IIS)
4. Access the application.
5. The following stack trace will appear:

[FileLoadException: Could not load file or assembly 'Serilog.Sanitizer' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)]

[FileLoadException: Could not load file or assembly 'Serilog.Sanitizer, Version=1.3.1.0, Culture=neutral, PublicKeyToken=ea6723327de9b476' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)]
System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) +0
System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) +232
System.Reflection.RuntimeAssembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean forIntrospection) +113
System.Reflection.RuntimeAssembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection) +23
System.Reflection.Assembly.Load(String assemblyString) +35
System.Web.Configuration.CompilationSection.LoadAssemblyHelper(String assemblyName, Boolean starDirective) +49

[ConfigurationErrorsException: Could not load file or assembly 'Serilog.Sanitizer, Version=1.3.1.0, Culture=neutral, PublicKeyToken=ea6723327de9b476' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)]
System.Web.Configuration.CompilationSection.LoadAssemblyHelper(String assemblyName, Boolean starDirective) +762
System.Web.Configuration.CompilationSection.LoadAllAssembliesFromAppDomainBinDirectory() +259
System.Web.Configuration.CompilationSection.LoadAssembly(AssemblyInfo ai) +167
System.Web.Compilation.BuildManager.GetReferencedAssemblies(CompilationSection compConfig) +238
System.Web.Compilation.BuildManager.GetPreStartInitMethodsFromReferencedAssemblies() +78
System.Web.Compilation.BuildManager.CallPreStartInitMethods(String preStartInitListPath, Boolean& isRefAssemblyLoaded) +334
System.Web.Compilation.BuildManager.ExecutePreAppStart() +178
System.Web.Hosting.HostingEnvironment.Initialize(ApplicationManager appManager, IApplicationHost appHost, IConfigMapPathFactory configMapPathFactory, HostingEnvironmentParameters hostingParameters, PolicyLevel policyLevel, Exception appDomainCreationException) +746

[HttpException (0x80004005): Could not load file or assembly 'Serilog.Sanitizer, Version=1.3.1.0, Culture=neutral, PublicKeyToken=ea6723327de9b476' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)]
System.Web.HttpRuntime.FirstRequestInit(HttpContext context) +552
System.Web.HttpRuntime.EnsureFirstRequestInit(HttpContext context) +122
System.Web.HttpRuntime.ProcessRequestNotificationPrivate(IIS7WorkerRequest wr, HttpContext context) +737

Expected behavior
There is no error on assembly loading

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Chrome
• Version: 1.3.1

Additional context
Our .NET Core / NET 6 apps seems to work properly, however our ASP.NET APIs raise the above error when accessed

We have an internal rule in the company that all our assemblies need to have strong names.

When using the assembly "Serilog.Sanitizer.dll" from this nuget package, we have an issue in a .Net Framework project that the referenced assembly is not strong named.

According to this article, this issue does not occur in .Net Core projects and occurs only in .Net Framework projects due to strict assembly loading.

I would like to ask you if you could provide an assembly with a strong name for this nuget package so that also .net framework projects which require a strong name key to use this nuget package?

Thank you!