wayfapper / website Goto Github PK

Function addParam has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

https://codeclimate.com/github/Wayfapper/website/public/js/map.js#issue_608efa36d3496f000100003b

Add S2-Cells
displayed on map
calculated in php & stored in the db

Describe the feature you'd like
Wayfapper/UserScript#80

CodeFactor found an issue: Trailing spaces

It's currently on:
config\services.yaml:9
Commit a238a14

see https://scrutinizer-ci.com/g/Wayfapper/website/inspections/ae40406c-7778-464f-9010-b5927992896c/issues/files/src/Controller/MapController.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=46429574#inspectioncomment-169297848

Describe the bug
Status falsly changed from stage 2 or 3 back to stage 1 and then back to the correct status, this forced several notifications that are unnecessary

To Reproduce
Steps to reproduce the behavior:

1. wait till Nia f*cks up again
2. subimt false status

Expected behavior
sanitize status submitted by userscript and only alow unidirectional stagechanges

Screenshots

If applicable, add screenshots to help explain your problem.

Browser (please complete the following information):
doesn't matter

Additional context
happend 2021-04-21

Describe the bug

Missing semicolon.
Jshint (reported by Codacy)

This option suppresses warnings about missing semicolons. There is a lot
of FUD about semicolon spread by quite a few people in the community.
The common myths are that semicolons are required all the time (they are
not) and that they are unreliable. JavaScript has rules about semicolons
which are followed by all browsers so it is up to you to decide
whether you should or should not use semicolons in your code.
For more information about semicolons in JavaScript read An Open Letter
to JavaScript Leaders Regarding
Semicolons
by Isaac Schlueter and JavaScript Semicolon
Insertion.

To Reproduce
go to security tab

Expected behavior
:-)

Additional context
First appeared in commit 991bfd6 4 days ago @Un1matr1x
Merge 949291d into b931f85 991bfd6
/public/js/map.js#L47 on #89
Appeared in branch #89 4 days ago
Codacy Security Scan #147: Commit 991bfd6
Appeared in branch main 22 hours ago
Codacy Security Scan #165: Commit ed13c44