wdm0006 / cookiecutter-pipproject Goto Github PK

My surname contains an apostrophe.
The setup.py template uses this without escaping:

author='{{cookiecutter.full_name}}',

This leads to a SytaxError when I try to make use of setup.py:

python setup.py develop
File "setup.py", line 36
author='Dan O'Huiginn',
^
SyntaxError: invalid syntax

It looks like the same is true of all the other data included in setup.py

I looked around at how other cookiecutters handle this. Most don't, but the least-bad was:
cookiecutter-pypackage:

author="{{ cookiecutter.full_name.replace('"', '\"') }}",

In setup.py the following statement:

dependency_links = [x.strip().replace('git+', '') for x in all_reqs if 'git+' not in x]

seems contradictory. If the list has no items with 'git+' in them why bother to replace 'git+' with ''?

i.e. the 'not' is incorrect. Should it also not be x.startswith('git+')?

We should probably have one test example in this template.

Running pytest on it fails (collected 0 items -> return status 5) because there is actually no test...

There is a typo in setup.py, line 38. depedency was misspelt.
depedency_links=dependency_links should be dependency_links=dependency_links

http://www.willmcginnis.com/2015/11/12/create-a-pip-installable-python-package-in-2-minutes/

I think it would be nice to have a manual or instruction file on how to use and what do the different files do, well, at least some links to get started