weavejester / compojure-template Goto Github PK

Clojure should be updated to 1.7.

Hi,

I just tried creating a new compojure project from the template:

$ lein new compojure project-name
Retrieving compojure/lein-template/0.4.5/lein-template-0.4.5.pom from clojars
Retrieving compojure/lein-template/0.4.5/lein-template-0.4.5.jar from clojars

and then received the following error:

$ lein ring server
Could not find artifact javax.servlet:servlet-api:jar:3.1.0 in central (https://repo1.maven.org/maven2/)
Could not find artifact javax.servlet:servlet-api:jar:3.1.0 in clojars (https://repo.clojars.org/)
This could be due to a typo in :dependencies, file system permissions, or network issues.
If you are behind a proxy, try setting the 'http_proxy' environment variable.

I resolved it by updating the dependency in project.clj to:
[javax.servlet/javax.servlet-api "3.1.0"]

I'm new to the clojure ecosystem and noticed that the compojure.handler is being deprecated, yet the compojure template is still utilizing the handler ns (at least in my last run of lein new compojure appname). I think it would be a good idea to transition the template to the ring-defaults as suggested in the compojure.handler deprecation warning.

I'd also like to volunteer to help fix this issue if you think it would be worth while.

I was just having a problem with Clostache not being able to open a "templates/foo.html" file after creating a lein new compojure myproj project.

The exception I was getting was: "java.lang.IllegalArgumentException: No implementation of method: :make-reader of protocol: #'clojure.java.io/IOFactory found for class: nil". I didn't know what to make of that.

xeqi was able to figure out the problem: instead of "myproj/templates/foo.html", I needed to change it to "myproj/resources/templates/foo.html".

If this sort of exception is not uncommon for other compojure users (using other libraries requiring resources), it might be helpful to nudge them in the right direction by creating a resources directory for them in the project directory.

When creating a new project from this template an then running lein ring serverfails for me. See the console output I got:

paul@yoda ~/Projects/clojure
○ % lein new compojure compojure
Retrieving compojure/lein-template/0.1.3/lein-template-0.1.3.pom from clojars
Retrieving compojure/lein-template/0.1.4/lein-template-0.1.4.pom from clojars
Retrieving compojure/lein-template/0.2.0-SNAPSHOT/lein-template-0.2.0-20120714.174736-2.pom from clojars
Retrieving leinjacker/leinjacker/0.2.0-SNAPSHOT/leinjacker-0.2.0-20120707.115904-1.pom from clojars
Retrieving trammel/trammel/0.7.0/trammel-0.7.0.pom from clojars
Retrieving org/clojure/clojure/1.3.0/clojure-1.3.0.pom from central
Retrieving thneed/thneed/1.0.0-SNAPSHOT/thneed-1.0.0-20120330.013054-1.pom from clojars
Retrieving compojure/lein-template/0.2.0/lein-template-0.2.0.pom from clojars
Retrieving leinjacker/leinjacker/0.2.0/leinjacker-0.2.0.pom from clojars
Retrieving compojure/lein-template/0.2.1/lein-template-0.2.1.pom from clojars
Retrieving compojure/lein-template/0.2.2/lein-template-0.2.2.pom from clojars
Retrieving compojure/lein-template/0.2.3/lein-template-0.2.3.pom from clojars
Retrieving compojure/lein-template/0.2.4/lein-template-0.2.4.pom from clojars
Retrieving leinjacker/leinjacker/0.4.1/leinjacker-0.4.1.pom from clojars
Retrieving org/clojure/core.contracts/0.0.1/core.contracts-0.0.1.pom from central
Retrieving org/clojure/core.unify/0.5.3/core.unify-0.5.3.pom from central
Retrieving compojure/lein-template/0.2.5/lein-template-0.2.5.pom from clojars
Retrieving compojure/lein-template/0.2.5/lein-template-0.2.5.jar from clojars
Retrieving org/clojure/core.unify/0.5.3/core.unify-0.5.3.jar from central
Retrieving org/clojure/core.contracts/0.0.1/core.contracts-0.0.1.jar from central
Retrieving leinjacker/leinjacker/0.4.1/leinjacker-0.4.1.jar from clojars

paul@yoda ~/Projects/clojure
○ % cd compojure

paul@yoda ~/Projects/clojure/compojure
○ % lein ring server
Retrieving lein-ring/lein-ring/0.8.0/lein-ring-0.8.0.pom from clojars
Retrieving org/clojure/data.xml/0.0.6/data.xml-0.0.6.pom from central
Retrieving org/clojure/pom.contrib/0.0.25/pom.contrib-0.0.25.pom from central
Retrieving org/clojure/data.xml/0.0.6/data.xml-0.0.6.jar from central
Retrieving lein-ring/lein-ring/0.8.0/lein-ring-0.8.0.jar from clojars
Retrieving ring-server/ring-server/0.2.5/ring-server-0.2.5.pom from clojars
Retrieving org/clojure/core.incubator/0.1.0/core.incubator-0.1.0.pom from central
Retrieving org/clojure/pom.contrib/0.0.20/pom.contrib-0.0.20.pom from central
Retrieving org/clojure/clojure/1.3.0-alpha5/clojure-1.3.0-alpha5.pom from central
Retrieving ring/ring/1.1.4/ring-1.1.4.pom from clojars
Retrieving ring/ring-core/1.1.4/ring-core-1.1.4.pom from clojars
Retrieving ring/ring-devel/1.1.4/ring-devel-1.1.4.pom from clojars
Retrieving hiccup/hiccup/1.0.0/hiccup-1.0.0.pom from clojars
Retrieving clj-stacktrace/clj-stacktrace/0.2.4/clj-stacktrace-0.2.4.pom from clojars
Retrieving ns-tracker/ns-tracker/0.1.2/ns-tracker-0.1.2.pom from clojars
Retrieving org/clojure/tools.namespace/0.1.3/tools.namespace-0.1.3.pom from central
Retrieving org/clojure/java.classpath/0.1.1/java.classpath-0.1.1.pom from central
Retrieving org/clojure/java.classpath/0.2.0/java.classpath-0.2.0.pom from central
Retrieving org/clojure/pom.contrib/0.0.21/pom.contrib-0.0.21.pom from central
Retrieving org/clojure/clojure/1.3.0-alpha6/clojure-1.3.0-alpha6.pom from central
Retrieving ring/ring-jetty-adapter/1.1.4/ring-jetty-adapter-1.1.4.pom from clojars
Retrieving ring/ring-servlet/1.1.4/ring-servlet-1.1.4.pom from clojars
Retrieving ring-refresh/ring-refresh/0.1.1/ring-refresh-0.1.1.pom from clojars
Retrieving watchtower/watchtower/0.1.1/watchtower-0.1.1.pom from clojars
Retrieving compojure/compojure/1.0.4/compojure-1.0.4.pom from clojars
Retrieving org/clojure/tools.macro/0.1.0/tools.macro-0.1.0.pom from central
Retrieving clout/clout/1.0.1/clout-1.0.1.pom from clojars
Retrieving compojure/compojure/1.1.5/compojure-1.1.5.pom from clojars
Retrieving ring/ring-core/1.1.7/ring-core-1.1.7.pom from clojars
Retrieving ring-mock/ring-mock/0.1.3/ring-mock-0.1.3.pom from clojars
Retrieving org/clojure/core.incubator/0.1.0/core.incubator-0.1.0.jar from central
Retrieving org/clojure/tools.namespace/0.1.3/tools.namespace-0.1.3.jar from central
Retrieving org/clojure/java.classpath/0.2.0/java.classpath-0.2.0.jar from central
Retrieving org/clojure/tools.macro/0.1.0/tools.macro-0.1.0.jar from central
Retrieving ring-server/ring-server/0.2.5/ring-server-0.2.5.jar from clojars
Retrieving clj-stacktrace/clj-stacktrace/0.2.4/clj-stacktrace-0.2.4.jar from clojars
Retrieving ns-tracker/ns-tracker/0.1.2/ns-tracker-0.1.2.jar from clojars
Retrieving ring/ring-servlet/1.1.4/ring-servlet-1.1.4.jar from clojars
Retrieving ring/ring-devel/1.1.4/ring-devel-1.1.4.jar from clojars
Retrieving ring/ring/1.1.4/ring-1.1.4.jar from clojars
Retrieving ring/ring-jetty-adapter/1.1.4/ring-jetty-adapter-1.1.4.jar from clojars
Retrieving ring-refresh/ring-refresh/0.1.1/ring-refresh-0.1.1.jar from clojars
Retrieving watchtower/watchtower/0.1.1/watchtower-0.1.1.jar from clojars
Retrieving compojure/compojure/1.1.5/compojure-1.1.5.jar from clojars
Retrieving clout/clout/1.0.1/clout-1.0.1.jar from clojars
Retrieving ring/ring-core/1.1.7/ring-core-1.1.7.jar from clojars
Retrieving ring-mock/ring-mock/0.1.3/ring-mock-0.1.3.jar from clojars
Retrieving hiccup/hiccup/1.0.0/hiccup-1.0.0.jar from clojars
Exception in thread "main" java.lang.RuntimeException: No such var: handler/site, compiling:(compojure/handler.clj:11)
at clojure.lang.Compiler.analyze(Compiler.java:6281)
at clojure.lang.Compiler.analyze(Compiler.java:6223)
at clojure.lang.Compiler$InvokeExpr.parse(Compiler.java:3497)
at clojure.lang.Compiler.analyzeSeq(Compiler.java:6457)
at clojure.lang.Compiler.analyze(Compiler.java:6262)
at clojure.lang.Compiler.access$100(Compiler.java:37)
at clojure.lang.Compiler$DefExpr$Parser.parse(Compiler.java:518)
at clojure.lang.Compiler.analyzeSeq(Compiler.java:6455)
at clojure.lang.Compiler.analyze(Compiler.java:6262)
at clojure.lang.Compiler.analyze(Compiler.java:6223)
at clojure.lang.Compiler.eval(Compiler.java:6515)
at clojure.lang.Compiler.load(Compiler.java:6952)
at clojure.lang.RT.loadResourceScript(RT.java:359)
at clojure.lang.RT.loadResourceScript(RT.java:350)
at clojure.lang.RT.load(RT.java:429)
at clojure.lang.RT.load(RT.java:400)
at clojure.core$load$fn__4890.invoke(core.clj:5415)
at clojure.core$load.doInvoke(core.clj:5414)
at clojure.lang.RestFn.invoke(RestFn.java:408)
at clojure.core$load_one.invoke(core.clj:5227)
at clojure.core$load_lib.doInvoke(core.clj:5264)
at clojure.lang.RestFn.applyTo(RestFn.java:142)
at clojure.core$apply.invoke(core.clj:603)
at clojure.core$load_libs.doInvoke(core.clj:5298)
at clojure.lang.RestFn.applyTo(RestFn.java:137)
at clojure.core$apply.invoke(core.clj:603)
at clojure.core$require.doInvoke(core.clj:5381)
at clojure.lang.RestFn.invoke(RestFn.java:421)
at user$eval1.invoke(NO_SOURCE_FILE:1)
at clojure.lang.Compiler.eval(Compiler.java:6511)
at clojure.lang.Compiler.eval(Compiler.java:6500)
at clojure.lang.Compiler.eval(Compiler.java:6477)
at clojure.core$eval.invoke(core.clj:2797)
at clojure.main$eval_opt.invoke(main.clj:297)
at clojure.main$initialize.invoke(main.clj:316)
at clojure.main$null_opt.invoke(main.clj:349)
at clojure.main$main.doInvoke(main.clj:427)
at clojure.lang.RestFn.invoke(RestFn.java:421)
at clojure.lang.Var.invoke(Var.java:419)
at clojure.lang.AFn.applyToHelper(AFn.java:163)
at clojure.lang.Var.applyTo(Var.java:532)
at clojure.main.main(main.java:37)
Caused by: java.lang.RuntimeException: No such var: handler/site
at clojure.lang.Util.runtimeException(Util.java:170)
at clojure.lang.Compiler.resolveIn(Compiler.java:6740)
at clojure.lang.Compiler.resolve(Compiler.java:6710)
at clojure.lang.Compiler.analyzeSymbol(Compiler.java:6671)
at clojure.lang.Compiler.analyze(Compiler.java:6244)
... 41 more
Subprocess failed

Hi,

the change to use wrap-defaults adds an anti-request-forgery wrapper. This is very cool stuff for websites but not for REST services. Interacting with curl becomes a nightmare.

If you see the focus on websites, than I would volunteer to provide a template for REST services.