GithubHelp home page GithubHelp logo

[Bug]: Bundle Analyzer issue about rspack HOT 8 CLOSED

elsassph avatar elsassph commented on June 24, 2024
[Bug]: Bundle Analyzer issue

from rspack.

Comments (8)

elsassph avatar elsassph commented on June 24, 2024 1

@LingyuCoder the screenshot was comparing only Rspack versions, you can ignore the Webpack configuration - sorry if this is causing confusion.
The issue is that bundle analizer report has "regressed" between 0.6.x and 0.7.x.

from rspack.

LingyuCoder avatar LingyuCoder commented on June 24, 2024 1

@LingyuCoder the screenshot was comparing only Rspack versions, you can ignore the Webpack configuration - sorry if this is causing confusion. The issue is that bundle analizer report has "regressed" between 0.6.x and 0.7.x.

In rspack 0.6.x, all module were wrapped in webpack_modules so that webpack-bundler-analyzer can easily parse the bundle artifact and get modules.

Rspack 0.7.x extract the entry module into bootstrap, which aligned with webpack, and then the bundle analyzer can not parse it without module.depth (0 means entry module). And also, lots of modules are concatenated into entry module, so they are lost in parsed viewer.

from rspack.

LingyuCoder avatar LingyuCoder commented on June 24, 2024

Unable to run your repro. There is no rule for jsx files in rspack.config.js. However, there are jsx files inside @lightningjs/solid/dist/source/components.

from rspack.

elsassph avatar elsassph commented on June 24, 2024

@LingyuCoder thanks for checking - I indeed had a patched @lightningjs/solid library so I pushed a change to ignore that for now (BTW the nasty "panic" error still happens with a JSX rule). The issue reported now appears with a clean checkout.

from rspack.

LingyuCoder avatar LingyuCoder commented on June 24, 2024

@LingyuCoder thanks for checking - I indeed had a patched @lightningjs/solid library so I pushed a change to ignore that for now (BTW the nasty "panic" error still happens with a JSX rule). The issue reported now appears with a clean checkout.

Panic should has been fixed by #6778.

In your repro, webpack uses ts-loader and rspack uses builtin:swc-loader. Helpers of swc-loader are required as commonjs modules so that they can not be full concatenated. Use swc-loader in webpack is just the same.

But rspack does not support nestedModules and depth in stats, which is used to drill-down analysis of concatenated modules. I will add them in #6784.

from rspack.

elsassph avatar elsassph commented on June 24, 2024

Thanks, does that mean that we need to specify a stats module depth in the rspack config? or will that "just work" now?

from rspack.

LingyuCoder avatar LingyuCoder commented on June 24, 2024

The stats module depth has been supported by #6784. I test your repro and rspack --analyze works well. You can wait for the latest nightly version, and we will release it later today.

You can use stats.depth: true and stats.modules: true or use stats.all: true directly to enable the stats module depth.

from rspack.

elsassph avatar elsassph commented on June 24, 2024

Cool, no urgency.

from rspack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.