GithubHelp home page GithubHelp logo

Comments (5)

rubys avatar rubys commented on May 19, 2024

I'm OK with this change

from wpt.

annevk avatar annevk commented on May 19, 2024

@domenic @jasnell what do you think? Making urltestdata.json reflect URL records might be somewhat better than having it reflect the JavaScript API.

from wpt.

annevk avatar annevk commented on May 19, 2024

(That might also make it easier to omit fields that have their default value?)

from wpt.

domenic avatar domenic commented on May 19, 2024

Strong -1 from me. Being able to do simple assert_equals against the public API is what makes this a valuable way of testing the public API. If we start reconstructing the expected values from the JSON plus added test-specific logic, that'd be a big step backward to the old days where urltestdata just contained URL strings and the tests had to have their own mini-parser to reconstruct the expected values.

from wpt.

annevk avatar annevk commented on May 19, 2024

Okay, not a hill I'm dying on.

from wpt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.