set_dirty is using unspecified behaviour in html/semantics/forms/constraints/support/validator.js about wpt

[mnoorenberghe]

Note that this issue was noticed in some other parts of the commit which added these tests but this specific usage of execCommand for the same purpose wasn't caught.

[jgraham]

Pull #928 is supposed to address this. I didn't test it though.

[jgraham]

Should be fixed now

[xiaojunwu]

Sorry for reply so late.
The spec says: Each input element has a boolean dirty value flag. When it is true, the element is said to have a dirty value. The dirty value flag must be initially set to false when the element is created, and must be set to true whenever the user interacts with the control in a way that changes the value.

I think it means that the dirty value must be set by user interaction, not by script.

We can find the 'user interaction' in the document interface. (http://www.w3.org/TR/html5/dom.html#the-document-object)
Those methods should simulate the user interaction although there is no explicit words or sentences in the spec.

[xiaojunwu]

Yes, the execCommand() requires that the edited element is editing host or editable. I think the input is editable in the default state although the designMode is not set to on. If my thought is not correct. I think below codes may fix the issue.

set_dirty: function(ctl) {
document.disgnMode = "on";
ctl.focus();
ctl.value += "a";
ctl.setSelectionRange(ctl.value.length, ctl.value.length);
document.execCommand("Delete");
document.disgnMode = "off";
},

[rniwa]

No, execCommand never works inside text fields in IE and Firefox. That document.execCommand("Delete") doesn't do anything regardless of whether you're in the design mode or not (it may modify random text elsewhere though).

In general, execCommand is an unspec'ed feature and should not be used in testing until that status changes.

We need to fix this test case not to use execCommand. Also see issues #928 and #2181.

[cvrebert]

For posterity: X-Ref: https://bugs.webkit.org/show_bug.cgi?id=149911