webpro / bron Goto Github PK

This package doesn't work with Node v8.x because of isPromise being introduce in 10.x https://nodejs.org/dist/latest-v10.x/docs/api/util.html#util_util_types_ispromise_value

and also doesNotReject take a function until 10.x
https://nodejs.org/docs/latest-v10.x/api/assert.html#assert_assert_doesnotreject_asyncfn_error_message

Change the readme in consequence.

When running bron on a file which throws an error outside a test() function, bron prints the error to the console but then exits with code 0.

That's bad when running bron in a CI because the CI reports everything is fine but actually no tests were run.

To reproduce this, simply run

npx bron brokenFile.js

where brokenFile.js contains for example

const foo = require( 'some-missing-module' );

or simply

foo