weiameili / pensela Goto Github PK

Hi,

Sorry for the template, GitHub Mobile didn't allow me to use issue forms.

I have tried taking numerous screenshots and checked my Pictures directory, my Documents directory but I can not happen to locate my screenshots. Can I know where screenshots are saved in Windows, macOS and Linux? That might help me if I happen to install Pensela on other OSes.

What's the Problem?

Great tool. like to add a few suggestion.

i've been using quite a few annotation tools and each has pro and cons. i enjoy using pensela because of the simplicit but do found it leak of a few essentail feature. things like to tooltips for each button, setting page, hotkey, stroke size

What's your solution or idea?

• resizable toolbar
• tooltip when hover each icon
• rightclick setting page for the tool
• adjust pen size
• press 'esc/del' to cancel action
• hotkey to toggle mouse/drawing mode
• hotkey for quick switch to other tools like arrow/del/move/pointer
• multiple drawing board (like keep the current drawing and start a new one). maybe is something like multitab drawing board.

Alternatives Considered

n/a

App Version

v1.2.3

OS Version

Win11

Additional context

No response

i3 is a minimal window manager: https://i3wm.org/
When pensela v1.2.3 is opened on i3 I can't find a way to configure it.

best results with: ~/.config/i3/config

for_window [instance="pensela"] floating enable

But results in a black window, with rendering persistence, that competes with the main application window

In the screenshot below, I've opened pensela, moved the black window below the main application, then drew 2 single lines.
I could only draw on the black window, I could not draw on my terminal screen (or any other window)

Kind words:
Very nice work though!; I'd love to see more screen annotation tools for linux.
I particularly like Lightshot, but it doesn't run native.

What's the Problem?

It's complicated always change color, shape or tool with the mouse cursor

What's your solution or idea?

It would ve great to have keyboard shortcuts to be able to change tools or colors, this could be enhanced with software like stream deck or touch portal

Alternatives Considered

I don't know, maybe this should be optional

App Version

v1.2.3

OS Version

Windows 10

Additional context

No response

I was looking forward to add support to MacOS, but I've noticed that you removed the electron-builder.json configuration file from the project, maybe you've removed it accidentally or don't want it on the project due to hard-coded secrets, if this last options, I suggest you to provide a configuration template so other people can build it. I'll create a configuration here so I can add support for MacOS.

What happened?

 ~/Downloads [1] => chmod u+x Pensela-1.2.5.AppImage
 ~/Downloads => ./Pensela-1.2.5.AppImage
[38734:0621/150532.558083:FATAL:gpu_data_manager_impl_private.cc(445)] GPU process isn't usable. Goodbye.
[1]    38734 trace trap (core dumped)  ./Pensela-1.2.5.AppImage

My computer:

 ~/Downloads [133] => echo $XDG_SESSION_TYPE
x11
 ~/Downloads => lspci | grep VGA
09:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Ellesmere [Radeon RX 470/480/570/570X/580/580X/590] (rev e7)
 ~/Downloads => uname -a
Linux feanor 5.15.0-39-generic #42-Ubuntu SMP Thu Jun 9 23:42:32 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Pensela version: 1.2.5 (can't select this in the "Pensela version" drop-down below).

What did you expect to happen?

I expected to see the app.

Pensela's version

Compiled from source

Code of Conduct

• I agree to follow this project's Code of Conduct

app appears massive and oddly scaled on my 3440x1440 monitor - see picture

What's the Problem?

The toolbar size is huge
Not possible to toggle auto hide/show the toolbar on hover

What's your solution or idea?

It is already a great tool, but I have noticed some points that could be really a great thing to have:

• Make toolbar size customizable, assuming it could be feasible thx to svg icons
• Make toolbar position customizable (top/bottom, right/left [vertical orientation])
• Set a toggle button to enable/disable on hover (when the mouse is on the screen border) auto-hide toolbar

Alternatives Considered

As an alternative/frist step, it could be a good start to reduce the toolbar size

App Version

v1.2.3

OS Version

Ubuntu 21.04

Additional context

No response

What happened?

When I start Pensela and I choose any tool, I can not leave drawing mode anymore. The whole Pensela window becomes unresponsive as such, that I can draw onto the Pensela window but I cannot switch tools anymore and I cannot click on anything.

This also means I cannot stop the program without killing it via the console.

I use version 1.2.4-1 installed via the AUR in Archlinux.

Btw version 1.2.4 is not choose-able in the issue creator.

What did you expect to happen?

That I can still control Pensela to switch tools and to stop the program

Pensela's version

Compiled from source

Code of Conduct

• I agree to follow this project's Code of Conduct

When I try to use the screenshot tool I get this error. From the message I notice the error in creating the directory and the path written incorrectly.
Tested on Windows 10.

What happened?

After freshly installing version 1.2.5, (sudo dpkg -i pensela_1.2.5_amd64.deb) I've tried to launch Pensela with the menu item.
It crashed immediately with signal 5.

I then tried to launch it from the command line in /opt/Pensela and got the following:

[88916:0307/110305.044168:FATAL:platform_shared_memory_region_posix.cc(255)] This is frequently caused by incorrect permissions on /dev/shm. Try 'sudo chmod 1777 /dev/shm' to fix.
Trappe pour point d'arrêt et de trace

the last point is that I don't have any /dev/shm device, so it's difficult to give it specified permissions...

I wonder if the .deb package lacks a dependency with some sharing memory software?

What did you expect to happen?

I expected to see ...

Pensela's version

v1.2.4

Code of Conduct

• I agree to follow this project's Code of Conduct

Allow current fullscreen screenshot feature to not capture the Pensela panel. This will allow a fullscreen capture with just the annotations.

Mostly I would want to grab a partial screenshot to clipboard and paste it into another program. It would be great if a copy to clipboard option was available. Maybe when the copy to clipboard button is pressed, show a dialog box stating that it's not in clipboard and ask if the user wants to also save the file.

It takes one screen instead of working on multiple screen configurations

I am using Pensela on i3. After setting it to float and excluding it from my blur effect in Picom, it works great visually. The problem is that when I draw on the drawing board, it focuses it and places it above the Pensela toolbar and I can no longer click on it. It's still usable for me, as I can place the toolbar on my second monitor so that the drawing board can't be above it. It seems as though this could be fixed relatively easily by adding a setting to make Pensela stay on top at all times.

It's hard to show this in an image, but during this screenshot my mouse was over the toolbar and I had tried clicking on it (you can't see it because I took the image with flameshot), yet at the top left you can see the drawing board is still the focused window.

Would love to see some screenshots in the README :)

After clicking the screenshot icon in the Pensela bar, the saved image of the screenshot is not found. But the directory named Pensela is found inside the Pictures directory. Inside that, no images were found. Checked the clipboard also. Not copied to clipboard also.
Am using Pop!_OS 21.04 and Pensela's recent release 1.2.3.

What happened?

Pensela is open in a Windows machine with an ultrawide display, it works correctly, but the toolbar take too much place in the screen.

The monitors are in extended mode side by side.

What did you expect to happen?

I expected to see a toolbar at the size of the taskbar of windows.

Pensela's version

Compiled from source

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

When clicked on the eraser icon in the menu the eraser is not showing up as a cursor and when used on drawings it is not erasing them

What did you expect to happen?

I thought that when I click on the eraser icon and try to erase(rub) on my drawing on my screen the will vanish.

Pensela's version

v1.2.4

Code of Conduct

• I agree to follow this project's Code of Conduct

Hi! This is a cool project and I'd like to help here. I just want to know if you need these:

• Issue Templates(Bug, Feature Requests, etc)
• Checks(for PRs so that you can know where the code is failing)
• Contributing guide
• Code of Conduct (Contributor Code of Covenant or something similar)
• License

I am making these as we speak. If you want, I can open a PR here. By the way, a question if you accept: What kind of license should I keep? There are a lot of them but I think the MIT License is best since it is widely used amongst GitHub projects.
Another question is: Does this project have social handles or Discord/Revolt servers? I could try linking them so that when people open issues, they can also visit them to see the process, or if you go to Settings and enable Discussions, I can add a link so that people can ask questions there while keeping the issue tracker(the Issues page) clean.

Add a partial screenshot capture button so users can select only the part of the screen they wish to capture