wernerd / gortp Goto Github PK

I read this code and found a problem：
In sessionlocal.go #137
delete(rs.streamsOut, idx)
I think it should changed to
delete (rs.streamsIn, idx)
Maybe I am wrong, hope to reply as soon as possible

Hello and thanks for a very useful library.

I've noticed that func (rs *Session) WriteData(rp *DataPacket) (n int, err error)
always returns n=0 regardless of the outcome of writing into transport.

Looks like the named return value n is never being assigned.

https://github.com/wernerd/GoRTP/blob/master/src/net/rtp/session.go#L716

Is this expected behaviour?

Thanks!

I have forked your GoRTP library and noticed that there are no licences attached to your project. Would you consider adding a licence such as common creative or MIT?

panic: runtime error: slice bounds out of range

goroutine 1937020 [running]:
github.com/wernerd/GoRTP/src/net/rtp.(*DataPacket).Payload(0xc422cf4770, 0xc4236d7a10, 0xef9d273c61c19b01, 0xc42136c4a0)
/home/albert/code/gocode/src/github.com/wernerd/GoRTP/src/net/rtp/packets.go:381 +0x106
github.com/wernerd/GoRTP/src/net/rtp.(*SsrcStream).recordReceptionData(0xc4200dc240, 0xc422cf4770, 0xc422e8e000, 0x1578b7d9d46f7f6a, 0xc422096501)
/home/albert/code/gocode/src/github.com/wernerd/GoRTP/src/net/rtp/stream.go:493 +0xe5
github.com/wernerd/GoRTP/src/net/rtp.(*Session).OnRecvData(0xc422e8e000, 0xc422cf4770, 0x0)
/home/albert/code/gocode/src/github.com/wernerd/GoRTP/src/net/rtp/session.go:477 +0x28c
github.com/wernerd/GoRTP/src/net/rtp.(*TransportUDP).readDataPacket(0xc42055ee60)
/home/albert/code/gocode/src/github.com/wernerd/GoRTP/src/net/rtp/transportUDP.go:170 +0x171
created by github.com/wernerd/GoRTP/src/net/rtp.(*TransportUDP).ListenOnTransports
/home/albert/code/gocode/src/github.com/wernerd/GoRTP/src/net/rtp/transportUDP.go:64 +0x14a

Apologies if this is an RTFM fail on my part.

I'm trying to use this library to connect to multiple remotes, each of which is sending their own stream. I'd like to be able to sort out which incoming packet comes from which remote, without opening different ports for each remote. What's the best way to handle this? I see there's an address attribute of RawPacket, but it's private. What am I missing?

If there's a better channel for this question I'd be happy to redirect it. Thanks.