wernerjoss / grav-plugin-caldav2ics Goto Github PK

Just to let you know... See getgrav/grav#3309

Nextcloud supports share URL, and it outputs ICS file without any requirement for authentication.

• onAdminAfterSave and $config = $this->config()
  The name onAdminAfterSave may cause some confusion. Although the data has been saved to disk, the variable $config does NOT reflect the newly saved data, but instead still reflects the previous state.

  To get the newly saved data, you need to reference $event['object'], which contains the data being submitted by the user.

  /** @var Data */
  $data = $event['object'];   <-- Contains the new data submitted by Admin
  $isEnabled = $data['enabled'];
  $hasJobsEnabled = $data['scheduled_jobs']['enabled'];
  

• $config['enabled'] is quite useless.
  If the plugin is not enabled, function getSubscribedEvents() will not be called and hence your events will not be enabled and $config['enabled'] will never be evaluated. On the other hand, if the plugin is enabled, $config['enabled'] will always be 'true'.

• To skip processing of onAdminAfterSaved on every submit of Admin you could do:

  /** @var Uri */
  $uri = $this->grav['uri'];
  
  if ('caldav2ics' !== $uri->basename()) {
       return;
  }