wfgilman / plaid-elixir Goto Github PK

Right now we're having to derive the Jason.Encoder protocol on everything we need to serialize... not a huge deal, but since it's the default in Phoenix, it might be worth doing this by default.

What do you think?

This is what we have now:

require Protocol

Protocol.derive(Jason.Encoder, Plaid.Transactions.Transaction.Location)
Protocol.derive(Jason.Encoder, Plaid.Transactions.Transaction.PaymentMeta)
Protocol.derive(Jason.Encoder, Plaid.Institutions.Institution)
Protocol.derive(Jason.Encoder, Plaid.Institutions.Institution.Credentials)
Protocol.derive(Jason.Encoder, Plaid.Institutions.Institution.Colors)

From what i can tell the plaid api looks a lot different than how this is designed

Hey,

we've been using this library for some time now and now we came across a need for putting some metrics around HTTP calls our system makes. We've been thinking of adding some telemetry events emitting to Plaid library itself to allow anybody using it handle them and later report. Our suggestions would be to have a set of events similar to this:

• plaid.request.start (measurement: system_time)
• plaid.request.stop (measurement: duration)
• plaid.request.exception (measurement: duration)
  All of them would have metadata containing basic request info (path, status code, url etc.).

We're happy to implement it ourselves, let us know what you think.

Currently Plaid.Utils.map_body/2 is privately defined, but this can be useful externally to libs. For instance, implementing an Ecto.Type behaviour.

This parsing functionality could be safely moved into its own module and called from Plaid.Utils.handle_resp/2 to maintain the existing public signature.

Moving this to somewhere like Plaid.Middlewares.ResponseHandler makes a lot of sense to me.

Sorry, maybe this is obvious, but I've looked through the API and can't find a way to get an access_token. I see how to rotate a token once I already have one, but not create one in the first place.

I have an account with plaid, and have enabled development access.

Can you help?

Is there any reason why this is not implemented so far? Seems like it conforms to what already exists in terms of architecture and fetching would mean tweaking the endpoints as done in the various products, right?

Need this for a service I am working on and wanted to know what limits us from having it on this package, if any.

The params and config types can use a review and normalization. params can vary depending on the type of payload accepted by the specific call to Plaid, but config should be standard for all function calls given it uses internal, consistent parameters.

Hey, great work.

Is there any hope of supporting Plaid Transfer?

I just tried out #24 and functions like Plaid.Accounts.get/2 still call get_cred/0 which raises if public_key, client_id & secret are not set in the application config for :plaid.

I put in some "N/A" for now, which is getting me by, but ideally I wouldn't have to set those at all.

Restructure test suite to decouple the business logic from the HTTP client.

Hey y'all, this library is fantastic. Thank you so much. I am using
Institutions.get() and my response comes back with nils. I logged the following http response in Plaid.Utils and it came back as expected.

  def handle_resp({:ok, %HTTPoison.Response{status_code: code} = resp}, endpoint)
      when code in 200..201 do
    {:ok, map_response(resp.body, endpoint)}
  end

Any ideas on what this could be? My Plaid credentials / env vars have been no issue with the rest of this library.

Plaid made this product available very recently. I'm already made most of the required changes to support this, I'll push a PR soon.

Hi @wfgilman -- sorry for opening an issue but I don't have a better way to get in touch with you.

Anyway, I'm on the Developer Relations team at Plaid and I just wanted to say thanks for your work maintaining this library.

As a thank-you we'd like to send you a small Plaid care package. If you're interested, can you let me know your shipping address, t-shirt size, and if there are any items you'd particularly like? You can DM me on Twitter at @plaiddev or email [email protected].

Thanks,
Alex

P.S. If you haven't already seen it, you might be interested in our newly-published OpenAPI file at https://github.com/plaid/plaid-openapi, which is designed to make Plaid SDK generation easier -- we'd love to hear any feedback you might have!

Hey, we could use your lib where I work, I was wondering if you would accept some suggestions?
Would it be ok if we could implement

• The authentication endpoint
• Make json parse and http client configurable?

Very particular.

According to the docs, public_key is required for:

POST /institutions/search
POST /institutions/get_by_id

and it's apparently now allowed for any other call. This affects the dynamic config where I'm just passing everything in.

Is there a particular reason for why the Item struct doesn't contain the consent_expiration_time information that Plaid's api returns?

https://plaid.com/docs/#item-schema

Looks like delete got renamed to remove in 830dfc3, any chance we could get those changes published to Hex? I'm just about to implement removing an item. Thanks!

Plaid has deprecated the use of public key auth in APIs, and new accounts can't even generate a key. As best as I can tell, this means I can't use plaid-elixir to pull institution information, since it forces the existence of a configured public key.

Looking at the implementation, it appears that this could be as simple as swapping out usages of validate_public_key for validate_cred. I'm not sure what kind of backward capability you're looking to maintain though. Anything I'm missing? If not, I can start working on a PR. Thanks!