Original HTML multipage spec links broken - needs redirect fix about whatwg.org

[foolip]

Looking through whatwg.org.conf looking for other "squashing" redirects I don't see anything else that looks suspicious, so I think we're good here.

[annevk]

Thanks. I'm guessing this must have regressed as part of the move to Nginx. https://github.com/whatwg/misc-server/blob/master/debian/marquee/nginx/sites/whatwg.org.conf#L124 doesn't seem to account for multipage/ links.

@foolip?

[foolip]

The original Apache setup is in 928a87b.

I was quite conservative in the conversion and AFAICT this ought to not have worked before either. Hard to say with confidence without erecting the Apache server again though.

Anyway, I can make them work.

[annevk]

In particular redirect 301 /specs/web-apps/current-work/ https://html.spec.whatwg.org/ suggests to me that https://whatwg.org/specs/web-apps/current-work/x would go to https://html.spec.whatwg.org/x. Currently that just redirects to https://html.spec.whatwg.org/.

[annevk]

Nginx seems to do some kind of catch-all approach rather than forwarding the original subpath+query.

[foolip]

Aha, you're right, that "multipage" didn't appear in the destination URL doesn't mean it didn't work.

[annevk]

We should probably also vet the other redirects just in case we turned more into catch-all where we simply wanted to forward the original subpath+query (no idea what the term for this would be).

[foolip]

I'm pretty sure the problem here is at "fall back to single-page HTML". Any return 30x line that doesn't have a $1 or $2` in it is redirecting everything to a fixed URL. I had to make some judgements about things like that, but this one was a mistake and not deliberate.

[annevk]

Okay, I guess we do have plenty of redirect tests already so we just need to add some for this.

[foolip]

OK, so what I didn't realize was that the original "redirect 301 /specs/web-apps/current-work/ https://html.spec.whatwg.org/" was intending to preserver a trailing /multipage/. An easy fix coming up.

[foolip]

http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#other-link-types works with whatwg/misc-server#63

[annevk]

Thanks @tantek!

[annevk]

(Note that you might have to clear cache to get this to work.)

[tantek]

Works great. Thanks for the quick fix @foolip @annevk !