Inerting element in shadow DOM throws error about inert

[LouisStAmour]

Never mind, I just read the spec. Indeed it’s supposed to always return false. My mistake

[bkardell]

hmm... the active element winds up being null in https://github.com/WICG/inert/blob/master/dist/inert.js#L251

should default it to root?

[valdrinkoshi]

This seems more a bug of node-contains, as the native Node.contains accepts undefined or null as parameter - e.g. document.body.contains(undefined)

[straker]

So should the contains polyfill just return false if other is falsey?

return other && (node === other || !!(node.compareDocumentPosition(other) & 16) )

[valdrinkoshi]

Yeah something on those lines

[LouisStAmour]

It’s actually not a node-contains bug because it’s a precondition error if null is passed in to contains, at least according to a Firefox bug report I saw. You need a try catch or you need to check first. My fix mentioned in #64 is correct.

[straker]

So we're going on a week now and I haven't heard from the creator of node-contains about the pr. It hasn't been updated in 3 years, should it's code just be consumed and updated?

[robdodson]

yeah probably, looks simple enough