Array.from present in umd build of inert.js about inert

[robdodson]

Good catch. We can probably work around this using the [].slice trick

…

On Fri, Oct 6, 2017, 10:40 AM morsmodr ***@***.***> wrote: The example page https://wicg.github.io/inert/index.html also breaks on IE 11 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBFDZXx9Fz05ViAvFpTrBqYJ3dO_pnBks5spmYTgaJpZM4Pwy6I> .

[morsmodr]

The example page https://wicg.github.io/inert/index.html also breaks on IE 11

[robdodson]

Fixed (ca1d7f7) and updated on npm

[joe-watkins]

HI Rob! Is the demo calling that right dist file? It is calling a version that has array.from in it still.

From demo page:
https://wicg.github.io/inert/index.html

<script src="dist/inert.js"></script>

https://wicg.github.io/inert/dist/inert.js

[robdodson]

oh i can fix that. I think that whole demo page is outdated tbh. It's a stale publish to gh-pages I think.

[joe-watkins]

@robdodson tnx! Side note - I was all excited to employ this polyfill for a large client and had to yank it due to IE bugs and a babel.js polyfill dependency. I wish this thing reached more because it totally rocks!

[robdodson]

Which IE bugs did you encounter?
Also, why was the babel polyfill an issue? I believe you should be able to feature detect it so it only gets included in IE pages?

[joe-watkins]

Howdy @robdodson :)

First ran into the array.from() bug in this issue, which appears to be fixed with your splice approach. So moved to the more recent umd build and then ran into a Symbol.iterator bug. Looks like IE doesn't play with that either.

The client wasn't into adding another 100k for babel's polyfill -- even conditionally.

Would you like me to create an issue for the IE Symbol.iterator bug?

[robdodson]

yep, thank you :)

…

On Wed, Feb 28, 2018 at 3:45 PM Joe Watkins ***@***.***> wrote: Howdy @robdodson <https://github.com/robdodson> :) First ran into the array.from() bug in this issue, which appears to be fixed with your splice approach. So moved to the more recent umd build and then ran into a Symbol.iterator bug. Looks like IE doesn't play with that either. The client wasn't into adding another 100k for babel's polyfill -- even conditionally. Would you like me to create an issue for the IE Symbol.iterator bug? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBFDd3V5YKZxo4fm2PishNDfWECnRq5ks5tZeU2gaJpZM4Pwy6I> .

[robdodson]

Digging into this a bit more, it definitely looks like the polyfill is busted in IE. I've been meaning to revamp the tests for it like we did for focus-visible. Will have to dedicate some time to that soon :\ @alice fyi.