GithubHelp home page GithubHelp logo

forge's People

Contributors

jdacosta avatar myeti avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

forge's Issues

Roadmap for v3

  • Fix this issue : #3
  • Using the sass-embedded library : https://www.npmjs.com/package/sass-embedded
  • View write logs instantly
  • Replace Parcel by the Esbuild library
  • Find a solution to the fact that Browsersync reloads on every write. Potentially, we have to wait for a group of writes before a page reload.
  • Update all dependencies
  • Make sure you compile with the latest version of node (Node 14 minimum required)
  • Delete the Faker library
  • Use pure ESM package
  • Find a solution to create groups of parallel tasks (the goal is to avoid loading too many tasks at the same time)

Sass configuration: adding output group

It may be useful to create more than one output group.

Here's an example:

module.exports = {
  sass: {
    observe: '**/*.{scss,sass}',

    entries: [
      // group A
      //  -> desired output: assets/css/FILENAME.css
      'assets/{scss,sass}/*.{scss,sass}',

      // group B
      //  -> desired output: assets/css/components/FILENAME.css
      'views/blocks/**/*.{scss,sass}',
      'views/includes/**/*.{scss,sass}',

      // group C
      //  -> desired output: assets/css/pages/FILENAME.css
      'views/pages/**/*.{scss,sass}',
    ],

    output: 'assets/css'
  }
}

Sass configuration: being able to ignore files in the entry point

For the sass configuration, it does not seem possible to ignore the files in the entry point.

Here's an example:

module.exports = {
  sass: {
    observe: '**/*.{scss,sass}',

    entries: [
      'assets/{scss,sass}/*.{scss,sass}', 
      '!assets/{scss,sass}/core.{scss,sass}' // <-- this line not working :(
    ],

    output: 'assets/css'
  }
}

Sass compilation creates duplicate selectors with inheritance

Hello,

We currently have a strange behavior with sass compilation using forge.

Here's a simplified concrete example:

  • In src/assets/scss/entries/50-organisms.scss
@use '~/core' as *;
...
@use '@/organisms/page/header';
...
@include header.init;
  • In src/views/blocks/organisms/page/header.scss
@use '@/atoms/ui/link/link' as *;
%link {
  text-decoration: underline
}
%link-test {
  @extend %link;
  height: auto;
}
@mixin init() {
  .link-test {
    @extend %link-test;
  }
}
  • Result after compilation in dist/assets/css/50-organisms.css
...

/* KO */
.link-test {
  height: auto;
}
...
/* OK */
.link-test {
  text-decoration: underline
}

...

It only happens when we use inheritance in sass files, otherwise compilation isn't creating other duplicate selectors.
We've disabled any post process to check but it also failed.
It was also tested with the latest versions of forge & modulus.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.