widoz / template-loader Goto Github PK

Add a facade.

Everything must be defined during instantiation.

Creating an interface will allow us to pass every type of instance instead of manipulate objects to obtain the properties values.

In this way the loader will be indipendently by the data type and the view will be able to use any kind of data.

namespace TemplateLoader;

interface TemplateData {}

Render method has just to render and returing a string.

Sometimes the $data object isn't necessary but we must create an instance in anycase.

So, let's use null if no data is used.

In order to prevent third party code to hook and edit in wrong way the path for the template file I think a validation/sanitization may be useful for the path.

Also, we should be sure that the path belong to the wp-content/plugins or wp-content/themes/{current-active-theme} or the parent theme.

• https://github.com/Automattic/phpcs-neutron-standard
• Variable Analysis
• Object Calisthenics

Instead of looking every time for the same files, using an additional static property as array where store the found paths will improve speed.

The plugin path will not be correctly if the template loader is used as composer package.

So, remove the Plugin class and introduce an additional arguments to the contructor for Loader that will be the plugin directory path.

public function __construct($slug, DataStorage $storage, $templatePath = null, $pluginPath = '')
    {
        $this->slug        = Sanitizer::sanitizeSlugRegExp($slug);
        $this->data        = null;
        $this->dataStorage = $storage;
        $this->pluginPath  = $pluginPath;

        $this->setTemplatePath($templatePath);
    }

then in pluginFilePath 

...
} elseif (is_string($tmplPath)) {
            $pluginPath = untrailingslashit($this->pluginPath);
            $tmplPath   = ltrim($tmplPath, '/');
            $path       = Sanitizer::sanitizePath("{$pluginPath}/{$tmplPath}");
        }

...
``` 

Check for unneeded methods.