GithubHelp home page GithubHelp logo

windmill-helm-charts's People

Contributors

24601 avatar amitai-devops avatar anton-shutik avatar avo-sepp avatar bootc avatar brunobriante avatar c0bra avatar deepak-endowus avatar elementtech avatar ethanmdavidson avatar freimer avatar hcourdent avatar lplit avatar martysmojo avatar martysohio avatar matt-funda avatar momentmaker avatar niklasrosenstein avatar pcmid avatar philstel avatar rubenfiszel avatar tdeckers-cisco avatar thebsosa avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

windmill-helm-charts's Issues

Init Script in not available in the Worker Management UI

Hi,

The Init Script box parameter seem not available in the Worker Management UI when using this Helm chart.
I m using the Helm chart with Windmill CE v1.181.0 docker image.

Capture d’écran 2023-10-10 à 08 11 09

If I use the same image with the Docker-compose file provided in the doc, the Init Script box is available, and the Worker Management UI looks different.

Capture d’écran 2023-10-10 à 08 16 27

Am i missing something ?

Thanks !

Unable to pass http_proxy environment variables to windmill scripts

Hi all

I'm not sure if this is a problem that only occurs with the windmill helm-chart, but I am unable to configure windmill to use a HTTP-Proxy.
I already tried to pass the variables http_proxy and https_proxy as extraArgs to all the windmill deployments in the helm values and I was able to "kubectl exec" into the containers and access the internet using the configured http-Proxy.

However, when i try to run a python script in Windmill, the proxy does not seem to work. I cannot import any python modules from the internet.

image

When I run "print(os.environ)", my envs (http_proxy & https_proxy) do not show up.

Is this behaviour expected and is it somehow possible to pass global envs to windmill scripts?

Thanks and kind regards
Robin

Wrong appVersion in Chart.yaml

Hi, the latest commit bumps the appVersion to "1.222.0", that image tag does not exist, the latest tag is "1.220.0".
Typo?

Thanks :)

Upgrade using 1.181 images not work

HI guys,

I m trying to use the latest Windmill docker image with this Helm chart but it crash

Error: Migrating database: while executing migrations: error returned from database: syntax error at or near "TRIGGER"   

Can you help please ?

Global labels & annotations

Hi team 👋🏼

It would be nice to have a global rewriting of labels and annotations on top. Cause on my IDP (Qovery) there are some missing and I can't:

  • display services logs
  • stop the chart
  • display services statuses

For example:

windmill:
    annotations:
      qovery.annotations.service
    labels:
      qovery.labels.service

I'm available for testing if needed 👌🏼
cheers 🍻

Enabling exposeHostDocker: true adds duplicate volumes key

When setting exposeHostDocker: true, the volumes key is present twice in the worker manifests:

which fails to deploy updates when using Gitops where this is validated before applying the manifests (i.e. FluxCD)

Wrong indentation for resources block

resources:
{{ toYaml .Values.windmill.app.resources | indent 12 }}

There is an extra indent at the beginning here, when setting resources for app, the following error will be reported.

Error: YAML parse error on windmill/templates/app.yaml: error converting YAML to JSON: yaml: line 84: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 84: did not find expected key
YAML parse error on windmill/templates/app.yaml

Better secrets control

Currently the helm is reading secrets trough environment variables. This limits the way we can inject secrets into the deployment.

Add support for reading secrets from files.
Add Env variables that point to files instead of directly to the secret value
DATABASE_URL_FILE="/some/container/path/file"

This will also adapt to different secret management methods. Like when using Hashicorp vault and dynamic database credentials

BYPASSRLS not allowed on Azure flexible Postgres db

Hi, regarding the use of a managed Postgres database in Azure, superuser access is not given to the owner. Therefore, there's no way to give BYPASSRLS permissions. The init-db SQL file may need to be adjusted to match scenarios where superuser is not given in cloud-hosted managed databases.

Issue for windmill main repo, please close

Error: UPGRADE FAILED: failed to create resource: Deployment.apps "windmill-workers-dedicated-mydedicatedWorker" is invalid:

Sorry to bother you again, but the next error appeared. The error message is Error: UPGRADE FAILED: failed to create resource: Deployment.apps "windmill-workers-dedicated-mydedicatedWorker" is invalid: metadata.name: Invalid value: "windmill-workers-dedicated-mydedicatedWorker": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

In short, here your default value is written in camelCase https://github.com/windmill-labs/windmill-helm-charts/blob/main/charts/windmill/values.yaml#L107 which is a bad idea, when that ends up to be part of name of an k8s resource respectively deployment.

See
https://github.com/windmill-labs/windmill-helm-charts/blob/main/charts/windmill/templates/dedicated-workers.yaml#L7C43-L7C43

No need to hurry, I can work around that by setting a value by myself but I think it is better to fix it for the future.

Allow configuring relevant Kubernetes overrides

I've noticed some slowness in general while using the helm chart. The UI gets stuck often. I would be glad if I could:

  • Configure resources so I can give the pods more juice and hopefully overcome slowness
  • Configure autoscaling for frontend/workers
  • Configure annotations/tolerations/affinity
  • etc

Replicas seems to not working

Hi team 👋🏼

I'm using Windmill chart on Qovery IDP for context.

But when I change replicas it doesn't seems to change the number of workers:
Screenshot 2024-02-16 at 10 13 59

Here my rewrite values for testing purposes:

postgresql:
  enabled: false
windmill:
    databaseUrl: qovery.env.DATABASE_URL
    annotations:
      qovery.annotations.service
    labels:
      qovery.labels.service
workerGroups:
  - name: "default"
    replicas: 2
    resources:
      requests:
        memory: "512Mi"
        cpu: "500m"
      limits:
        memory: "1024Mi"
        cpu: "1000m"
    annotations:
      qovery.annotations.service
    labels:
      qovery.labels.service
  - name: "native"
    replicas: 0
    resources:
      requests:
        memory: "256Mi"
        cpu: "100m"
      limits:
        memory: "256Mi"
        cpu: "100m"
    annotations:
      qovery.annotations.service
    labels:
      qovery.labels.service
  - name: "gpu"
    annotations:
      qovery.annotations.service
    labels:
      qovery.labels.service
app:
  annotations:
    qovery.annotations.service
  labels:
    qovery.labels.service
lsp:
  annotations:
    qovery.annotations.service
  labels:
    qovery.labels.service
multiplayer:
  annotations:
    qovery.annotations.service
  labels:
    qovery.labels.service
ingress:
  enabled: false
serviceAccount:
  annotations:
    qovery.annotations.service

available for testing if needed 👌🏼
Cheers

External database missing role setup

When bringing my own database, by setting databaseUrl, I encounter a couple of issues.

  1. I need to manually create windmill_user and windmill_admin roles, otherwise some of the pods error.
  2. After logging in as the default user I get Not found: App not found at name g/all/setup_app, which means I don't substitute the default user for my own etc.

Why is is default user Root and runAsNonRoot false?

Hi,

Question is in the title. The default configuration for Windmill's Helm chart sets Windmill as root. Is there a developer reason for this? It impacts our ability to install Windmill in clusters with security features enforced. Does Windmill need to be run as root?

If it's not required for Windmill then I'd like to unset it from the default and maybe consider making some improvements to the Helm chart to meet higher security defaults.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.